botanicvelious / equipment-inspector Goto Github PK

A toggle to only show the "Equipment" right-click option on other players when you hold shift would be a nice addition that would reduce the clutter of the right click menu.

not working at all currently 2/9/2024

currently when inspecting players in F2P worlds (yeah I don't pay for RS) Member items just show up with the name "Member's Object"
Would be nice to actually get the item name and instead show it in red, or pink or some other colour (user-customizable maybe) and that way a free player would still know what the item is

Celestial ring and Celestial signet uncharged and charged versions don't show up.

Info:
runelite/runelite#17284
https://discord.com/channels/301497432909414422/419891709883973642/1185657860793847848

After approx mid January the plugin will stop working due to the flatlaf migration.

When you try to inspect someone with assertions enabled, you receive the following error:

[AWT-EventQueue-0] ERROR net.runelite.client.RuneLite - Uncaught exception:
java.lang.AssertionError: getItemComposition must be called on client thread
	at net.runelite.client.game.ItemManager.getItemComposition(ItemManager.java:386)
	at net.runelite.client.game.ItemManager.getItemPrice(ItemManager.java:308)
	at net.runelite.client.game.ItemManager.getItemPrice(ItemManager.java:287)
	at equipmentinspector.EquipmentInspectorPanel.lambda$null$0(EquipmentInspectorPanel.java:99)
	at java.util.HashMap.forEach(HashMap.java:1289)
	at equipmentinspector.EquipmentInspectorPanel.lambda$update$1(EquipmentInspectorPanel.java:96)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

I think it'd be nice to have the ability to click an item and be directed to the equipment's wiki page. Helps people out who are unsure what an item does.

Hello,

If i click "Equipment" on someone in f2p it would list member items as "Member item"
Is it possible that it would show the item name?

Unsure what is causing this at the moment.

I've been using the plug-in for a while now and loved it. A few weeks ago I noticed that the "Equipment" option was gone from my right-click menu when clicking on players. I tried enabling the "hold shift" option, to no avail either.

I have asked others in game, and most do not seem to be effected by this bug, so I suspect it may be some kind of conflict with another plug-in or something arbitrary with settings. I am going through them and trying to determine what that might be.

I have seen reports on reddit and other media about this as well, definitely a minority, but worth putting here. I will keep updated if I find a fix in the meantime.

When i click on the menu option Equipment it bring me to the plug in tab but says no player selected.

I've had it set to show equipment without shift ever since I started using it now i have to toggle shift on in order to use it and it doesn't even work half the time.

Since player/NPC render distance is so bad, I think this might help the plugin do its thing more consistently.

Opened a PR:

#20

Can we add a toggle to enable/disable the behavior added in #32 ? I preferred it the old way.

The icon is permanently shown on the sidebar, and with the evergrowing list of plugins adding icons on that sidebar it makes it really difficult to manage them. Going through my icons I saw this plugin but it's never actually used, only when you right click someone and press Equipment on them. It would be nice if the icon is hidden until you press Equipment on a player and then it reappears while you're looking at their equipment.
Thank you

this issue keeps happening whenever both plugins are in use. I'm not sure what's causing the conflict however.

Right clicking on a player no longer shows the option to view their equipment. I've tried toggling the "hold shift" option as well as uninstalling and reinstalling the plugin itself, but it's still not working. I think this started a week or two ago. I'm using RuneLite version 2.6.4 through the official Jagex launcher.

This plugin is one of my favorites so any and all help is appreciated!

Just noticed by randomly inspecting someone at GE.

This could probably be fixed by changing to AtomicLong?

https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/atomic/AtomicLong.html

This bug might be in individual item prices as well, didn't check.

When I select a player to lookup, it just tells me "no player selected".

click the items and go to wiki page for it? would be perfect

Is it possible to either get toggle for the "Inspect Equipment (playername)" right click option to just show as "Inspect (playername)" to keep the right click menu "compact"? It looks strange to have such a long line in the right click menu.

Example as follows, seems to have happened after the latest runelite update.
Runelite version : 1.10.20.2
Launcher version : 2.6.10

i've been trying to minimize my plugins, and therefor trying to remove some of the rightclick player options

is it possible to make rightclick "equipment" shift-rightclick instead? i want to have the ability to check peoples equipment, but not have the option enabled at every rightclick. same goes for hiscores lookup.

If you have installed plugins that add other player options (such as bot detector, high scores, etc), they may conflict with this plugin. You can only have 7 total player options in runelite currently.