boudewijnbout / connect-your-tribe-fdnd-visitekaartje

Redesign je visitekaartje op basis van een bestaande API.

Hi there 👋

My name is Boudewijn Bout. I'm a 23 year old Junior Full-Stack Developer living near Amsterdam.

connect-your-tribe-fdnd-visitekaartje's Issues

Remove empty line here?

connect-your-tribe-fdnd-visitekaartje/scripts/main.js

Line 16 in 4d2c5fd

Load data from API into personal card

Create general documentation for project

Are you sure you want to support old legacy browsers?

connect-your-tribe-fdnd-visitekaartje/index.html

Line 8 in 4d2c5fd

<meta http-equiv="X-UA-Compatible" content="ie=edge" />

Create readme

Don't use pixels for context dependant properties, like width and height

connect-your-tribe-fdnd-visitekaartje/styles/style.css

Lines 52 to 53 in 4d2c5fd

	width: 48px;
	height: 48px;

Handle logic in separate function for better readability?

connect-your-tribe-fdnd-visitekaartje/scripts/main.js

Lines 17 to 23 in 4d2c5fd

	if (res.status >= 200 && res.status <= 299) {
	preLoaderWrapper.classList.add("hide");
	return res.json();
	} else {
	preLoaderWrapper.classList.add("hide");
	}
	})

???

connect-your-tribe-fdnd-visitekaartje/index.html

Line 67 in 4d2c5fd

je vader

Why use a id attribute on the heading here?

connect-your-tribe-fdnd-visitekaartje/index.html

Line 37 in 4d2c5fd

<h1 id="name-title"></h1>

Create name title with seperator lines

Remove unused CSS

Missing pseudo element selector

connect-your-tribe-fdnd-visitekaartje/styles/style.css

Line 62 in 4d2c5fd

.preloader {

Scroll to the right, while viewing video background

Return a value instead of cascading to next function here?

connect-your-tribe-fdnd-visitekaartje/scripts/main.js

Lines 27 to 35 in 4d2c5fd

	const boudewijnData = res.data.find((student) => student.memberId === 18);
	// Put data into HTML
	// Title
	nameTitle.textContent = `${boudewijnData.name} ${boudewijnData.surname}`;
	// Bio
	bioText.textContent = boudewijnData.bio;

As explained here

Use a list here for better a11y

connect-your-tribe-fdnd-visitekaartje/index.html

Lines 48 to 61 in 4d2c5fd

	<!-- LinkedIn -->
	<a href="https://www.linkedin.com/in/boudewijn-bout-a4733b176/">
	<img src="assets/images/216394_linkedin_social_icon.svg" alt="LinkedIn Logo" />
	</a>
	<!-- GitHub -->
	<a href="https://github.com/boudewijnbout">
	<img src="assets/images/8546854_git_icon.svg" alt="GitHub Logo" />
	</a>
	<!-- Instagram -->
	<a href="https://www.instagram.com/boudewijn.nb/">
	<img src="assets/images/1161953_instagram_icon.svg" alt="Instagram Logo" />
	</a>

Commenting strategy, what versus why?

Your commenting extensivily 'what' your code is (doing), but most of it is self explanatory.
You might want to consider only adding comments explaining 'why code is there in the first place', as explained in this video:

https://youtu.be/goy4lZfDtCE?t=499

Add media query's