bpmn-io / ids Goto Github PK

Describe the Bug

Set node-engine to >=16 in commit 247af14.

Steps to Reproduce

1. build project with this dependency defined as ^1.0.0 with node-version lower than 16

Expected Behavior

Build will be possible.

Whit your set node-version you broke all projects depending on this dependency (e.g. using bpmn-js).
Engine-changes should at least be a minor fix and no patch fix! Please follow the guidelines from https://semver.org/.

Environment

• node-version 12.22.8

Describe the Bug

ids v1.0.4 build error

I delete my project node_modules folder and run yarn install in Terminal, then run yarn build, but build failed.

Steps to Reproduce

1. delete node_modules folder
2. yarn install
3. yarn build
4. now this happens

Module not found: Error: Can't resolve 'ids' in '/xxx/node_modules/bpmn-js/lib/draw'
@ ./node_modules/bpmn-js/lib/draw/index.js 1:0-42 8:26-38
@ ./node_modules/bpmn-js/lib/core/index.js 1:0-33 6:4-14
@ ./node_modules/bpmn-js/lib/Viewer.js 3:0-32 66:2-12
@ ./node_modules/bpmn-js/lib/NavigatedViewer.js 3:0-30 16:2-13 19:26-32 29:2-27

Expected Behavior

build success

Environment

• Host node.js v16.20.0, yarn v1.22.19
• OS: macOS 13.4.1
• Library version: ["bpmn-js": "^8.8.3", "ids": "1.0.4"]

Describe the Bug

"dependencies": {}

Steps to Reproduce

1. do this
2. do that
3. now this happens

Expected Behavior

Environment

• Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
• OS: [e.g. Windows 7]
• Library version: [e.g. 2.0.0]