bpolaszek / cartesian-product Goto Github PK

There's a bug preventing to unroll the same cartesian product object twice:

use function BenTools\CartesianProduct\cartesian_product;

$data = [
    'hair' => [
        'blond',
        'black'
    ],
    'eyes' => [
        'blue',
        'green',
        function (array $combination) { // You can use closures to dynamically generate possibilities
            if ('black' === $combination['hair']) { // Then you have access to the current combination being built
                return 'brown';
            }
            return 'grey';
        }
    ]
];

$combinations = cartesian_product($data);
foreach ($combinations as $combination) {
    printf('Hair: %s - Eyes: %s' . PHP_EOL, $combination['hair'], $combination['eyes']);
}

foreach ($combinations as $combination) {
    printf('Hair: %s - Eyes: %s' . PHP_EOL, $combination['hair'], $combination['eyes']);
}

Produces:

Hair: blond - Eyes: blue
Hair: blond - Eyes: green
Hair: blond - Eyes: grey
Hair: black - Eyes: blue
Hair: black - Eyes: green
Hair: black - Eyes: brown
PHP Notice:  Undefined index: eyes
Notice: Undefined index: eyes
Hair: blond - Eyes: 
PHP Notice:  Undefined index: eyes
Notice: Undefined index: eyes
Hair: black - Eyes: 

I've created a benchmark in order to compare my own cartesian iterator implementation with others, including yours: https://github.com/PatchRanger/php-cartesian-benchmark . It looks like your library is the best in all cases except the last synthetic one. I believe you may want to add the link to the benchmark to README in order to convince to use your library. Up to you.

    round(memory_get_usage() / 1024 / 1024),
    round(memory_get_peak_usage() / 1024 / 1024)

memory_get_usage() capture before the cartesian function is called should be subtracted from these results to not pollute it with autoloading and what not which is done before that.

Also these functions are the best for getting a memory profile. Use xdebug profiler for good memory usage information. But don't do benchmarking and profiling at the same time because profiling slows down code.

0 MB / 1 MB could be more accurate, maybe use bigger test input

Hey, I've run into your useful library and as far as I see it's the only one that does cartesian products while preserving string keys. However, it does not support Iterator as subsets, because of this exception being thrown

My use case is to do cartesian product of two mongodb cursors.

Hello,
Can you library do this?
$data = [
'hair' => [
'blond',
'red',
],
'eyes' => [
'blue',
'green',
'brown',
],
'gender' => [
'male',
'female',
]
];

Generate all combinations based on pick any 1 item from hair, pick any 2 items from eyes and any 1 item from gender. And where it can be any number of item arrays and any number of items in the item array, and I can pass as second option how many items to choose from from each item array.