Comments (5)
@br4in3x Thanks! I am glad I could contribute.
from golang-cognito-example.
@mcharytoniuk That would be great! But in order to keep the code as basic and simple as possible (because this repo is just an example to give an idea of how to make Cognito work in a small web-app), I think the generation of the secret hash should be isolated into a separate function, with extensive documentation.
Now, would you be open to creating a PR?
P.S. Awesome post, man. It will save time for many people, thanks for sharing.
from golang-cognito-example.
@br4in3x sure, I can create a PR with a separate function that creates secret hash and keeps everything documented in comments and include it in the login.go
file as an optional parameter. Does this sound ok?
from golang-cognito-example.
@mcharytoniuk I think that function can live in the same login.go
file and be called right in the body of App.Login function. In my opinion, it would make it easier to understand, since the function would be used only in one spot. Therefore, an optional parameter is also not required.
But please feel free to decide how you want to implement the change, I'm happy that you're making a contribution 😄
from golang-cognito-example.
@mcharytoniuk your PR #4 is merged. Feel free to close this issue if you have no further additions to this topic. Thanks!
from golang-cognito-example.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from golang-cognito-example.