It's not necessary to disable client hash about golang-cognito-example

[mcharytoniuk]

@br4in3x Thanks! I am glad I could contribute.

[br4in3x]

@mcharytoniuk That would be great! But in order to keep the code as basic and simple as possible (because this repo is just an example to give an idea of how to make Cognito work in a small web-app), I think the generation of the secret hash should be isolated into a separate function, with extensive documentation.

Now, would you be open to creating a PR?

P.S. Awesome post, man. It will save time for many people, thanks for sharing.

[mcharytoniuk]

@br4in3x sure, I can create a PR with a separate function that creates secret hash and keeps everything documented in comments and include it in the login.go file as an optional parameter. Does this sound ok?

[br4in3x]

@mcharytoniuk I think that function can live in the same login.go file and be called right in the body of App.Login function. In my opinion, it would make it easier to understand, since the function would be used only in one spot. Therefore, an optional parameter is also not required.

But please feel free to decide how you want to implement the change, I'm happy that you're making a contribution 😄

[br4in3x]

@mcharytoniuk your PR #4 is merged. Feel free to close this issue if you have no further additions to this topic. Thanks!