bradens / atom-pipe Goto Github PK

In Atom 0.188.0 -- this appears to be the same issue as #7 , so probably a regression triggered by a new Atom release?

If there are multiple selections (e.g., you selected many of the same thing with find-and-replace:select-next) it only seems to apply the pipe to the text of the last selection.

The fix for #2 made this work for multiple selections cursors but it creates an undo history entry for each separate selection instead of just one undo history entry.

Use activationCommands instead of activationEvents in your package.json
Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }

Package.getActivationCommands (…/Atom.app/Contents/Resources/app.asar/src/package.js:808:9)
Package.hasActivationCommands (…/Atom.app/Contents/Resources/app.asar/src/package.js:733:20)
<unknown> (…/Atom.app/Contents/Resources/app.asar/src/package.js:185:24)
Package.measure (…/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
Package.load (…/Atom.app/Contents/Resources/app.asar/src/package.js:177:12)
PackageManager.loadPackage (…/Atom.app/Contents/Resources/app.asar/src/package-manager.js:355:14)

Are you trying to listen for the 'core:cancel core:close' Atom command with jQuery::on?
jQuery::trigger can no longer be used to listen for Atom commands. Please
use atom.commands.add instead. See the docs at
https://atom.io/docs/api/latest/CommandRegistry

Commands appear to be run in the / directory (verify by running pwd).
Sometimes I would like to run commands from my current project.
It would be nice if it ran them the current atom.project.path instead.

Are you trying to listen for the 'core:cancel core:close' Atom command with jQuery::on?
jQuery::trigger can no longer be used to listen for Atom commands. Please
use atom.commands.add instead. See the docs at
https://atom.io/docs/api/latest/CommandRegistry

Store package style sheets in the styles/ directory instead of stylesheets/ in the pipe package

Package.getStylesheetsPath (…/Atom.app/Contents/Resources/app.asar/src/package.js:460:9)
Package.getStylesheetPaths (…/Atom.app/Contents/Resources/app.asar/src/package.js:471:32)
Package.loadStylesheets (…/Atom.app/Contents/Resources/app.asar/src/package.js:453:38)
<unknown> (…/Atom.app/Contents/Resources/app.asar/src/package.js:183:19)
Package.measure (…/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
Package.load (…/Atom.app/Contents/Resources/app.asar/src/package.js:177:12)

[Enter steps to reproduce below:]

1. ... Updated to the latest version and restarted Atom
2. ...

Atom Version: 0.199.0 ⚠️ in 1.0 API Preview Mode ⚠️
System: Mac OS X 10.10.3
Thrown From: pipe package, v0.3.2

Stack Trace

Failed to load the pipe package

At Cannot read property 'prototype' of undefined

TypeError: Cannot read property 'prototype' of undefined
    at __extends (/Users/david.neudorfer/.atom/packages/pipe/lib/command-view.coffee:4:199)
    at /Users/david.neudorfer/.atom/packages/pipe/lib/command-view.coffee:9:5
    at Object.<anonymous> (/Users/david.neudorfer/.atom/packages/pipe/lib/command-view.coffee:84:5)
    at Object.<anonymous> (/Users/david.neudorfer/.atom/packages/pipe/lib/command-view.coffee:86:4)
    at Module._compile (module.js:452:26)
    at Object.requireCoffeeScript (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
    at Module.load (module.js:347:32)
    at Function.Module._load (module.js:302:12)
    at Module.require (module.js:357:17)
    at require (module.js:376:17)

Commands

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "monokai"
    ],
    "followSymlinks": true,
    "disabledPackages": [
      "linter",
      "jenkins",
      "linter-flake8"
    ]
  }
}

Installed Packages

# User
Sublime-Style-Column-Selection, v1.2.3
atom-cli-diff, v0.11.0
atom-jinja2, v0.5.0
highlight-line, v0.10.2
language-ansible, v0.1.3
markdown-pdf, v1.3.5
markdown-scroll-sync, v0.3.3
monokai, v0.14.0
pipe, v0.3.2

# Dev
No dev packages

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (0.3.2) of this package:

1. Store package style sheets in the styles/ directory instead of stylesheets/ in the <pack-name> package
2. Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows: json "activationCommands": { "atom-workspace": ["foo:bar", "foo:baz"], "atom-text-editor": ["foo:quux"] }
3. Requiring View from atom is no longer supported. Please require atom-space-pen-views instead: {View} = require 'atom-space-pen-views' Add "atom-space-pen-views": "^2.0.3" to your package dependencies.
4. atom.workspaceView is no longer available. In most cases you will not need the view. See the Workspace docs for alternatives: https://atom.io/docs/api/latest/Workspace. If you do need the view, please use atom.views.getView(atom.workspace), which returns an HTMLElement.
5. Call ::getActiveTextEditor instead
6. Open-ended transactions are deprecated. Use checkpoints instead.
7. Requiring EditorView from atom is no longer supported. Please require TextEditorView from atom-space-pen-view instead: {TextEditorView} = require 'atom-space-pen-views' Add "atom-space-pen-views": "^2.0.3" to your package dependencies.

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.

If this package has been replaced by another package or functionality in core, please reply with this information.

See atom/atom#6867 for more info. Thanks!

I got this from the deprecation cop today.

Are you trying to listen for the 'core:cancel core:close' Atom command with jQuery::on?
jQuery::trigger can no longer be used to listen for Atom commands. Please
use atom.commands.add instead. See the docs at
https://atom.io/docs/api/latest/CommandRegistry

Just upgraded to Atom 0.184, and now when I open Pipe Run, the input box appears, and I can type and somehow this works because when I press enter the right thing happens, but what I type does not actually show in the input box.

Other packages suffer from this too; for instance, see gangstead/atom-incremental-search#26.

Are you trying to listen for the 'core:cancel core:close' Atom command with jQuery::on?
jQuery::trigger can no longer be used to listen for Atom commands. Please
use atom.commands.add instead. See the docs at
https://atom.io/docs/api/latest/CommandRegistry

Triggered by a select-all and pipe through yapf

If I run an external command, mostaly I would manipulate file in current project.
So, how about set project dir as cwd while running external command?

In keymaps/pipe.cson: Use the atom-text-editor tag instead of the editor class.