brave-intl / bat-native-tweetnacl Goto Github PK

The brave-core build fails with the following error. I assume stdio needs to be included but let me know otherwise.

 ../../brave/vendor/bat-native-tweetnacl/tweetnacl.cc:42:13: error: use of undeclared identifier 'stderr'
  fprintf(stderr, "Could not read %llu byes from /dev/urandom. Abort.\n", count);

Silently returning on syscall failures is a fail-dangerous not a fail-safe approach. ranodmbytes should abort the process if it can't get random data and if the caller is not set up to handle failure.

However, there's a simpler way: if we're just running this in brave-core, we can just use crypto::RandBytes.

This is not high-priority because we currently don't use randombytes, I think: we call crypot_sign_keypair(pk, sk, seeded=1) meaning that sk is prepopulated with a seed generated elsewhere. But it would be good to avoid having dangerous randombytes code around.