GithubHelp home page GithubHelp logo

brew / karl-marx-and-friedrich-engels_the-communist-manifesto Goto Github PK

View Code? Open in Web Editor NEW
0.0 2.0 0.0 2.17 MB

Epub source for the Standard Ebooks edition of The Communist Manifesto, by Karl Marx and Friedrich Engels

License: Other

CSS 2.31% HTML 97.69%

karl-marx-and-friedrich-engels_the-communist-manifesto's People

Contributors

brew avatar

Watchers

 avatar  avatar

karl-marx-and-friedrich-engels_the-communist-manifesto's Issues

content.opf issues

  • dc:identifier is wrong; should be url:https://standardebooks.org/ebooks/karl-marx-friedrich-engels/the-communist-manifesto/samuel-moore (make sure to change in colophon too)
  • <dc:description> should be a full sentence (i.e. a complete clauses) describing the work
  • long-description must be a several paragraphs of escaped HTML describing the work in detail, including relevant historical framing or background info. Think along the lines of a short Wikipedia entry. See other long-descriptions to get an idea of the kind of HTML required.
  • long-description contains non-curled quote marks; see lint output
  • se:url.vcs.github should be https://github.com/standardebooks/karl-marx_friedrich-engels_the-communist-manifesto_samuel-moore (make sure to change in colophon too)
  • Put the <dc:creator> tags next to their respective <meta refines> tags, not side-by-side
  • Missing NACOAF links for everyone; this is the LCCN link in a person's Wikipedia page

endnotes.xhtml issues

  • I see some people's initials and other initialisms that are not marked up. Florence K. Wischnewetzky should be Florence <abbr class="name">K.</abbr> Wischnewetzky for example. Also <abbr class="initialism">NY</abbr> Labor News. Are there other cases of this kind of thing in the text?
  • Der Ursprung der Familie, des Privateigenthums und des Staats is a book and so should be italicized with correct semantic inflection, not quoted. See our typography manual. Please review the rest of the text for cases like this; books are always italicized (but shorter works like essays are quoted).

chapter-3.xhtml issues

  • Good work on the subsections, however the <h3> tags must follow the same format as the <h2> tags; set them in Roman numerals with correct subtitling.
  • All <h#> tags must go in the ToC, so add these subsections to the ToC too as a new <ol> item within the Chapter 3 <li> item.

Incorrect semantics

  • <em> tags are used throughout the work, which are incorrect semantics. <em> indicates emphasized speech like shouting. The tag you want to use is <i>, along with some semantic information depending on what you're marking up. For example foreign phrases might be <i xml:lang="fr">; names of ships might be <i epub:type="se:name.vessel.ship">. Please carefully review the semantics manual before doing this: https://standardebooks.org/contribute/semantics

  • You may consider removing some of those italics entirely, like in "regime", which is now a commonly understood English word and no longer a strange French import.

introduction.xhtml issues

  • Semantic inflection is wrong, should be frontmatter not bodymatter
  • You can replace the two Roman numerals with an <ol> element. Remember that per our manual <li> elements are required to have a block-level descendant (in this case <p>).

titlepage.svg issues

  • Title, authors, and translator name must be in all caps (but not "translatated by")
  • Remove 'preface by'; we don't list those on the titlepage
  • Title is too long to fit within required padding, so split it into two lines. "The" can probably just go on its own line to make it work, but double check.
  • Ensure viewbox is appropriate size (exact size of content plus some padding). We don't have a book with two authors and a translator to use as an example, so you'll have to calculate the correct size; 50px padding is required on all sides. A vector program like Inkscape might be helpful to calculate this (but don't actually edit the SVG using Inkscape as it adds a stupid amount of SVG cruft.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.