GithubHelp home page GithubHelp logo

Comments (2)

AlfredJKwack avatar AlfredJKwack commented on June 10, 2024

@macsupport. I can confirm this does indeed behave quite oddly. Could you use another element or class to select with alongside .is-selected instead of the [data-adaptive-background]?

@briangonzalez. I think this may also point to a bug, or at least unexpected behaviour. Check this codePen. Essentially, if we set the data-ab-css-background tag, then the module completely ignores the parent property. In #L124 it basically states that if we CSS background image is used, we don't look for a parent and the current element is in fact the parent.

from jquery.adaptive-backgrounds.js.

AlfredJKwack avatar AlfredJKwack commented on June 10, 2024

@macsupport Could you pull a more recent build? I've tested it again (and updated the codePen) and now it seems to work.

Taking the following html

<div class="is-selected">
    <div class="cssBg" data-adaptive-background data-ab-css-background > 
        is-selected CSS Background
    </div>
</div>
<div>
    <div class="cssBg" data-adaptive-background data-ab-css-background >
        !is-selected CSS Background
    </div>
</div>

With this JS code

$.adaptiveBackground.run({
	selector: '.is-selected [data-adaptive-background]'
});

And CSS like:

.cssBg{
  padding: 20px;
  width: 256px;
  height: 256px;
  background: no-repeat center center url( ___something useful here ___ );
}

Should give you two images for which only one has the background color set.

from jquery.adaptive-backgrounds.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.