bridgetownrb / node-runner Goto Github PK

Hey,

I'm not much versed in JavaScript, but I think that this can be a good solution:

#{source}

try {
  const args = #{args}
  Promise.resolve(#{func}(...args)).then(result => {
    const output = JSON.stringify(['ok', result, []])
    process.stdout.write(output)
  })
} catch (err) {
  process.stdout.write(JSON.stringify(['err', '' + err, err.stack]))
}

I will write a PR with it, just would like to open the discussion.

Best regards!

Hello, I am interested if node-runner reuse the node instance between functions run?

# node is running and waiting for input?
runner = NodeRunner.new(
  <<~JAVASCRIPT
    const hello = (response) => {
      return `Hello? ${response}`
    }
  JAVASCRIPT
)

And do not bootstrap node on every function call

# These functions call do not launch node every time
runner.hello "Goodbye!"
runner.hello "Goodbye! 2"

Here https://github.com/bridgetownrb/node-runner/blob/master/lib/node_runner.js#L3

We have wrapper try-catch block.
But is there any specific reason why Promise.resolve() doesn't have catch clause?