When Tooltip is used with a child chart, and it receives new props, the child chart never updates about britecharts-react

[ronvenna]

@DalerAsrorov no problem, thanks for the quick response. Will take a look at this and submit a PR.

[ronvenna]

Bump. Any workaround for this currently?

[dalerasrorov-eb]

@ronvenna thanks for bumping, we have not yet looked in this issue (due to different project priorities). I will look into it some time. Feel free to make a PR if you find a fix as well!

[jchen-eb]

Hi @ronvenna,

One workaround I've been able to use is to wrap the entire chart in a functional component. This way, it forces React to instantiate a new object every time it gets new props.

So instead of

render() {
	const renderStackedArea = (props) => (
            <ResponsiveStackedArea
                data={stackedAreaData.with3Sources()}
                {...props}
            />
        );

	return (
            <Tooltip
                data={stackedAreaData.with3Sources()}
                render={renderStackedArea}
            />
	);
}

you can do:

render() {
	const renderStackedArea = (props) => (
            <ResponsiveStackedArea
                data={props.data}
                {...props}
            />
        );

	const TooltipWithStackedArea = ({data}) => (
		<Tooltip
		    data={data}
		    render={renderStackedArea}
		/>
	);

	return (
            <TooltipWithStackedArea
        	data={stackedAreaData.with3Sources()}
            />
	);
}

This way, every time render() gets called, it creates a new functional component which it then renders, creating a new instance of the chart with the new data and replacing the old.

In theory, this will result in worse performance. However, in my testing I haven't noticed it being any worse on the various devices I've tried.

[davegomez]

This is an issue that is affecting other charts as well, so I created a prototype comparing the Bar and Line charts where you can see the issue happening.

I can work on a solution for this and make a PR but I need some help finding the issue.

[davegomez]

This is already fixed too in the PR #164

[miglesiasEB]

Thanks!