NS_UPDATE javascript error in Firefox about britecharts-react

[Golodhros]

It is fixed. It seems our github pages didn't get updated with the last version of Britecharts React. We should look into this instead.

[Golodhros]

Hi @davegomez,

Yes! We are trying to do a new release, but we are having some issues with the deployment. Our OPS team will hopefully get to it soon and we will be good to go!

[rubenmoya]

I've been doing some research and seems to be related to the .style('display', 'none') not rendering the element and .getBBox() throwing an error in the tooltip.js file in Britecharts

There are two fixes for this that I've read so far, one of them is using .getBoundingClientRect() instead of .getBBox(), but it seems like some browsers calculate it different from others (some of them include stroke width in calculations and the others don't) so I don't know if it's the best option, the other solution is to use .style('visibility', 'hidden') instead of display: none.

Although, what I don't understand is why it's failing in britecharts-react but not in britecharts :(

[karlAlnebratt]

@Golodhros will this fix come to britechart-react? https://github.com/eventbrite/britecharts/issues/596

[Golodhros]

Probably not, we would need to do the same for the Tooltip (that fix was for the mini-tooltip). That said, it shouldn't be hard to do!

[davegomez]

Is there a way to go around this? Right now my UI is breaking in FF and this might be happening because I'm using React 16 but I wonder if there is a way to go around this while is fixed.

Can someone link the code used to build the Line chart with Tooltips in the docs (I haven't been able to find it)?

[Golodhros]

Hi @davegomez,

I think this will be fixed when we get to rework the Tooltip in Britecharts (https://github.com/eventbrite/britecharts/issues/113). It is the next thing in my list, but I cannot give an estimate.

We haven't tested in React 16, but we would love to launch v1 with react 16 support.

The tooltip code is in Britecharts: https://github.com/eventbrite/britecharts/blob/master/src/charts/tooltip.js

[davegomez]

Hello @Golodhros.

Any idea of when a new release of Britecharts React may happen including the latest fixes merged to the project?

[Golodhros]

We have a new release, but this doesn't seem to be solved :(

[Golodhros]

Well, it seems fixed in the CodePen, maybe it is an issue with the docs.