Comments (7)
What do you think it's the minimum skeleton? Just the files? or files plus content? I've realized that most of the charts are the same, just changing some props and the class names.
And although it sounds great, how many new charts are we going to add?
from britecharts-react.
I think that with the files, some of the methods and some comments to guide on creating new charts it will be enough.
There won't be a great number of new charts. I was thinking more in streamlining maintenance than in our current creation process, but this will help in both.
from britecharts-react.
I'm really familiar w/ plop, but not familiar with what would be needed in a minimum skeleton. Can you point me to some examples of a couple of charts component examples that you'd wanted auto-generated?
from britecharts-react.
We would love your support on this one @BenAtEventbrite!
A good example of the required structure would be the [bar chart folder][https://github.com/Golodhros/britecharts-react/tree/feat-packages-update/src/charts/bar]. Usually, for a chart called 'foo', we would need:
- Foo.js -> React component
- Foo.test.js -> React component test
- fooChart.fixtures.js -> Testing data
- fooChart.js -> Britecharts-based chart file
- fooChart.test.js -> chart file test
- Readme.md -> Documentation with examples
We would need to add the new chart to the index.js file, but I guess we will need to document that and add it manually.
thanks a lot for your help!!
from britecharts-react.
Sounds simple enough. Is this the index.js file you mean? https://github.com/Golodhros/britecharts-react/blob/feat-packages-update/src/charts/index.js
from britecharts-react.
Yeah, that one!
from britecharts-react.
Fixed by @speckospock in #112
from britecharts-react.
Related Issues (20)
- Cant set tooltip title to empty string HOT 2
- Bar Chart Y-axis name value getting truncated to '...' HOT 14
- StackedArea chart doesn't render correctly HOT 2
- Support TypeScript HOT 16
- Add customMouseMove and customClick to Donut chart
- Importing withResponsiveness() helper HOT 7
- Update project's documentation HOT 5
- Update Node HOT 3
- Tooltip with StackedBar not being rendered HOT 10
- Parse error when when generating chart boilerplate via plop HOT 2
- Styling ticks to fix offset and overlap HOT 7
- highlightSliceById prop of Donut component is not working
- Chart does not render with Tooltip when data is progressively added HOT 4
- Feature Proposal HOT 7
- Support Locale in Bar Chart HOT 1
- Broken and unclear documentation HOT 10
- customClick method is not working HOT 3
- Move implementation into Hooks HOT 1
- Move into TypeScript HOT 1
- How to change the font-size for the x- and y-axes? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from britecharts-react.