Feature Proposal - Banner Templates about bryxbanner

[harlanhaskins]

I guess I think this would be simpler as an extension with static functions on Banner

Like:

extension Banner {
    class func warning(text: String) {
        return Banner(title: "Warning", subtitle: text, image: UIImage(named: "Caution"), backgroundColor: UIColor.bryxYellowColor())
    }
}

[AnthonyMDev]

Hmm, that's a fair point @harlanhaskins . I hadn't even considered that. It probably would be easier. I like the idea of being able to pass around BannerTemplateType objects though. For instance, an ErrorType enum could conform to BannerTemplateType so you could show the right error message for any given error.

This also allows me to pass a BannerTemplateType into a function to display the banner at run-time, when I may not know what banner I want to use at compile time.

Chances are using an extension, I could always get the same functionality, but I feel like it would create cleaner code in many situations using a protocol, and much more flexible.

Additionally, a user can easily create extensions as you have above on their own right now if they need them, so adding the protocol does not stop you from doing so.

Thoughts?

[AnthonyMDev]

@harlanhaskins If you aren't interested in this feature, just let me know and we can close this.
Using extensions is something that users can probably just implement on their own very easily, so I don't think we need to add anything to the library in that case.

I still think that have a protocol for this would be really helpful, and I'm willing to take the time to make a PR, but I understand if this is a feature you aren't interested in including.

[harlanhaskins]

Yeah, I'm just not really convinced it's worth the extra coverage in the library. The Banner API is fairly simple on purpose.

Thanks for the proposal though!

[AnthonyMDev]

You got it. Thanks