GithubHelp home page GithubHelp logo

bryxbanner's People

Contributors

3x14 avatar adambinsz avatar adinas23 avatar adinasabadis avatar alexbartisro avatar alexpersian avatar amosavian avatar anthonymdev avatar ashishawaghad avatar ashleyng avatar askielboe avatar bennettsmith avatar billzeh avatar drewg233 avatar guarani avatar harlanhaskins avatar iankeen avatar jettf avatar koronaa avatar makoni avatar michaelneas avatar mstrodl avatar nmanoogian avatar promero-carecloud avatar relisiuol avatar vfuc avatar zntfdr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bryxbanner's Issues

cannot pod install

Resolving dependencies of Podfile
[!] Unable to satisfy the following requirements:

  • BRYXBanner required by Podfile

/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/resolver.rb:388:in handle_resolver_error' /Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/resolver.rb:69:inrescue in resolve'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/resolver.rb:56:in resolve' /Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/installer/analyzer.rb:535:inblock in resolve_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/user_interface.rb:59:in section' /Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/installer/analyzer.rb:533:inresolve_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/installer/analyzer.rb:70:in analyze' /Library/Ruby/Gems/2.0.0/gems/cocoapods-0.38.2/lib/cocoapods/installer.rb:210:inanalyze'

Release CocoaPods version for Swift 2.0

Since the Xcode 7 GM seed was released, and we can now upload applications for iOS9, can we get an official release of this pod for Swift 2.0 please?

Thank you!

Github Release Tags

Hi, thanks for this handy lib ๐Ÿ’ฏ

would you mind to add Github release tags to new versions? Carthage users like me would like to pin the version in their Cartfile ๐Ÿ‘

banner.adjustsStatusBarStyle = true but needs to invoke as soon as it's dismissed

I have a dark / default status -

I show a banner that's blue - with white background.

eg.
banner.show(duration: 15.0)
banner.preferredStatusBarStyle = .LightContent
banner.adjustsStatusBarStyle = true

I hit dismiss.

It continues to show white.

After 15 seconds - it turn back to dark /default.

It maybe simpler to avoid tracking this - and let developer prescribe it.

eg.

originalStatusBarStyle =
preferredBarStyle =

then have developer hard code it.

Setting Banner Height

Is there a way to adjust the height of the banner so it doesn't go beyond the Nav Bar ?

User dismiss

Is it possible to have a close button at the right end, so that the user can dismiss the notification?

Make it user-interactive.

i.e. Put it in a scroll view so users can pull it down and interact with it like a system notification.

Swift 2.3 release

I see there's no working Swift 2.3 release as the iOS 10 animation fixes were bundled with the Swift 3 syntax changes. Is there any chance of doing a release for those of us who are sticking to Swift 2.3 for the time being?

Cannot load the underlying module

I installed this using CocoaPods and when i try to
import BRYXBanner

I get an error saying it cannot load the underlying module.

Any ideas?

Banner does not display on iPhone 6 Plus

On the Xcode 7 simulator for iPhone 6 Plus and 6s Plus running iOS9, the banner does not show.

I get the following layout constraint errors:

2015-09-17 16:00:24.163 ZortsDevelopment[84997:2098232] Unable to simultaneously satisfy constraints.
    Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints) 
(
    "<NSAutoresizingMaskLayoutConstraint:0x7fe5f2d88aa0 h=--- v=--- H:[UIWindow:0x7fe5f4a01010(0)]>",
    "<NSLayoutConstraint:0x7fe5f2d89020 H:[UIImageView:0x7fe5f2d89e40(25)]>",
    "<NSLayoutConstraint:0x7fe5f2d8b150 H:|-(15)-[UIImageView:0x7fe5f2d89e40]   (Names: '|':UIView:0x7fe5f2d80be0 )>",
    "<NSLayoutConstraint:0x7fe5f2d8b6f0 H:[UIImageView:0x7fe5f2d89e40]-(15)-[UIView:0x7fe5f2d89820]>",
    "<NSLayoutConstraint:0x7fe5f2d8b780 H:[UIView:0x7fe5f2d89820]-(8)-|   (Names: '|':UIView:0x7fe5f2d80be0 )>",
    "<NSLayoutConstraint:0x7fe5f2d8bc10 H:|-(15)-[UILabel:0x7fe5f2d7f6b0'Invalid Username']   (Names: '|':UIView:0x7fe5f2d89820 )>",
    "<NSLayoutConstraint:0x7fe5f2d8bc60 H:[UILabel:0x7fe5f2d7f6b0'Invalid Username']-(8)-|   (Names: '|':UIView:0x7fe5f2d89820 )>",
    "<NSLayoutConstraint:0x7fe5f2d8aec0 H:|-(0)-[UIView:0x7fe5f2d80be0]   (Names: '|':UIView:0x7fe5f2d87350 )>",
    "<NSLayoutConstraint:0x7fe5f2d8af10 H:[UIView:0x7fe5f2d80be0]-(0)-|   (Names: '|':UIView:0x7fe5f2d87350 )>",
    "<NSLayoutConstraint:0x7fe5f2d8a7a0 H:|-(0)-[UIView:0x7fe5f2d87350]   (Names: '|':BRYXBanner.Banner:0x7fe5f2d80240 )>",
    "<NSLayoutConstraint:0x7fe5f2d8a7f0 H:[UIView:0x7fe5f2d87350]-(0)-|   (Names: '|':BRYXBanner.Banner:0x7fe5f2d80240 )>",
    "<NSLayoutConstraint:0x7fe5f2d8fa40 H:|-(0)-[BRYXBanner.Banner:0x7fe5f2d80240]   (Names: '|':UIWindow:0x7fe5f4a01010 )>",
    "<NSLayoutConstraint:0x7fe5f2d8fab0 H:[BRYXBanner.Banner:0x7fe5f2d80240]-(0)-|   (Names: '|':UIWindow:0x7fe5f4a01010 )>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x7fe5f2d89020 H:[UIImageView:0x7fe5f2d89e40(25)]>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
2015-09-17 16:00:24.163 ZortsDevelopment[84997:2098232] Unable to simultaneously satisfy constraints.
    Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints) 
(
    "<NSAutoresizingMaskLayoutConstraint:0x7fe5f2d88aa0 h=--- v=--- H:[UIWindow:0x7fe5f4a01010(0)]>",
    "<NSLayoutConstraint:0x7fe5f2d8b150 H:|-(15)-[UIImageView:0x7fe5f2d89e40]   (Names: '|':UIView:0x7fe5f2d80be0 )>",
    "<NSLayoutConstraint:0x7fe5f2d8b6f0 H:[UIImageView:0x7fe5f2d89e40]-(15)-[UIView:0x7fe5f2d89820]>",
    "<NSLayoutConstraint:0x7fe5f2d8b780 H:[UIView:0x7fe5f2d89820]-(8)-|   (Names: '|':UIView:0x7fe5f2d80be0 )>",
    "<NSLayoutConstraint:0x7fe5f2d8bc10 H:|-(15)-[UILabel:0x7fe5f2d7f6b0'Invalid Username']   (Names: '|':UIView:0x7fe5f2d89820 )>",
    "<NSLayoutConstraint:0x7fe5f2d8bc60 H:[UILabel:0x7fe5f2d7f6b0'Invalid Username']-(8)-|   (Names: '|':UIView:0x7fe5f2d89820 )>",
    "<NSLayoutConstraint:0x7fe5f2d8aec0 H:|-(0)-[UIView:0x7fe5f2d80be0]   (Names: '|':UIView:0x7fe5f2d87350 )>",
    "<NSLayoutConstraint:0x7fe5f2d8af10 H:[UIView:0x7fe5f2d80be0]-(0)-|   (Names: '|':UIView:0x7fe5f2d87350 )>",
    "<NSLayoutConstraint:0x7fe5f2d8a7a0 H:|-(0)-[UIView:0x7fe5f2d87350]   (Names: '|':BRYXBanner.Banner:0x7fe5f2d80240 )>",
    "<NSLayoutConstraint:0x7fe5f2d8a7f0 H:[UIView:0x7fe5f2d87350]-(0)-|   (Names: '|':BRYXBanner.Banner:0x7fe5f2d80240 )>",
    "<NSLayoutConstraint:0x7fe5f2d8fa40 H:|-(0)-[BRYXBanner.Banner:0x7fe5f2d80240]   (Names: '|':UIWindow:0x7fe5f4a01010 )>",
    "<NSLayoutConstraint:0x7fe5f2d8fab0 H:[BRYXBanner.Banner:0x7fe5f2d80240]-(0)-|   (Names: '|':UIWindow:0x7fe5f4a01010 )>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x7fe5f2d8b6f0 H:[UIImageView:0x7fe5f2d89e40]-(15)-[UIView:0x7fe5f2d89820]>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.

I'm attempting to solve this right now, but wanted to make an issue in case @harlanhaskins can figure it out first.

Carthage install, received warning

After doing a Carthage install, I received this warning:
warning: use of string literal for Objective-C selectors is deprecated; use '#selector' instead

Would you be able to update for this?

BRYXBanner 0.7.0 carthage support

Today I tried to update my carthage BRYXBanner dependency to version 0.7.0 because I would like to use this great package with Swift 3.
But after the command carthage update BRYXBanner --platform iOS I got the following error:

Skipped building BRYXBanner due to the error: Dependency "BRYXBanner" has no shared framework schemes for any of the platforms: iOS

Hope someone can help me!

*** Skipped building BRYXBanner due to the error:

*** Fetching BRYXBanner
*** Checking out BRYXBanner at "0.7.0"
*** xcodebuild output can be found in /var/folders/nc/jrryg2gs72vg47hjnbsyhn700000gn/T/carthage-xcodebuild.HJxQDz.log
*** Skipped building BRYXBanner due to the error:
Dependency "BRYXBanner" has no shared framework scheme

ran in to this error whicle upating the latest for iOS 10?

Image is not shown.

Nice code.
I saw the other issues and your reference to issue #45, but it doesn't help. UIImage is not shown, even when set with UIImage(named: "imageName") for the public required init parameters. Tried to re-render your code to UIImageView, but that doesn't work either.

Own views

It would be great if own views would be supported so that it can be used as a settings popup.

Banner not dismissing

Hi , I am using BRYXBanner to notify internet connectivity. Banner is presented as expected but it is not dismissing when i dismiss it manually.

`
func reachabilityChanged(note: NSNotification) {

    let banner = Banner(title: "User Offline !!!", subtitle: "Device seems to have lost its internet connection.", image: nil, backgroundColor: UIColor.yellowColor())
    banner.position = .Bottom
    banner.dismissesOnTap = false

    let reachability = note.object as! Reachability

    if reachability.isReachable() {
       banner.dismiss()
    } else {

        banner.show()
    }
}

`

Calling show from obj-c, Swift-2.0 branch

The method is not available. It is not shown in the generated BRYXBanner-Swift.h
I am temporarily working around this by using the following class

import UIKit
import BRYXBanner

class MPTBanner: Banner {
    override func show(duration duration: NSTimeInterval?) {
        super.show(duration: duration)
    }

    func show() {
        super.show(duration: 3.0)
    }
}

Add option for removing transparency

Hey guys,

first of all thanks for this nice component! Would be nice if you could add a public property which reflects the transparency of the view, because at the moment it seems to have an alpha = 0.9 or similar which kind of looks weird depending on the underlying content.

Thank you! :)

Cheers,
Chris

Align labels Right to Left

Hi
I need to put labels on right side of the contentView for instance with trailing = 8 to contentView
but I couldn't do that with manipulating the visual constraints for contentView In Banner Class
I need some help with that, and it would be nice for the next version of BRYXBanner to support right to left alignment of elements to support right to left languages like Persian
thanks

Change Status Bar Color?

Detect how dark the BG color is, and change the status bar from black to white, or vice versa, automatically when showing and hiding?

That, or offer a way to display the alert over the status bar?

Display based on nav bar?

I'm always on the lookout for a good banner framework, but one thing I always seem to need is the ability to display banners, not at the top of the screen, but underneath the nav bar. This would be something like Facebook's internet connection banner. Not really that common but it does make the banners a bit less invasive when the user can still interact with the nav bar while they're being displayed. Any interest in this feature or intention to build it?

Swift 3

I am having issues using the Banner with CocoaPods, XCode8 and Swift3

Error on uploading to app store, no executable

I am using BRYX banner for a project and on uploading I get the message that project.app/Frameworks/BRYXBanner.framework does not contain a bundle executable

I am including BRYXBanner via cocoapods, and for development it has been fine,

Wrong width

Hi guys,
when I show the banner on a tableView it appears smaller than the tableView.
In the image the tableView is the yellow one and the banner obviously is the red one.
simulator screen shot 26 set 2015 16 29 12

MinimumOSVersion is invalid

Getting an error during submission to app store that states that the MinimumOSVersion needs to have a minimum value of 8.0.

BRYXBanner.bundle: No such file or directory

Setup: CocoaPods 1.0.0.beta.6 | Xcode 7.3

Seems that BRYXBanner.bundle lives in a subdirectory of BRYXBanner, whereas xcode expects to find it in the root of BRYXBanner.

This results in the following error when trying to build BRYXBanner:

error: /Users/askielboe/Library/Developer/Xcode/DerivedData/xxx/Build/Products/Debug-iphonesimulator/BRYXBanner/BRYXBanner.bundle: No such file or directory

screen shot 2016-04-01 at 09 41 02

Xcode looks for it here:

screen shot 2016-04-01 at 09 41 42

Moving the file manually in Finder (as above) seems to fix the issue..

Possibly related to #34

Make title and subtitle optional

First off, great library! Thank you!
I think it would be nice for the title and subtitle to be a optional parameters, and if either is nil, the other label should fill the entire banner.

No show/hide animation on iOS10

Hi guys, I'm using your swift3 branch:
As far as I can tell, with BRYXBanner on iOS 10 there's no animation between the status changes in both simulator and/or real device.
The banner just pops up out of nowhere and disappears all of a sudden.

It almost seems like the forceUpdates() constraints changes are ignored.

Is it just me? is it a iOS beta bug? is addConstraint(_:) deprecated? (I tried using NSLayoutConstraint.activate(_:) instead but the result was the same).

Thanks in advance ๐Ÿ˜Š

PS
Everything works perfectly with this branch on iOS9

PPS
I've experienced the issues above in the latests two ios10/Xcode betas (4 and 5).

Feature Proposal - Banner Templates

It would be nice to have some pre-made template banners that have a preset color and image for some common uses.

For example:

  • Error - red with an error icon
  • Warning - yellow with an error icon
  • Success - green with a checkmark icon

I'd like to create a BannerTemplateType protocol and add a convenience initializer that takes a BannerTemplateType as a parameter.

Then, I would create a few structs that conform to BannerTemplateType for the pre-made templates. This allows users to easily create their own banner templates, or even make their custom error types conform to BannerTemplateType to be easily displayed.

@harlanhaskins I'd be willing to make a PR for this if you are interested. I wanted to get your thoughts on this before I started implementation.

Carthage Framework not Built

Hi,

When I add BRYXBAnner to my cart file github "bryx-inc/BRYXBanner"it gets checked out but a framework isn't built, my guess is that the Scheme for the Framework isn't shared as I can't see it in the version that is checked out by Carthage?

Test Helpers Subspec.

@harlanhaskins - When you bumped the podspec to 0.6.1 you removed the 'Test Helpers' subspec. Was the subspec causing a problem? The Test Helpers file still exists in the project, but can't be accessed. Was that supposed to be deleted as well? Ideally, I would love it if the subspec could be put back in. The Mocks in there were helpful for testing.

Thanks for your time, JF

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.