btarg / elytraeject

A simple Fabric mod that lets the player disable their Elytra mid-flight

btarg

My favourite programming language is C#, and I mostly focus on game development and modding. I code in my spare time to learn as much as I can, and to create the best solutions to problems I have with existing software and games.

I also own and operate the 21st portfolio, a student-run literature blog, and I occasionally write poetry and reviews for the site.

My Skills

Contact me on LinkedIn if you are interested in hiring a developer with any of these skills!

elytraeject's Issues

Critical bug

I had a quick look at the code and I'm pretty sure there's a critial bug here:

https://github.com/iCrazyBlaze/ElytraEject/blob/63b3f55c1dc435b88a127787f6c7d9b0f629506f/src/main/java/io/github/icrazyblaze/eject/mixin/ServerPlayerMixin.java#L25-L27

Since the mixin injects at HEAD, this cancels the whole ServerPlayer.tick() method e.g. when you're not wearing an Elytra or not pressing shift, which is pretty much always.

While testing I noticed that items /given aren't synced properly with the client and Potions of Harming deal no damage to the player. Who knows what else this breaks.

Since I don't see any reason to cancel ServerPlayer.tick() at all, the fix should be to simply delete that part of code (and also the cancellable).

I'd also advise you to rename your mixin method name to something more meaningful like cancelFlight, ejectElytra or something, because the method name can appear e.g. in stack traces and injected doesn't tell which mod it is from or what the method actually does.