budlabs / youtube Goto Github PK

Hi Bud!

I been enjoying your videos a lot, thanks for making and sharing them. 😄

One of your ideas I really liked was changing your home directory names to short 3-4 letter Unix style. I even went so far today as to start sketching out an outline of what that would look like for myself, when tweaked to my own needs / liking. But then I stopped because I had a thought / question.

Are you still doing it this way?

Because the thought occurred to me that this might get to eventually become a maintenance hassle? I have some time now, and am working on my setup, but some day that might not always be the case. Or maybe not. I dunno. I guess I need to think about it some more, before committing. Because that will be a pretty major (and potentially slightly breaking) change for a while.

I looked all over the Internet trying to find an email or something for you, without success. So I hope you don't mind me contacting you through here. :)

Cheers! 🍻

TRS-80

How did you set the keybinds on the dropdown for arrange items?

I recently followed this; https://www.youtube.com/watch?v=9jiv9myBGiY.
But now view changes no longer work.
If I were to set it to I or L in the dir rules, it will work fine when I first start thunar, but not whenever I switch into a folder that uses a different view..
I think, it could have something to do with the fact i'm using a different keyboard layout than you? I'm not entirely sure.
Updatefm also DOES say which folder should be changing fine, but it just doesn't seem to at all.. Quite frustrating..

Hi, bud.

Recently, I have been thinking of remaking my prompt from scratch to add some features I would like to have.
I have been running a patched version of your prompt for a while (more than 2 years, lol).
I thought I'd share my patches before I stop using it since there are a few issues with the vanilla version.

I'll describe the main patches I have added:

patch1:

This is the first thing I changed (less than a day after I started using it).
The DEBUG trap is messing with $_ which I find extremely annoying, the fix is to add a "$_" at the end of the command in the trap.

# trap ': "${_t_prompt:=$(prompt_timestamp)}"' DEBUG
trap ': "${_t_prompt:=$(prompt_timestamp)}" "$_"' DEBUG

patch2:

var=$(printf) creates a subshell for no reason, bash's printf -v is more clean.

# ms="$(printf '%03d' $ms)"
printf -v ms '%03d' "$ms"

patch3:

This is the biggest one, I basically redid the whole ps generation code.

case $PWD in
    "$_last_prompt_path") ps=$_last_prompt_string ;;
    "$HOME")              ps='~'                  ;;
    /)                    ps=/                    ;;
    *)
        < <(printf '%s/\0' "${PWD/#"$HOME/"/'~/'}") \
            IFS=/ read -rd '' -a path_dirs
        for d in "${path_dirs[@]}"; do
            if [[ $d =~ [[:alnum:]] || $d =~ [[:print:]] || -z $d ]]
                then             : "${BASH_REMATCH[0]}"
                else d=${d:0:1}; : "${d@Q}"
            fi
            ps+=$_/
        done
        ps=${ps%/} ps=${ps//\\/\\\\} ps=${ps//\`/\\\`}
        ;;
esac

if [[ $_last_promptdir = "$PWD" ]]; then
  ps="$_last_pathstring"
else
  # set IFS to forward slash to conveniently
  # loop path, make it local so we don't replace
  # the shells main IFS
  local IFS='/'

  # replace homde dir with literal ~ in PWD loop
  # the path and use the first alpha/numeric
  # character OR the first character of each
  # directory.
  for d in ${PWD/~/'~'}; do
    [[ $d =~ [[:alnum:]] ]]         \
      && ps+="${BASH_REMATCH[0]}/"  \
      || ps+="${d:0:1}/"
  done

  # remove trailing / if we are not in root dir
  [[ ${ps} = / ]] || {
    ps="${ps%/}"

    # expand the last directory
    # [[ $ps != '~' ]] && ps="${ps%/*}/$d"
  }

  unset d

  # these variables are global
  _last_promptdir="$PWD"
  _last_pathstring="$ps"
fi

First of all, the unset d will unset the d variable every time you change directory which can be very annoying and sneaky. having d as a local variable is much better.

I have replaced the if with a case and added a shortcut for $HOME and /.

Iterating over unquoted ${shortpwd@P} is a bad idea. If that string contains *, ? or other special characters pathname expansion will occur and potentially mess with our plans. (and the prompt may stop working if you have shopt -s nullglob.)
You could solve this using set -f (to disable pathname expansion) before the for loop and then using set +f after to re-enable it, but you could be playing with bash in your shell and intentionally enable -f and whenever you change directory this will re-disable it which is, once again, annoying.
Localising set options in bash is do-able, but messy and using this set -f feels dirty.

A much cleaner solution is to just read an array like so:

IFS=/ read -rd '' -a path_dirs < <(printf '%s/\0' "${PWD/#"$HOME/"/'~/'}")

Now I can simply use "${PWD/#"$HOME/"/'~/'}" to replace "$HOME/" at the beginning of $PWD with ~/ which is much simplier than ${@P} since we don't have to deal with "$PWD" == "$HOME".

The reason I use -d '' and \0 is to make bash choose the correct characters even if the directory contains newline characters. (another issue of the prompt was that it was completely broken or multiline in some very edge case directory.)

I use %s/\0 instead of just %s\0 for correctness (see here: read -ra ignores one IFS from the end of the input if the input ends in one or more IFS) even if it should not be necessary in this case.

Now I can safely iterate over the array without having to deal with word splitting, pathname expansion, set -f and other shell shenanigans.

patch3.5:

In the loop, I have replaced the old:

#if [[ $d =~ [[:alnum:]] ]]
#    then ps+=${BASH_REMATCH[0]}/
#    else ps+=${d:0:1}/
#fi

With:

if [[ $d =~ [[:alnum:]] || $d =~ [[:print:]] || -z $d ]]
    then             : "${BASH_REMATCH[0]}"
    else d=${d:0:1}; : "${d@Q}"
fi
ps+=$_/

I use $_ just to reduce code duplication, it is not too important.

If the directory name is /etc/$'\t?'/a I would rather have /e/?/a than /e/$'\t'/a, but I would still like to have /e/b/a for /etc/?b/a, so I've added =~ [[:print:]] after an || to match printable characters if there are no alphanumeric characters.

In the else branch now only appear the characters that are not printable so I use ${@Q} to make them visible:

# if PWD is:
pwd='/usr/
/hi'
# then ps will be: /u/$'\n'/h
# which I think is nicer than:
ps='/u/
/h'
# this also makes the prompt usable in the extremely corner case
# situation in which the dirname only has non-printable character that
# are not TAB or LF.

I added -z $d such that /etc/profile.d/ is converted to /e/p and not ''/e/p because of ${@Q}. Also, this covers the (impossible on ext4 and any other filesystem I know of, but whatever) case in which a directory name is the empty string and makes /usr/local/share//dir, /u/l/s//d instead of /u/l/s/''/d.
NOTE: when -z $d is true, BASH_REMATCH[0] is set to nothing by the previous =~ [[:print:]].

patch4:

This is quite important. `cmd`, $(cmd), and \w (or backslash anything) are expanded by PS1 which can cause syntax errors.

ps=${ps@Q} can't save us since that will also quote ?, ~, *, and other character that we don't want to have quoted.

To avoid this problem, I have added, after the loop, this:

ps=${ps%/} ps=${ps//\\/\\\\} ps=${ps//\`/\\\`}

We were already doing ps=${ps%/} if $PWD != /; in this branch, $PWD is always going to be != / so we don't have to check.

The other parameter expansions add a backslash before every \, and `.

You could also add one for $, but, unless I'm missing something, it should not be necessary since, even if there is a $, it can only be in the forms of $/, $  or $' which do not expand in PS1.

I think this is pretty much all.

Cheers.

#!/bin/bash
#  _               _                                       _
# | |__   __ _ ___| |__    _ __  _ __ ___  _ __ ___  _ __ | |_
# | '_ \ / _` / __| '_ \  | '_ \| '__/ _ \| '_ ` _ \| '_ \| __|
# | |_) | (_| \__ \ | | | | |_) | | | (_) | | | | | | |_) | |_
# |_.__/ \__,_|___/_| |_| | .__/|_|  \___/|_| |_| |_| .__/ \__|
#                         |_|                       |_|

: "${C_DEFAULT:=$(tput sgr0)}"
: "${C_RED:=$(tput setaf 1)}"
: "${C_GREEN:=$(tput setaf 2)}"
: "${C_YELLOW:=$(tput setaf 3)}"
: "${C_BLUE:=$(tput setaf 4)}"
: "${C_MAGENTA:=$(tput setaf 5)}"
: "${C_CYAN:=$(tput setaf 6)}"

updateprompt()
{
    # ps: pathstring
    # ts: timestring
    # tc: timecolour
    local IFS d ps ts tc path_dirs

    (( ts = ($(date +%s%N) - _prompt_timer) / 1000000 ))

    case "$(( ts <= 20  ? 1 :
              ts <= 100 ? 2 :
              ts <= 250 ? 3 :
              ts <= 500 ? 4 :
              ts <= 999 ? 5 : 6 ))" in
        (1) tc=$C_GREEN                   ;;
        (2) tc=$C_YELLOW                  ;;
        (3) tc=$C_CYAN                    ;;
        (4) tc=$C_BLUE                    ;;
        (5) tc=$C_MAGENTA                 ;;
        (*) tc=$C_RED
            (( ts = (ts / 1000) % 1000 )) ;;
    esac

    printf -v ts %03d "$ts"

    case $PWD in
        "$_last_prompt_path") ps=$_last_prompt_string ;;
        "$HOME")              ps='~'                  ;;
        /)                    ps=/                    ;;
        *)
            < <(printf '%s/\0' "${PWD/#"$HOME/"/'~/'}") \
                IFS=/ read -rd '' -a path_dirs
            for d in "${path_dirs[@]}"; do
                if [[ $d =~ [[:alnum:]] || $d =~ [[:print:]] || -z $d ]]
                    then             : "${BASH_REMATCH[0]}"
                    else d=${d:0:1}; : "${d@Q}"
                fi
                ps+=$_/
            done
            ps=${ps%/} ps=${ps//\\/\\\\} ps=${ps//\`/\\\`}
            ;;
    esac

    PS1="\[${tc}\]$ts\[${C_DEFAULT}\] $ps \[${C_RED}\]>\[${C_DEFAULT}\] " \
    _last_prompt_path=$PWD \
    _last_prompt_string=$ps

    unset _prompt_timer
}

trap ': "${_prompt_timer:=$(date +%s%N)}" "$_"' DEBUG

PROMPT_COMMAND=updateprompt

When following from the video and changing my updatefm script, I now get this..

~ $ thunarIPCstart.sh 
window notify method
window is thunar
the current instance name is 
apply new layout
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  20 (X_GetProperty)
  Resource id in failed request:  0x0
  Serial number of failed request:  49
  Current serial number in output stream:  49
updated to list view
window notify method
window is thunar
the current instance name is 
apply new layout
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  20 (X_GetProperty)
  Resource id in failed request:  0x0
  Serial number of failed request:  49
  Current serial number in output stream:  49

Is it possible convert this function to a script that accepts a string as an argument for the message? Then it can be called by other scripts.

Would prefer that approach over having to source the function in every script.

Followed this to the T, but for some odd reason I still don't get icon view on the launch of thunar, but for ThunarB I get list view fine.

I know this is a uberedge case, but better safe than sorry.
${PWD/~/'~'} will turn /test$HOME/test into /test~/test which will result in this prompt /t/t.
I fixed it this way:

[[ $PWD =~ ^$HOME ]] && temppath="${PWD/~/'~'}"
IFS='/'
for d in ${temppath:-$PWD}; do

I also tried just using ${PWD/^~/'~'}, ${PWD/^$HOME/~} and even ${PWD/^${HOME//'/'/'\/'}/~} instead of ${PWD/~/'~'}, but they don't seem to work.

I'm submitting this as an issue and not a pull request so that you can add documentation as you please.

Cheers, emanuele6