buschtoens / ember-lazy-mount Goto Github PK

Been working with this addon for a few days to get a lazy routeless engine set up in our app. I've noticed a number of times now there was a critical error that threw inside this addon's mounting process, but was captured and not logged to the console. However, our test suite uses the preloadAssets helper from ember-asset-loader and errors appeared as expected.

I'm not seeing anything in the code for this that would munch the error, so I'd guess this has something more to do with either the interface between this app and ember-asset-loader, or ember-asset-loader itself.

Noticed that an-engine is appear in both development and production builds. I suspect ember-cli is picking it up from the package.json?

Hey there,
Just reporting a problem with lazy-mount on a freshly updated Ember 3.6 application. Using the standard ember-engines {{mount}} on a non-lazy loaded engine, I get no errors. Using {{lazy-mount}}, though, I get this:

[Error] TypeError: An element descriptor's .kind property must be either "method" or "field", but a decorator created an element descriptor with .kind "undefined"
	_toElementDescriptor (vendor.js:211257:315)
	_toElementFinisherExtras (vendor.js:211259:89)
	_decorateElement (vendor.js:211249:364)
	(funzione anonima) (vendor.js:211245:383)
	forEach
	_decorateClass (vendor.js:211245:252)
	_decorate (vendor.js:211227:197)
	(funzione anonima) (vendor.js:211285)
	exports (vendor.js:111)
	_reify (vendor.js:148)
	reify (vendor.js:135)
	exports (vendor.js:109)
	requireModule (vendor.js:32)
	_extractDefaultExport (vendor.js:221754)
	resolveOther (vendor.js:221433)
	resolve (vendor.js:221495)
	resolve (vendor.js:32926)
	resolve (vendor.js:32556)
	resolve (vendor.js:32558)
	factoryFor (vendor.js:32213)
	lookupComponentPair (vendor.js:58709)
	_lookupComponentDefinition (vendor.js:40054)
	lookupComponentHandle (vendor.js:39920)
	refineBlockSyntax (vendor.js:39781)
	compile (vendor.js:66820)
	compileBlock (vendor.js:67260)
	compileBlock (vendor.js:67624)
	(funzione anonima) (vendor.js:66691)
	compile (vendor.js:66569)
	compile (vendor.js:67127)
	compile (vendor.js:67100)
	getLayout (vendor.js:36588)
	(funzione anonima) (vendor.js:70522)
	evaluate (vendor.js:69516)
	evaluateSyscall (vendor.js:71656)
	evaluateInner (vendor.js:71630)
	evaluateOuter (vendor.js:71623)
	next (vendor.js:73120)
	execute (vendor.js:73110)
	handleException (vendor.js:72275)
	handleException (vendor.js:72398)
	throw (vendor.js:72222)
	evaluate (vendor.js:70031)
	execute (vendor.js:72209)
	rerender (vendor.js:72413)
	runInTransaction (vendor.js:41509)
	runInTransaction
	_renderRoots (vendor.js:37592:91)
	_renderRootsTransaction (vendor.js:37623)
	_revalidate (vendor.js:37659)
	invoke (vendor.js:74152)
	flush (vendor.js:74073)
	flush (vendor.js:74225)
	_end (vendor.js:74655)
	end (vendor.js:74458)
	_run (vendor.js:74698)
	(funzione anonima) (vendor.js:163674)
	fire (vendor.js:24559)
	fireWith (vendor.js:24689)
	done (vendor.js:30596)
	(funzione anonima) (vendor.js:30839)

Anyone else experiencing this?

Thanks.

Hi,

I have tried to create a project by using the latest ember-cli (3.5.0), ember-engines (0.5.24) and the 0.1.0 version of this addon. It will throw this error message, and do you know how can I fix this?

Thanks

Thank you @buschtoens for implementing and supporting this over years!

Looks like repo need a bit of maintenance as test app needs to be updated by synchronizing with latest addon blueprint.

Additionally, this addon is great candidate for conversion to v2 format.
Although asset-loader used by this addon is not supported by Embroider and completely swapped, ppl using Ember CLI build pipeline still can benefit from smaller addon footprint.

@buschtoens would you like to add me as maintainer as I can help with those maintenance needs now and in future to keep this usable?

{{lazy-mount
  this.engineName
  model=this.optionalDataForTheEngine
  onLoad=this.onLoad
  didLoad=this.didLoad
  onError=this.onError
}}

• onLoad: () => void — Called, when the engine started loading
• didLoad: () => void — Called, when the engine was successfully loaded
• onError: (error: Error) => void — Called, when the engine failed to load

Obviously could use "model=" but my existing app is kind of too coupled as of yet I think... but would like to employ this but still be able to inject the state of the host app somehow...?