GithubHelp home page GithubHelp logo

Comments (6)

bvaughn avatar bvaughn commented on May 21, 2024 1

Whoops! I probably just forked another OSS project I had to create this one and wasn't careful about cleaning up dependencies. That or I forgot the --dev flag when yarn adding some.

Either way, sorry. I'll tidy up before the next release.

from react-error-boundary.

bvaughn avatar bvaughn commented on May 21, 2024 1

Should be fixed in 1.1.0!

from react-error-boundary.

guilhermebruzzi avatar guilhermebruzzi commented on May 21, 2024

But I just realized that to remove these as a dependency, than you should generate a compiled version (without Flow), right?

from react-error-boundary.

guilhermebruzzi avatar guilhermebruzzi commented on May 21, 2024

@bvaughn Nice! :D I've copied the component code without Flow (using prop-types instead) to my project, so no extra dependencies were needed, the main part is small actually:

import React, { Component } from 'react'
import PropTypes from 'prop-types'

class ErrorBoundary extends Component {
  constructor(props, context) {
    super(props, context)

    this.state = {
      error: null,
      info: null,
    }
  }

  componentDidCatch(error, info) {
    const { onError } = this.props

    if (typeof onError === 'function') {
      try {
        onError(error, info ? info.componentStack : '')
      } catch (error) {}
    }

    this.setState({ error, info })
  }

  render() {
    const { children, FallbackComponent } = this.props
    const { error, info } = this.state

    if (error !== null) {
      return (
        <FallbackComponent
          componentStack={info ? info.componentStack : ''}
          error={error}
        />
      )
    }

    return children
  }
}

ErrorBoundary.propTypes = {
  children: PropTypes.any,
  FallbackComponent: PropTypes.any.isRequired,
  onError: PropTypes.func,
}

export default ErrorBoundary

from react-error-boundary.

bvaughn avatar bvaughn commented on May 21, 2024

Will prob do a follow-up release to generate prop-types from the Flow types for people who prefer to use them. Although I guess there's not much motivation if you just embed the tiny component 😄

from react-error-boundary.

guilhermebruzzi avatar guilhermebruzzi commented on May 21, 2024

@bvaughn oh but you should definitely do it anyway, not all people use Flow. Thanks for the great work, this React 16 componentDidCatch feature that this component helps to use is very Nice! :D

from react-error-boundary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.