GithubHelp home page GithubHelp logo

Comments (5)

jaulz avatar jaulz commented on May 31, 2024 1

Thanks for fixing it so fast! 😊

from semantic-release-expo.

byCedric avatar byCedric commented on May 31, 2024

Thanks for reporting! I think you are right, might be something related to either version bumpers or the template mechanism. I'll take a look tonight and keep this thread updated!

from semantic-release-expo.

byCedric avatar byCedric commented on May 31, 2024

I think it's related to this line, sorry for the inconvenience! I'll make a fix when I'm finished at work.

from semantic-release-expo.

byCedric avatar byCedric commented on May 31, 2024

Ok, so it was not related to the line I pointed earlier. This issue is caused by lodash's template function, always returning a string. It also wasn't detected by the tests because I mocked the return value to a numeric value.

The two lines I edited in the pull requests are forcing the android version code to an integer, as the spec describes.

A positive integer used as an internal version number.

It also mocks the return value of calculateAndroidVersion as string, and checks if a number is written tot he manifest. I'll release this now! Again, @jaulz thanks for reporting!

from semantic-release-expo.

byCedric avatar byCedric commented on May 31, 2024

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

from semantic-release-expo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.