Comments (5)
What's the gain? The entire structure is internal
from caddy.
I think the gain is minimal; I have no opinion either way. If a PR is created I'd probably be fine with it, but I'm OK with it as-is too.
from caddy.
@mohammed90 you are absolutely right , didn't think too much about it
from caddy.
Without looking I don't remember the purpose of the bool
-- if it's just for syntactic sugar, then sure, a struct{}
could be used. This prevents an allocation.
Not sure if it matters here. Maybe on huuuuge Caddyfiles.
from caddy.
@mholt Yes it is a syntactic sugar, using the bool the author is trying to create a quasi set, struct{} would be better, just like you rightly said it prevents an unnecessary allocation. if you want me to make a change please comment, I would be happy to open a pull request.
from caddy.
Related Issues (20)
- automatic http->https redirect not enabled on multiple bind addresses HOT 2
- Remove support for lego-deprecated
- IP is set but cannot be accessed HOT 1
- Duplicate strings.Count in path matcher HOT 1
- New Release Needed HOT 3
- IP passthrough issue HOT 3
- fileserver: grid view - preview img src attribute is not URL query-escaped HOT 3
- Caddy ignoring system proxy when doing ACME requests HOT 2
- Download crawl or stall HOT 2
- Caddy does not report version # HOT 3
- Caddy missing patches HOT 1
- What happens when multiple root directives with intersecting matchers are specified in a block? HOT 1
- Feature Request: remote_host request matcher HOT 3
- on_demand ask cache instead of rate_limit HOT 3
- Caddy is not stopping HOT 4
- Tailscale certificate is not found when email is specified HOT 3
- logs.skip_hosts is ignored HOT 12
- Placeholders do not work as upstream address for reverse_proxy HOT 2
- How can Caddy Server automatically switch over the next upstream server when it encounters an unhealthy HTTP status code during load balancing? HOT 1
- Getting real ip on docker HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from caddy.