caesarxuchao / example-webhook-admission-controller Goto Github PK

The issue I'm having with it is that it installs the admission controller service with a fixed clusterIP: 10.0.0.231. In the webhook code, the address resolver will resolve the webhook to https://10.0.0.231:443. But, this IP address is not accessible to the API server, so I don't see a request to this URL succeeding. How is this supposed to work?

Hi,

I have tried and edited the example successfully on Minikube.
Then I switched to deployment instead of specifying pod by hand and it is not working anymore, is there any specific reason why to use pod?

Thanks

I get this when i try to run make:

Step 5 : RUN go install github.com/caesarxuchao/example-webhook-admission-controller
 ---> Running in 3bc033d3ffdd
# github.com/caesarxuchao/example-webhook-admission-controller
github.com/caesarxuchao/example-webhook-admission-controller/config.go:89: undefined: "github.com/caesarxuchao/example-webhook-admission-controller/vendor/k8s.io/client-go/kubernetes/typed/admissionregistration/v1alpha1".ExternalAdmissionHookConfiguration
The command '/bin/sh -c go install github.com/caesarxuchao/example-webhook-admission-controller' returned a non-zero code: 2
make: *** [all] Error 2

what should i do?

Hi,

There is a typo in admissionregistration. I know it is now registered via the code but somebody (like me) may find it useful. I fixed it here https://github.com/tivvit/example-webhook-admission-controller/tree/fix_admissionregistration but I cannot make the pull request to tag, so I suggest moving it to branch and then I will do the pull request.

Thanks