caiofcm / dasslcy

Hi there 👋

dasslcy's Issues

wont build on colab

error 1

"cannot find the PXD file"

dasslcy/dasslc.pyx:9:8: 'dasslc_def.pxd' not found

fix 1

"edit relative import"

change

cimport dasslc_def

to

cimport dasslcy.dasslc_def as dasslc_def

error 2

"Exception values are incompatible"

dasslc.pyx:112:40:
#Cannot assign type 'BOOL (PTR_ROOT *, REAL, REAL *, REAL *, REAL *, BOOL *) except? -1'
#to 'DASSLC_RES' (alias of 'BOOL (*)(PTR_ROOT *, REAL, REAL *, REAL *, REAL *, BOOL *) noexcept').
#Exception values are incompatible. Suggest adding 'noexcept' to the type of 'residuals'.

fix 2

"add noextern to the pyx file declaration"

change

cdef dasslc_def.BOOL residuals(dasslc_def.PTR_ROOT *root,
                                dasslc_def.REAL t, dasslc_def.REAL *y,
                                dasslc_def.REAL *yp, dasslc_def.REAL *res,
                                dasslc_def.BOOL *jac):

to

cdef dasslc_def.BOOL residuals(dasslc_def.PTR_ROOT *root,
                                dasslc_def.REAL t, dasslc_def.REAL *y,
                                dasslc_def.REAL *yp, dasslc_def.REAL *res,
                                dasslc_def.BOOL *jac) noexcept:

error / fix 3

"compiler compatibility issues "

copy dasslc.c and dasslc.h from https://github.com/asanet/dasslc2py where some compiler compatibility issues were recently reviewed

error / fix 4

"legacy install failure"

suggest building without numpy requirements in requirements.txt

pip install .

Suggestion

"add COLAB live example to README"

https://colab.research.google.com/drive/1IxNXwNUTcx1Hm28rYSDUALsdOAuOvQoQ