Failing on camelCase rule about cakephp-codesniffer

[davidyell]

Happens with other class attributes also. This is "squizlabs/php_codesniffer": "1.5.5",

david@ukwm157 ~/Sites/Cricketeer $ bin/phpcs --standard=CakePHP plugins/Proffer/

FILE: ...ers/david/Sites/Cricketeer/plugins/Proffer/src/Event/ImageTransform.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 27 | ERROR | Member variable "imagine" is not in valid camel caps format
--------------------------------------------------------------------------------


FILE: ...r/plugins/Proffer/tests/TestCase/Model/Behavior/ProfferBehaviorTest.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 59 | ERROR | Member variable "behavior" is not in valid camel caps format
 61 | ERROR | Member variable "config" is not in valid camel caps format
--------------------------------------------------------------------------------

david@ukwm157 ~/Sites/Cricketeer $ 

[ceeram]

After some investigation this was caused by your modified version. The removal for underscored rule for protected/private was flawed.

[davidyell]

Was it, did I miss something? Are you sure you're not @ADmad?

[ADmad]

What?

[ceeram]

I explained on irc what you had forgotten to fix when removing the
underscored rules. cakephp-codesniffer does not have the issue you
described, it only happened in your modified version.
Op 25 nov. 2014 17:59 schreef "ADmad" [email protected]:

What?

—
Reply to this email directly or view it on GitHub
#108 (comment)
.

[ADmad]

@ceeram Okay, that took care of his first question. Now care to answer the second one?

[davidyell]

Yeah I fixed the issue you mentioned and still have the issue.

I thought that @ADmad had patched the code sniffer rules? I guess not.

I'm curious how removing an else statement to do with function underscoring
affects class attributes.
On 25 Nov 2014 17:40, "ceeram" [email protected] wrote:

I explained on irc what you had forgotten to fix when removing the
underscored rules. cakephp-codesniffer does not have the issue you
described, it only happened in your modified version.
Op 25 nov. 2014 17:59 schreef "ADmad" [email protected]:

What?

Reply to this email directly or view it on GitHub
<
https://github.com/cakephp/cakephp-codesniffer/issues/108#issuecomment-64433186>

.

Reply to this email directly or view it on GitHub
#108 (comment)
.