cakephp / cakephp-codesniffer

CakePHP Code Sniffer

CakePHP is a rapid development framework for PHP which uses commonly known design patterns like Associative Data Mapping, Front Controller, and MVC. Our primary goal is to provide a structured framework that enables PHP users at all levels to rapidly develop robust web applications, without any loss to flexibility.

Installing CakePHP via Composer

You can install CakePHP into your project using Composer. If you're starting a new project, we recommend using the app skeleton as a starting point. For existing applications you can run the following:

composer require cakephp/cakephp

For details on the (minimum/maximum) PHP version see version map.

Running Tests

Assuming you have PHPUnit installed system wide using one of the methods stated here, you can run the tests for CakePHP by doing the following:

1. Copy phpunit.xml.dist to phpunit.xml.
2. Add the relevant database credentials to your phpunit.xml if you want to run tests against a non-SQLite datasource.
3. Run phpunit.

Some Handy Links

• CakePHP - The rapid development PHP framework.
• CookBook - The CakePHP user documentation; start learning here!
• API - A reference to CakePHP's classes.
• Awesome CakePHP - A list of featured resources around the framework.
• Plugins - A repository of extensions to the framework.
• The Bakery - Tips, tutorials and articles.
• Community Center - A source for everything community related.
• Training - Join a live session and get skilled with the framework.
• CakeFest - Don't miss our annual CakePHP conference.
• Cake Software Foundation - Promoting development related to CakePHP.

Get Support!

• Slack - Join us on Slack.
• Discord - Join us on Discord.
• #cakephp on irc.freenode.net - Come chat with us, we have cake.
• Forum - Official CakePHP forum.
• GitHub Issues - Got issues? Please tell us!
• Roadmaps - Want to contribute? Get involved!

Contributing

• CONTRIBUTING.md - Quick pointers for contributing to the CakePHP project.
• CookBook "Contributing" Section - Details about contributing to the project.

Security

If you’ve found a security issue in CakePHP, please use the procedure described in SECURITY.md.

cakephp-codesniffer's Issues

Unit tests fail, a problem with input parameter `standard`

Standard's ruleset.xml location is hardcoded in PHP_CodeSniffer::getInstalledStandardPath() (l 2010):

relative to CodeSniffer.php:

./CodeSniffer/Standards/CakePHP/

where CakePHP will be the standard's name.

If that folder is not there, the standard is considered not installed. The entire test suite will then fail.

On the command-line, phpcs will be executed thus:

phpcs --standard=cakephp .

(standard's name is case-insensitive: PHP_CodeSniffer/CLI.php l 734)

Update composer.json to stick to squizlabs/php_codesniffer 1.x

PHPCS fails since last night because squizlabs/php_codesniffer release 2.0.0 stable, yesterday it was using 1.5.5.
Should we update the composer.json of cakephp/cakephp-codesniffer to require 1.4.* instead of >=1.4 so we can continue to use it and have time to update it properlly.

Here is the error :
https://travis-ci.org/cakephp/cakephp/jobs/43062118

I can handle it if you're OK

Cake2 - Advancement

Hi There

Is there a stylechecker for CakePHP 2.x or is it the same as for CakePHP 1.x?

Thank you for the information

`empty ()` (extra space)

empty () is not picked up by the CS. It should be empty() without the extra space.

See cakephp/cakephp@05546af

FunctionCommentSniff doesn't account for `@inheritDoc`

The FunctionCommentSniff complains about missing @param / @return tag when docblock only has {@inheritDoc}.

Ignore PHP Variables

After using file_get_contents, I access $http_response_header to get the response data. I have Codesniffer enabled as a pre-deploy check. Can I get it to ignore this case when it's a variable name that I can't change?

operator spacing

Currently false errors are raised for: $bar = isset($foo) ? -2 : 0;

1848 | ERROR | Expected 1 space after "-"; 0 found

Current tests also fail for this:

http://bin.cakephp.org/view/258564869 line 40

We should switch to phpcs-fixer branch in 3.x some time.

Working with the phpcs-fixer branch quite some time now, I think we should switch to it completely some time in the 3.x development.

It would fairly decrease the time to fix trivial CS errors, as all you need to do is to apply -f etc and all those issues will automatically be fixed for you - a real time safer.

A CakePHP3.0 compatible wrapper plugin for it can be seen and tested here: https://github.com/dereuromark/cakephp-codesniffer/tree/3.0#phpcs-auto-fixer

There is already a branch for it in the official CakePHP repo - just a little bit outdated at the moment:
https://github.com/cakephp/cakephp-codesniffer/tree/phpcs-fixer
It contains phpcs-fixer compatible versions of the CakePHP sniffs.

A few more current ones and extra goodies can be found in https://github.com/dereuromark/codesniffer-standards repo.

Nested elseif indention is marked as invalid

The following test fails while it should pass.

inline_elseif_pass.php

<?php
$a = 'a';
if (!empty($a)):
    $b = 'b';
    if ($b === 'c'):
        $c = 'e';
    elseif ($b === 'd'):
        $c = 'f';
    else:
        $c = 'g';
    endif;
endif;

--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 8 | ERROR | Closing brace indented incorrectly; expected 0 spaces, found 1
--------------------------------------------------------------------------------

update the README to include installation via composer instructions

since there is a way to install for this codesniffer via composer, see #72

how about an update on the instructions on README?

OperatorSpace sniff should ignore & when used as reference symbol

69 | ERROR | Expected 1 space before "&" operator; 0 found
69 | ERROR | Expected 1 space after "&" operator; 0 found
are generated for: https://github.com/cakephp/cakephp/blob/3.0/lib/Cake/Test/TestCase/Console/Command/BakeShellTest.php#L69

Enhancement for CakePHP 3.0

Considering CakePHP 3.0 will use PHP 5.4+, some rules should be included, and others maybe removed.

To include:

• traits
• namespace conventions

To remove (maybe):

• underscore to indicate members visibility ( http://book.cakephp.org/2.0/en/contributing/cakephp-coding-conventions.html#member-visibility )

Before start coding of that's rules, I want discuss if it's appropriate.

v0.1.24 broke Pear.

israel@retina ~/_mojo/git-repos/marketplace (master) $ sudo pear install --alldeps cakephp/Cakephp_CodeSniffer-0.1.23
downloading CakePHP_CodeSniffer-0.1.23.tgz ...
Starting to download CakePHP_CodeSniffer-0.1.23.tgz (25,093 bytes)
.........done: 25,093 bytes
install ok: channel://pear.cakephp.org/CakePHP_CodeSniffer-0.1.23
israel@retina ~/_mojo/git-repos/marketplace (master) $  phpcs -p -v -n --extensions=php --standard=CakePHP --
^C
israel@retina ~/_mojo/git-repos/marketplace (master) $ sudo pear uninstall cakephp/Cakephp_CodeSniffer
uninstall ok: channel://pear.cakephp.org/CakePHP_CodeSniffer-0.1.23
israel@retina ~/_mojo/git-repos/marketplace (master) $ sudo pear install --alldeps cakephp/Cakephp_CodeSniffer-0.1.24
downloading CakePHP_CodeSniffer-0.1.24.tgz ...
Starting to download CakePHP_CodeSniffer-0.1.24.tgz (29,198 bytes)
.........done: 29,198 bytes
install ok: channel://pear.cakephp.org/CakePHP_CodeSniffer-0.1.24
israel@retina ~/_mojo/git-repos/marketplace (master) $  phpcs -p -v -n --extensions=php --standard=CakePHP --
ERROR: the "CakePHP" coding standard is not installed. The installed coding standards are MySource, PEAR, PHPCS, PSR1, PSR2, Squiz and Zend
israel@retina ~/_mojo/git-repos/marketplace (master) $ 

Repeats on Travis-CI, etc. ruleset.xml seems to be missing.

bug 13 Protected Member variable "_schema" must not be prefixed with an underscore

    class ContactForm extends AppModel {

       protected $_schema = array();

    }

Codesniffer for CakePHP 3

Hi there - I've been coding using CakePHP 3, and I was wondering when the release of CodeSniffer for that might be out (or if it's out, where it's at).

I have the current one set up, but I'm getting errors that must be referencing older versions of CakePHP. (Line max is 85 rather than the suggested 100-120 on the current documentation, opening function bracket suggested on a new line rather than one space after on the current line, etc. etc.)

Add CastSniff

Include Cast sniff
to phpcs enforce the recommended way of casting as per docs.

Used in cakephp/cakephp#4570 already as autofixer version.
The version for this repo would be way simpler (just detect).

Not catching some whitespaces

See the commits cakephp/cakephp@8f78b1e and cakephp/cakephp@b7e75a6

These issues wasn't identified by the phpcs.

Underscore conflict on protected methods

Hello,

It appears that we have sniffs wanting opposite things.

The following sniff wants you to have an underscore in front of protected method names:
CakePHP.NamingConventions.ValidFunctionName.ProtectedNoUnderscore

The following sniffs want you to -not- have an underscore in front of protected method names:
PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
Squiz.NamingConventions.ValidFunctionName.PublicUnderscore

Alpabetical order of use

currently this is the only accepted order as correct alphabetical:
use Cake\Routing\RouteCollection;
use Cake\Routing\Route\Route;
use Cake\Routing\Router;

which imo should be:
use Cake\Routing\Route\Route;
use Cake\Routing\RouteCollection;
use Cake\Routing\Router;

or:
use Cake\Routing\RouteCollection;
use Cake\Routing\Router;
use Cake\Routing\Route\Route;

depending on how you treat the backslash

1.x FunctionCommentThrowTagSniff

While doing some CS fixes in our code, I came accross FunctionCommentThrowTagSniff.php.

https://github.com/cakephp/cakephp-codesniffer/blob/master/CakePHP/Sniffs/Commenting/FunctionCommentThrowTagSniff.php

There is also an identically named sniff in the Squiz Standard:
https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Standards/Squiz/Sniffs/Commenting/FunctionCommentThrowTagSniff.php

It seems @jrbasso contributed it to support namespaces
86edcb8

Implemented sniff to validate @throws in PHPDoc with support to nameespaces

But it seems there is a probably related commit to the original Sniff around that time, too:
squizlabs/PHP_CodeSniffer@add2da9

Commit history for CakePHP's FunctionCommentThrowTagSniff.php
https://github.com/cakephp/cakephp-codesniffer/commits/ea8568edb5f2f7eaf0f536372f677de365b5d7c3/Sniffs/Commenting/FunctionCommentThrowTagSniff.php
https://github.com/cakephp/cakephp-codesniffer/commits/master/CakePHP/Sniffs/Commenting/FunctionCommentThrowTagSniff.php

Commit history for the original FunctionCommentThrowTagSniff.php
https://github.com/squizlabs/PHP_CodeSniffer/commits/master/CodeSniffer/Standards/Squiz/Sniffs/Commenting/FunctionCommentThrowTagSniff.php

I haven't tried it yet, but couldn't we replace @jrbasso 's sniff with the original one?
May be @jrbasso can shed some light on this.

I'm asking because I also found a bug that exist in both sniffs. ;-)

Ruleset excludes any files with 'git' in the path

regex in ruleset.xml should change from excluding '.git' to excluding '.git'

PEAR issue?

Is there something wrong with the PEAR package?

I get:

the "CakePHP" coding standard is not installed

after installing with pear (on CircleCI):

pear channel-discover pear.cakephp.org
pear install --alldeps cakephp/CakePHP_CodeSniffer

It started failing after June 6th.

Unit Tests fail, a problem with input parameter 'standard'

PHP/CodeSniffer/CLI::process() expects array of strings

Standard parameter input is now:

• An array of strings.
• Each string must match a folder name in <php_dir>/PHP/CodeSniffer/Standards.

where <php_dir> is taken to be:

`pear config-get php_dir`

ruleset.xml is not in correct place

Standard's ruleset.xml location is hardcoded in PHP_CodeSniffer::getInstalledStandardPath() (l 2010).

Specifically, for a standard named cakephp, it is in <php_dir>/PHP/CodeSniffer/Standards/CakePHP/

If that folder is not there, the standard is considered not installed. The entire test suite will then fail.

On the command-line, phpcs will be executed thus:

phpcs --standard=cakephp .

(standard's name is case-insensitive: PHP_CodeSniffer/CLI.php l 734)

Wrong placed Class brackets are not detected

e.g.

class Test extends Object {
}

and

class Test extends Object
{
}

are both valid. :)

Sniffer rules add PHP 5.6 requirement

So this is kind of a weird one. I extended the FlashHelper to work with Bootstrap. When I did I went ahead and added some templates to help with generation. This is what I ended up with...

protected $_defaultConfig = [
    'linkClass' => 'alert-link',
    'templates' => [
        'dismiss' => '<button type="button" class="close" data-dismiss="alert" aria-label="{{label}}"{{attrs}}>{{content}}</button>',
        'dismissIcon' => '<span aria-hidden="true">&times;</span>'
    ]
];

This causes a phpcs error as the dismiss key has 134 characters on a single line. So I converted it to this...

protected $_defaultConfig = [
    'linkClass' => 'alert-link',
    'templates' => [
        'dismiss' => 
            '<button type="button" class="close" data-dismiss="alert" aria-label="{{label}}"{{attrs}}>' .
                '{{content}}' .
            '</button>',
        'dismissIcon' => '<span aria-hidden="true">&times;</span>'
    ]
];

This passes the sniffer rules so I pushed to the repo all well and good. I went to make some changes on my computer at home and I ended up with a fatal PHP error saying it expected a ] character. When I collapse everything back onto a single line the error goes away.

I'm not sure this is anything you guys would be responsible for in terms of updating your sniffer rules but it seems like such an obscure error that I just wanted to report it so you were aware.

I also seem to get conflicts when running an underscored method name such as...

protected function _getSomething()
{
}

With the underscore I get a PSR2 error. Without the underscore I get a CakePHP error. Weird. Here is the version I'm running at home. I'm not in the office so I don't have the exact output for that one but it's a fresh install of php 5.6.4.

dustin@Dustin:~/GitHub/internal$ php --version
PHP 5.5.20-1+deb.sury.org~precise+1 (cli) (built: Dec 21 2014 19:54:33) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.2.5, Copyright (c) 2002-2014, by Derick Rethans

folder name should be CakePHP instead of Cake to avoid issues

Locally, with windows I always get this fatal error:

"2013-03-12 15:49:46 Error: Cannot redeclare class CakePHP_Sniffs_Commenting_FunctionCommentThrowTagSniff in [E:...\Vendor\PHP\CodeSniffer\Standards\Cake\Sniffs\Commenting\FunctionCommentThrowTagSniff.php, line 271]"
Seems like the autoloader does include a little bit too much here.

After I searched for a solution and found thomas-ernest/CodeIgniter-for-PHP_CodeSniffer#12 I changed the folder name to "CakePHP" and it worked!

So the folder name(s) should be the same as the class name (which makes sense).

I then used

--standard=CakePHP

then and phpcs ran just fine.

ValidFunctionNameSniff complains about controller action functions with prefixes

Controller action names like admin_foo or foo_bar fail to pass the ValidFunctionNameSniff. Perhaps the rules should be tweaked to allow underscored function names in controllers atleast.

Failing on camelCase rule

So I have this error.

27 | ERROR | Member variable "Imagine" is not in valid camel caps format

My class looks like this.

private $Imagine;

I'm not really sure how to make that "camel caps" whatever that might be.

PS, The reason it's not $_Imagine is because I've removed that rule 🐍
Here are the changes I've made. https://github.com/UKWebMedia/cakephp-codesniffer/compare/cakephp:master...master

The DOC Comment must be not spaced

This error message is hard to understand, does it only apply to indented doc blocks? if so we could change it to

The DOC Block must not be indented

If it applies to any /** comment, I'm not sure what error message to suggest - but needs one that's a bit easier to understand :)

Wrong exclude pattern to ignore git internals

Any reason we want .git in any absolute path to qualify for ignore?

The following means even /User/memyself/Documents/cakephp.git/* is ignored.

<exclude-pattern>\.git</exclude-pattern>

Proposed changed:

<exclude-pattern>*/\.git/*</exclude-pattern>

Error in a test

https://github.com/cakephp/cakephp-codesniffer/blob/master/CakePHP/tests/files/whitespace_comma.php#L2
This looks like there is an error in the tests

array_map('hexdec',array_filter(...

should have a space after the comma:

array_map('hexdec', array_filter(...

Fix installation issues with composer

Currently when these code sniffs are installed with composer, they are unusable. Because the sniffs are installed into vendor/cakephp/cakephp-codesniffer, phpcs generates classnames like cakephp-codesniffer_Sniffs_Commenting_FunctionCommentSniff which clearly can never exist, resulting in fatal errors. I can see a few options to resolve this issue:

1. Get PHPCS patched to allow sniffs to be loaded based on the ruleset name attribute.
2. Rename the composer package and classnames to something like CakePHPCs. This has the drawback of forcing the PEAR installed package to also change names.

Future PEAR support

I was just wondering how the PEAR support will be handled for the CakePHP CodeSniffer in the near future?
It seems the Composer support is already setup fine but the recommended installation is still PEAR.

About tabs and spaces in coding standards

This is not a bug report, but a question (sorry if this is not the place to ask it).
I've been reading php-fig standards and coding styles. In coding styles they say:
"Code MUST use 4 spaces for indenting, not tabs."

But CakePHP still use tabs as coding standard. Does CakePHP, as a member of the project, plan to change that?

Greetings!

Auto-fixing code not correclty checking if it should run

The auto fixes in the standard don't check if they are supposed to run, so they will run even if the list of sniffs is being filtered with the --sniffs command line argument.

Examples of the code that needs correcting are:
https://github.com/cakephp/cakephp-codesniffer/blob/phpcs-fixer/Sniffs/ControlStructures/ElseIfDeclarationSniff.php#L53
https://github.com/cakephp/cakephp-codesniffer/blob/phpcs-fixer/Sniffs/PHP/DisallowShortOpenTagSniff.php#L58

The change is fairly easy. Instead of:

$phpcsFile->addFixableError($error, $stackPtr, 'MessageCode');
if ($phpcsFile->fixer->enabled === true) {
    // Fixer code here.
}

You would write:

$fix = $phpcsFile->addFixableError($error, $stackPtr, 'NotAllowed');
if ($fix === true) {
    // Fixer code here.
}

The addFixableError() and addFixableWarning() methods will only return TRUE is the fixer is enabled and if the message is not being filtered out in some way.

Type hint sniffer

I've intially written this for my own projects, but after struggeling with some incompatible type hinting in Cake 3.x, I thought perhaps something like this could be useful for CakePHP too.

I've just made some quick and dirty changes in order to make it match the (assumed) CakePHP 3.x standards (mainly doc-block type hints should be fully qualified, method type hints should be unqualified and imported), and split it into its own standard so that you can easily try it: https://github.com/ndm2/ndmcake-codesniffer

I guess I don't have to explain it, but... clone into NDMCake and run phpcs --standard=/path/to/NDMCake/ruleset.xml /path/to/files or phpcs --standard=NDMCake /path/to/files (when cloned into CS standards folder).

What does this sniffer do? Well, it looks in method signatures and the @var, @param, @see, @return, @throws, @method and @property docblock tags, and among others it checks that:

• Docblock type hints are present
• Method type hints are present in case possible (depends on the docblock type hint)
• Non-primitive docblock type hints are fully qualified
• Method type hints aren't fully qualified unless pointing into the global namespace
• Non-primitive type hints can be resolved (in case they are pointing into one of the available base packages, for example Cake)

Note that in order to be able to check whether a type can be resolved, the sniffer first parses all files and extracts namespaces and class/interface names, which can take a while.

So before I try to make this work better and massage it into the CakePHP standard, I thought I'd ask whether this would be considered useful at all?

Origin of "Doc blocks must not be indented" ?

"Doc blocks must not be indented" forces doc blocks to not be aligned to method declarations.

The PSR, PEAR & Zend styles don't enforce the "no indent" so I'm curious where this comes from?

Wrapping long strings

On occasion there might be a long string, or a series of concatenations that pass well beyond the 80 character mark.

I'm not sure what the CakePHP standards are on long strings, but for readability, I like to limit the width at approx 80 characters wide.

Currently, the concatenation rule will complain about spaces after or before a concatenation, depending on where it has been placed.

i.e. Expected 1 space after ., but 2 found or Expected 1 space before ., but 8 found.

How should concatenation of long strings be handled under CakePHP coding standards?

Add a formal License/Copyright

While the project is a public GitHub repo and presumebly has the same copyright as the Cake core, it would be great if there was a formal copyright/license applied so that the community has confidence in our usage of this CodeSniffer.

More information, if needed, on why even projects in the open should have some license applied.

• https://programmers.stackexchange.com/questions/26548/what-is-the-default-software-license
• http://blog.codinghorror.com/pick-a-license-any-license/

Confusing error message missing @throws is attached to the last docblock found

This code:

<?php
class TheClass {

/**
 * Correct
 */
        public function correct() {
        }

        public function error() {
                throw new NotFoundException();
        }
}

Will produce this output

:) ~/html/skelapp $ phpcs --standard=CakePHP example.php 

FILE: /var/www/skelapp/example.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 6 | ERROR | Missing @throws tag in function comment
--------------------------------------------------------------------------------

Time: 38 ms, Memory: 6.25Mb

Attaching the @throws error to the last docblock found in code and producing an incorrect message...

Thank you!

Maximum character limitation

Do we really need this limitation check? I could not find any hint in cakephp docu. If we still need this then pls check if we have to stick to max 85 characters

Create sniff for CakeEvent and Event

Due to cakephp/cakephp#2264 making it into 2.* and 3 we should add a sniff test for events and the doc @triggers

The requested package cakephp/cakephp-codesniffer could not be found in any version

Command: The requested package cakephp/cakephp-codesniffer could not be found in any version.

Error:

Changed current directory to /root/.composer
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1
- The requested package cakephp/cakephp-codesniffer could not be found in any version, there may be a typo in the package name.

Potential causes:

• A typo in the package name
• The package is not available in a stable-enough version according to your minimum-stability setting
  see https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion for more details.

Read http://getcomposer.org/doc/articles/troubleshooting.md for further common problems.

Installation failed, reverting ./composer.json to its original content.

Whitespaces after comma not detected

See cakephp/cakephp#1285

Camel caps format and blank lines

Example:

<?php
class Test {

    private static $__myVar = 1;

    public static function getMyVar() {
        return self::$__myVar;
    }
}

Output:

FILE: test.php
------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
------------------------------------------------------------------
 7 | ERROR | Variable "__myVar" is not in valid camel caps format
 8 | ERROR | Expected 1 blank lines after function; 2 found
------------------------------------------------------------------

• Error1: The name $__myVar is valid, but not when used with self::$__myVar or Test::$__myVar.
• Error2: The message "Expected 1 blank" is OK, but "2 found"? Shouldn't be "0 found"?

Failing tests

There are several failing tests: http://bin.cakephp.org/view/1599780770

It's in the files with HTML and PHP's alternative syntax.

There was a rule about that syntax once: 90dcfed

But as you can see it was removed, which makes sense for that use case. However, I think alternative syntax shouldn't be used within classes. So maybe add the rule again, but just for .php files and have it ignore .ctp files for example?

Shouldn't title_for_layout be ignored from the "valid camel caps format" rule?

Variable "title_for_layout" is not in valid camel caps format

phpcs installed via composer - how to install cakephp?

When phpcs is installed via composer, I have the binaries in ~/.composer/vendor/bin. How can I install the CakePHP Codesniffer then? The pear package will install it into the autoload path in php, but wont it also install phpcs if this is not present?

blank line after namespace

PSR1:
There MUST be one blank line after the namespace declaration, and there MUST be one blank line after the block of use declaration

There is no sniff currently for this

Enhancement: Return early and else blocks

A sniff that could be useful for the core:
https://github.com/dereuromark/cakephp-codesniffer/blob/master/Vendor/PHP/CodeSniffer/Standards/MyCakePHP/Sniffs/ControlStructures/ReturnEarlySniff.php

Worked quite well with my app code and the recent redirect "return early" changes.
Not sure if its appropriate for the core, though. Especially as "error"...