Comments (4)
lorenzo
commented on May 17, 2024
@dereuromark would you like to copy the fix from them?
from chronos.
dereuromark
commented on May 17, 2024
It seems that their fix only was for addWeekday. addWeekdays as well as the sub methods also need fixing i guess.
Additionally, the fixes cannot be applied without some modification for us: https://github.com/cakephp/chronos/compare/master-weekday
Tests failing ( https://travis-ci.org/cakephp/chronos/builds/92567642 ).
from chronos.
markstory
commented on May 17, 2024
@dereuromark Those changes seem reasonable. For the immutable objects, you'll need to capture the return of modify() and chain off of that instead.
from chronos.
dereuromark
commented on May 17, 2024
You are absolutely right. Done :)
from chronos.
Related Issues (20)
- Date::diffInMonths returns unexpected result in Asia/Tokyo HOT 5
- createFromFormat($format, $value) too strict HOT 2
- MutableDateTime serialization cause "Unknown setter 'date'" HOT 1
- requires cakephp/chronos 2.x-dev as 2.0.0 HOT 1
- Cake\Chronos\Date::parse("YYYYMMDD") throws unexpected TypeError HOT 2
- Date::create doesn't always returns the expected HOT 9
- Handling of the year before 1970 HOT 5
- PHP 8.1: Cannot return ChronosInterface from DateTime methods HOT 2
- `Class "Cake\Chronos\Chronos" not found` when doing composer update HOT 3
- diffForHumans() gives misleading results for future dates HOT 13
- Performance issue with the carbon_compat.php autoloader HOT 9
- Chronos::create() not working for some months HOT 3
- php 8.2: Unable to create DatePeriod with Chronos instance HOT 1
- Drop PHP 7.2? HOT 9
- Drop src/carbon_compat.php HOT 4
- Trim down the ChronosInterface's API HOT 8
- Chronos3: BC handling with native type/interface HOT 1
- ComparisonTrait::isSameDay() / ComparisonTrait::isSameMonth() HOT 2
- False Statement in 2.x Docs about Timezone Fixation HOT 2
- Hello, I would like to create a Java program for Windows 10 that has a button which, when clicked, starts a timer and that when it approaches minutes 10, 11, 12, and 13, opens a pop-up window with large text and an alarm sound. Can anyone help me with the code or point me in the right direction to get started? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chronos.