campus-experts / hackday-2017 Goto Github PK

In the event of multiple modules being submitted in one PR, Prefect should comment with a warning, close the PR, and issue guidance on how to rebase commits out of a PR.

For some modules, it is easy to catch problems outside of a human review.

For module 1 in particular, there are some common failure modes:

• Being too short.
• Not creating a timeline.
• more to come

Prefect can aid us in reviews by checking module 1 length, and the presence of required sections such as timeline.

Loads. Y'all rock, thank you so much for this weekend, it was a lot of fun working with you 💖

• @sprusr added badges to githubcampus.expert profiles and built a monstrosity.
• @wilhelmklopp made an awesome glitch graphql sample app for the reworked module 8 exercise
• @svcastaneda added skills to the githubcampus.expert profiles whilst on the worst flight layover ✈️
• @PandelisZ worked on prefect and continued improvements to the githubcampus.expert map
• @abdulajet made a push notification solution for Campus Expert (or any repo, really) announcements
• @ccannon94 dove into the module exercises and wrote a reviewer guide!
• @CaptainWalters made an archive page for all the blog posts on githubcampus.expert
• @ruxiang05 & @KaiFish worked on the motivation page for githubcampus.expert
• @KaiFish dived into Probot scripts and ported Stale to fit our discerning specification whilst a tornado was happening 🌪
• @JasonEtco came onto Slack to help us with our Probot questions
• @BlueHatbRit worked on Report-card & reviewing PRs, and had done some work before the hackday to enable us all to work together on Prefect

Apologies if I missed any one, I was up until 5am breaking a script that @PandelisZ later helped me fix 😂

@KaiFish I got this (body text wise) if no one else is doing it.

Students frequently use gendered language in submissions and comments where it is not needed. In many cases, this is due to language barriers. Prefect should support the growth of inclusivity in the community by catching these instances, and providing an explanation as to why it's uninclusive, and alternatives.

Examples:

• Uses of "he/his" when referring to a generic person doing something technical.
• Uses of male/female to refer to gender and not sex.

There are numerous aspects of etiquette we want to enforce. Some are true for all of GitHub, some are true for experts.

In particular for experts, we want to discourage students adding reviewers, or tagging reviewers, or asking for review. Prefect should post a warning to students who do this.

@joenash is working on this

Prefect should greet new users.

For some modules, students frequently submit work that they did long before the training. These submissions should be discouraged: we do not want students to just take the shortest path to becoming an expert, the exercises are evidence of effort applied.

For some modules, this is especially easy to catch.

• For module 7, people frequently provide commits from the past, we can check the commit date.
• For module 12, 13 and 14, we can check the latest commit date on the repo, or the original commit.

When this happens, Prefect should warn them that their submission may not be eligible for the application, and provide a link to the module choice issue.

Markdown is new to many students, and mistakes are often made in styling. Prefect should help our students with good markdown style, by linting their markdown documents.

There is a pull request template that has three functions:

• Prompting students to provide the correct information.
• Providing instructions such as applying labels.
• As a test whether students are paying attention.

This template is frequently ignored: when the required sections aren't deleted, it's a sign the instructions aren't being followed. The template is our brown m&ms.

When they don't delete the required lines, we should close the pull request, and post a message reminding them to follow instructions.

Prefect will provide data for Report Card.

• Webhook to be called when a PR is opened with just a ton of info if possible to the endpoint of POST /queue/exercise. But only post when the "exercise" tag is added so we don't get typo corrections in there.
• To compliment that, one for when a PR is merged or closed. Probably to DELETE /queue/exercise/:id where id is the github repo PR id (https://github.com/campus-experts/open-training/pull/724 this is 724 for example)
• We want a webhook to be called when someone infringes the template and Prefect has to tell them to correct it. So that'll be something like POST /trainee/infringement.

I am working on adding this

video to guide people through making a pull request and following the template