canonical / argo-workflows-rocks

ROCKs for Argo Workflows

argo-workflows-rocks

ROCKs for Argoi Workflows

argo-workflows-rocks's Issues

Workflows are needed for this repository (WIP)

Description

Main issue: canonical/bundle-kubeflow#692

Workflows are needed for this repository:

• on pull request execute ROCKs sanity tests (a.k.a. smoke tests), peform CVE scans
• on merge publish ROCK

Without integration tests in ROCK repository how do we ensure ROCK is acceptable to be used in charm? Do we publish ROCK regardless as long as it passed sanity tests?

Bring arogexec ROCK up to spec

Description

Arog exec ROCK was created as part of workshop. Since initial ROCK was created a number of best practices were developed to make ROCKs more secure and more uniform.

Bring Argo exec ROCK up to date with best practices spec.

Arog Exec ROCK: https://github.com/canonical/argo-workflows-rocks/blob/main/argoexec/rockcraft.yaml

Error when adding non-root user part to argocli rockcraft.yaml

when adding the part:

  non-root-user:
    plugin: nil
    after: [copy]
    overlay-script: |
      # Create a user in the $CRAFT_OVERLAY chroot
      groupadd -R $CRAFT_OVERLAY -g 1001 ubuntu
      useradd -R $CRAFT_OVERLAY -M -r -u 1001 -g ubuntu ubuntu
    override-prime: |
      craftctl default

to argocli rock
Running rockcraft pack produces error logs:

+ groupadd -R /root/overlay/overlay -g 1001 ubuntu
groupadd: cannot lock /etc/group; try again later.

Update `argoexec` ROCK

Context

Each charm in Kubeflow has a ROCK (or a set of ROCKs) it is using. The process of upgrading ROCKs usually means going to the component's upstream repository Dockerfile, comparing current ROCK version against the one in the repository and adding the missing bits.

What needs to get done

1. Clone the upstream's kubeflow repository.
2. Go to desired Dockerfile (first line in rockcraft.yaml should specify the full path).
3. Checkout to the branch or tag of the target version.
4. Checkout to the branch or tag of the version of the current ROCK.
5. Compare both files to spot the differences.

Definition of Done

1. New ROCK is ready.
2. Tests are passing.
3. ROCK is published under charmedkubeflow Dockerhub account.

argo-workflow-rocks: Update `push` and `pull_request` CI

Context

canonical/bundle-kubeflow#797

What needs to get done

Update on_push.yaml and pull_request.yaml according to example.

Definition of Done

Workflows are updated