Comments (5)
Thanks for the report. This behaviour is currently by design.
One of the requirements for the expandable navigation was to be able to link to a documentation page and being expandable. That's why clicking on navigation item (like "Install") is separate from expanding it.
In this particular implementation it seems that "Install" doesn't have a paged linked to, which is not a recommended use of this component. For situations like this we have the "accordion" version of side navigation, where navigation items are expandable, but don't navigate to pages.
https://vanillaframework.io/docs/examples/patterns/side-navigation/accordion
I see this issue being reported by different people via various channels, so I'll bring it up to Vanilla Working Group to see how we can better address it.
from vanilla-framework.
WG: The behaviour of the side navigation was intended to be consistent regardless of whether there is a page or not on the nav item. The design decision from the documentation team was that it is essential that every item of the navigation is also a page. By having the chevron behave sometimes in one way and sometimes in another is not recommended.
@evildmp just so you are aware.
from vanilla-framework.
What does that mean practically? Is there any action to be taken by the framework or is the issue in the consumer side of the framework effectively?
from vanilla-framework.
To my understanding this is a content issue. For this component to be used as intended all items in the navigation should be linked to a page.
from vanilla-framework.
WG: This depends on the documentation team's decisions on how the side nav behaves. We will close this issue, unless there is an agreement on changing the approach with docs.
from vanilla-framework.
Related Issues (20)
- Change icon alignment to `middle` when next to paragraph text
- p-modal__header need overflow:auto to prevent margin collapse HOT 1
- Intermittent color theme variation in Percy builds HOT 2
- Unnecessary capitalisation in tables HOT 2
- Modal component documentation page: Unexpected autoscroll/focus
- Application Layout / Default example's table tooltips don't allow proper overflow
- Sortable table has ascending and descending functionality/indicators swapped
- Article pagination component prev & next selectors use rotated chevrons
- Add expand functionality to Code snippet HOT 2
- Align colors for Input background and Code background HOT 1
- Make modal padding match grid row padding across all breakpoints HOT 1
- p-logo-section--dense: can we make the logo sizes 6.5rem (104px)
- Image container aspect ratios do not apply on small screens HOT 1
- Navigation scripts are not well-encapsulated
- p-navigation logo shape and icon not spaced correctly
- Equal heights component: subgrid on medium has more columns than needed HOT 2
- Positive button's focus in invisible on dark theme HOT 4
- Paper theme alternate background should be darker, not white HOT 1
- Limit all headings to 40rem, same as paragraph text HOT 1
- Navigation dropdowns do not report expanded/collapsed state
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vanilla-framework.