Errors when exporting to object dictionary about canopeneditor

[Robotae]

I've had a similar issue with generating .[ch] files from an .eds file. I believe it's caused by commit 5b7f3f5 from 16th March 2023. This requires the user to provide correct count labels; fine if you're using a .xpd file but no good for .eds files as they don't contain count labels.
This can be demonstrated by opening DS301_profile.xpd from the EDSEditorGUI/Profiles directory, export the .[ch] files (File->Export CanOpenNode...), export as an .eds file (File->Export...), closing the .xpd file, opening the .eds file and exporting the .[ch] files. OD.h exported from the .xpd file contains all the OD_CNT_* defines in the "Counters of OD objects" section but OD.h exported from the .eds file contains none of these.
I'm using EDSSharp on the command line to generate .[ch] files from an .eds file. How about adding an option to EDSSharp (and EDSEditor) to automatically add count labels if they're missing, as it used to do, so these tools can be used with .eds files again?

[spydatron]

This is the eds file: SEE maxxon.eds.txt TWO POST LATER

[trojanobelix]

Please attach files directly!
What Version do you use?

[trojanobelix]

maxxon.eds.txt

For the countlables I have to dig a little deeper

@CANopenNode Can you give me a hint for the other wrnings?
Do we need these Warnings in the CanOpenExporter?
There is nothing in the CiA 306 definition for EDS files that justifies these warnings! The EDSchecker from Vector would also check this object as error-free!

if (data.cType != dataElem.cType || data.length != dataElem.length) Warnings.AddWarning($"Error in 0x{indexH}: Data type of elements in ARRAY must be equal!", Warnings.warning_class.WARNING_BUILD); if ((data.cValue == null && dataElem.cValue != null) || (data.cValue != null && dataElem.cValue == null)) Warnings.AddWarning($"Error in 0x{indexH}: Default value must be defined on all ARRAY elements or must be undefined on all ARRAY elements!", Warnings.warning_class.WARNING_BUILD); if (attr != attrElem) Warnings.AddWarning($"Error in 0x{indexH}: Attributes of elements in ARRAY must be equal", Warnings.warning_class.WARNING_BUILD);

[CANopenNode]

If you import eds file, there is no information about CANopenNode specific parameters. Also have to follow rules described here: https://github.com/CANopenNode/CANopenNode/blob/master/doc/objectDictionary.md

Or use communication objects from DS301_profile.xpd

[trojanobelix]

Closed: No feedback