cap-go / capacitor-nativegeocoder Goto Github PK

When trying to install the plugin on a Capacitor 4 app, the following error occurs:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @capacitor/[email protected]
npm ERR! node_modules/@capacitor/core
npm ERR!   dev @capacitor/core@"^4.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @capacitor/core@"^3.0.0" from @capgo/[email protected]
npm ERR! node_modules/@capgo/nativegeocoder
npm ERR!   @capgo/nativegeocoder@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 

Hello! I see that nativegeocoder must be bumped to Capacitor v5

Cheers

It seems there is a missing ? in the url called, in the forwardGeocoding.

When trying, it calls https://maps.googleapis.com/maps/api/geocode/jsonaddress= instead of https://maps.googleapis.com/maps/api/geocode/json?address=

I just tried using this plugin to reverse geocode on web and passed in the required parameters: latitude, longitude, and apiKey. however, it returned 0 addresses. I then manually put the generated url into my browser. with result_type=street_address, there are indeed no results, but without that parameter, I get several results. it seems they have types like bar, establishment, and store. they just don't have street_address.

is it possible to remove this parameter or at least make it a configurable option?

When searching for certain addresses, the forward geocoding works on web but fail on native.

In this example, "Cape Town International Airport (CPT), Matroosfontein, Cape Town, South Africa" worked on Web but fail on native.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): update typescript-eslint monorepo to v7.11.0 (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• chore(deps): lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency @ionic/eslint-config to ^0.4.0
• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-java action to v4
• chore(deps): update actions/setup-node action to v4
• chore(deps): update js-devtools/npm-publish action to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

I'm examining the results form this plugin and while I get a bunch of address components, there's no formatted_address field. when examining the network traffic through web, I see that the response indeed includes formatted_address but looking at the source code, I think this plugin doesn't forward that info.

is there a thinking behind this? I could simply reconstruct the formatted address from the address components that are returned, but why not just pass through formatted_address if it's already given?

Not sure if it is linked to the plugin or my implementation of it (with TypeScript) but I receive this error when I call NativeGeocoding.forwardGeocode():

Error: TypeError: Cannot read properties of undefined (reading 'slice')
at web.ts:105:1
at async createMap (index.tsx:54:1)