cap340 / cleanmedia Goto Github PK

Counting the file size $size += $file->getSize(); occurs after the file is deleted $this->driverFile->deleteFile($file);, which leads to an error: SplFileInfo::getSize(): stat failed for /some/path/some_image.jpg

vendor/cap/cleanmedia/Console/Command/CleanMedia.php:118-137

/** @var SplFileInfo $file */
foreach ($iterator as $file) {
    if ($isNoCache) {
        if (strpos($file, "/cache") !== false) {
            continue;
        }
    }
    $filename = $file->getFilename();
    if (!in_array($filename, $inDb)) {
        $fileRelativePath = str_replace($mediaPath, '', $file->getPathname());
        if (!$isDryRun) {
            $output->writeln('<comment>REMOVING: </comment>' . $fileRelativePath);
            $this->driverFile->deleteFile($file);
        } else {
            $output->writeln('<comment>DRY-RUN: </comment>' . $fileRelativePath);
        }
        $count++;
        $size += $file->getSize();
    }
}

Hi,

Is it possible to run the command in cron? I'm wondering how the prompts (Continue? [Yes/No] for example) will react if I'm running it in cron or background.

Any advice?

Thanks!

Hi. When running your script I get:
In ErrorHandler.php line 61:
Warning: filesize(): stat failed for myfolder/public_html/pub/media//catalog/product/image/321437726/. in myfolderpublic_html/app/code/Cap/CleanMedia/Console/Command/CleanMedia.php on line 108
And script stops. Can you help please?
magento 2.3.1 version

As I checked further this /321437726/ is empty...

Hi,

I just submitted your module to Packagist so it's available via Composer, do you want to do it yourself so it's related to your account?

Thanks for your work :)

Hi,

It would be nice to have an option to limit the number of files the command browses. I just runned it on a Magento with 5M+ files and the NFS server is running down.

Maybe something like php bin/magento cap:clean:media --limit=XXX.

Every time I try to run it, it warns me I have to run it with dryrun, and will not just delete things.

Please advise.