GithubHelp home page GithubHelp logo

careteditor / issues Goto Github PK

View Code? Open in Web Editor NEW
326.0 13.0 12.0 93 KB

Caret issues

Home Page: https://caret.io

markdown-editor markdown electron-app electron-application electron desktop-application desktop-app

issues's People

Contributors

astoilkov avatar erusev avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

issues's Issues

Enable accents

Hello, when I try to write in Spanish with accents even though I type them the text doesn't show them. This is an example:

Revisión

screen shot 2015-11-30 at 16 04 35

Pressing CMD+[minus] or CMD+[plus] causes error

It's so easy to report a bug, I'm sure you'll get a lot of these ;)

Pressing CMD+[minus] or CMD+[plus]— (common shortcuts for zoom) causes the following error to occur:

{
    "type": "javascript-error",
    "message": "Uncaught TypeError: Cannot read property 'call' of undefined",
    "path": "/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js",
    "line": 5,
    "platform": "darwin",
    "os": "MacIntel"
}

Menus don't follow OS X conventions

Overall the app is pretty great. Here's some nitpicky stuff that made it feel a little off for me:

Caret's menu deviate from OS X conventions::

  • By putting preferences in the menu bar
  • Not having an About option in the application menu
  • Including options like Minimize and Fullscreen in the application menu, which are typically in a Window menu
  • The Preview item does not change state when Preview is active. Typically a checkmark is added like: screen shot 2015-12-08 at 4 34 03 pm
  • Typically the ⌘P shortcut is used/reserved for Print
  • Menu items that will present a dialog or confirmation don't have ... after them. E.g. Save As

When saving a new document the save dialog defaults to the root of the hard disk, whereas this would normally be one of the directories in the user's home directory such as Documents.

Issue while trying to save note

The following error has occurred:

{
    "type": "javascript-error",
    "message": "Uncaught Error: EACCES: permission denied, open '/2015-11-28.md'",
    "path": "fs.js",
    "line": 549,
    "platform": "darwin",
    "os": "MacIntel"
}

This occurred because the default directory is set as root; Perhaps set it to current user's home folder?

Option to hard wrap

I'm a big fan of 80 character line wraps and it would be great to have this option available within caret.

Right click over text

The following error has occurred:

{
    "message": "Uncaught TypeError: Cannot read property 'top' of undefined",
    "line": 5,
    "column": 1294,
    "version": "0.4.4",
    "platform": "darwin",
    "os": "15.0.0",
    "path": "/Applications/Caret.app/Contents/Resources/app.asar/web/Editor.Menu.js",
    "stack": [
        "at Object.EditorMenu._showing (/Applications/Caret.app/Contents/Resources/app.asar/web/Editor.Menu.js:5:1294)",
        "at loopEvents (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:229)",
        "at List.Events.trigger (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:527)",
        "at List.inherit.show (/Applications/Caret.app/Contents/Resources/app.asar/web/ContextMenu.js:5:435)",
        "at Object.EditorMenu.show (/Applications/Caret.app/Contents/Resources/app.asar/web/Editor.Menu.js:5:657)",
        "at HTMLDocument.<anonymous> (/Applications/Caret.app/Contents/Resources/app.asar/packages/Editor/EditorDesktop.js:5:1641)"
    ]
}

Preview slows down typing with many math expressions

I'm writing a 10-page (so far) document with about 70 (so far) math formulae, and typing is getting really slow if I keep preview open.

Would you consider, when there are math expressions, adding a small delay like 500 ms without typing before rendering? I'm more OK with no preview rendering while I'm typing than slow typing (letters not appearing for .3-.5s on my Core i5 MacBook Pro).

Display fails to redraw when going from retina to non-retina displays

When moving Caret.io between a retina and non-retina screen, redraw fails to complete resulting in application having incorrect resolution

going from retina to non-retina display:
caret_io - retina to non-retina

going from non-retina to retina display:
caret_io - non-retina to retina

temporary resolution is to force redraw by calling Recent File or Search Headings shortcuts

Multiple windows

I'd like to open several documents at the same time

(The shortcut for this could be the widespread cmd-shift-N).

JavaScript error during the update to 1.0.1

A JS error occurred during the update to the app's latest version, 1.0.1. The update seems to otherwise complete successfully. Here's what happened:

I was using Night mode. I started the app, no files were open. I was looking for the "Enter license" menu in Help, but found none. I clicked on "Report an issue" by accident, the issues page on GitHub opened in a browser. Went back to the app and saw that the "update available" bar had appeared. I clicked restart. The app closed and the following error popped up:

A JavaScript error occurred in the main process

Uncaught Exception:
TypeError: autoUpdater.quitAndUpdate is not a function
    at EventEmitter.<anonymous> (/Applications/Caret.app/Contents/Resources/app.asar/main/AutoUpdater.js:5:681)
    at emitOne (events.js:82:20)
    at EventEmitter.emit (events.js:169:7)

I clicked "OK" and after a bit a new version of the app started. It seems to be working okay for now. It reports it's version 1.0.1. The "Enter license" menu was now present and I was able to successfully activate my license.

Cannot Open Non-Markdown File Extensions

I tried opening a non-markdown file, that is markdown format but not given correct extension (it had a blank extension).

The following error has occurred:

{
    "message": "Uncaught TypeError: Cannot read property '0' of null",
    "line": 5,
    "column": 2571,
    "version": "0.4.4",
    "platform": "darwin",
    "os": "15.0.0",
    "path": "/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FolderView.js",
    "stack": [
        "at View.caret.inherit._select (/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FolderView.js:5:2571)",
        "at loopEvents (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:229)",
        "at Object.Events.trigger (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:527)",
        "at Object.List._selectItem (/Applications/Caret.app/Contents/Resources/app.asar/web/List.js:5:1952)",
        "at Object.List._handleKeydown (/Applications/Caret.app/Contents/Resources/app.asar/web/List.js:5:2754)"
    ]
}

Spell-checking does not use system settings

I use spell-checking on Mac OS with British English rules (Mac OS Preferences -> Keyboard -> Text -> Spelling: British English).

Other apps resort to that - e.g. Slack is underlining the word revolutinize, but accepts the word revolutionise. If I change my settings to American English, it would do the opposite.

However Caret is not conforming to this and it seems it's always using American English.

Nested List Support

It appears that nested lists aren't well supported.

Auto-completion, highlighting, and preview all seem broken when writing nested lists.

Example:

Some list:
  1. A
  2. B
    - a
    - b
  3. C

Github Rendered:

Some list:

  1. A
  2. B
    • a
    • b
  3. C

Autosave

Autosave is a nice feature, since user doesn't have to save the file every time there's a change. It would be nice if caret supported it. Maybe it can be added to roadmap.

Error on File Open

This happened when I tried to open a file from Cmd+T.

{
    "message": "Uncaught RangeError: Invalid count value",
    "line": 5,
    "column": 16816,
    "version": "0.4.4",
    "platform": "darwin",
    "os": "15.0.0",
    "path": "/Applications/Caret.app/Contents/Resources/app.asar/web/Editor.Markdown.js",
    "stack": [
        "at String.repeat (native)",
        "at Object.EditorMarkdown.(anonymous function)._resizeSetext (/Applications/Caret.app/Contents/Resources/app.asar/web/Editor.Markdown.js:5:16816)",
        "at Object.EditorMarkdown.(anonymous function)._onBeforeUpdate (/Applications/Caret.app/Contents/Resources/app.asar/web/Editor.Markdown.js:5:19872)",
        "at loopEvents (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:229)",
        "at Object.Events.trigger (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:527)",
        "at Object.Editor.(anonymous function)._update (/Applications/Caret.app/Contents/Resources/app.asar/web/Editor.js:5:13213)"
    ]
}

Support YAML front matter

Reference to the Jekyll docs: http://jekyllrb.com/docs/frontmatter/

I know you want to support this in the future, but I didn't find any issue about it.

But what does support for front matter mean?

Here are some pointers:

  • Render it as a table in the preview similar to GitHub
  • Recognise some of the properties as special. E.g. title could be identified as a heading so the Jump->To Heading... action would recognise and find it.
  • Validate it against YAML specification
  • Syntax-highlight it - YAML keys and values and perhaps colour the recognised keys differently

unable to create file through file navigator

steps to reproduce:

  1. navigate to a folder
  2. write the name of a file that doesn't exist
  3. hit enter

The following error has occurred:

{
    "type": "javascript-error",
    "message": "Uncaught TypeError: Path must be a string. Received undefined",
    "path": "path.js",
    "line": 8,
    "platform": "darwin",
    "os": "MacIntel"
}

Error saving a file

The following error has occurred:

{
    "type": "javascript-error",
    "message": "Uncaught Error: EACCES: permission denied, open '/rails_notes.md'",
    "path": "fs.js",
    "line": 549,
    "platform": "darwin",
    "os": "MacIntel"
}

Uncaught TypeError: Cannot read property 'start' of undefined

The following error has occurred:

{
    "message": "Uncaught TypeError: Cannot read property 'start' of undefined",
    "line": 5,
    "column": 3010,
    "version": "1.0.1",
    "platform": "darwin",
    "os": "15.0.0",
    "path": "/web/Editor.Spellcheck.js",
    "code": ".start>=s&&(n.start=Math.max(n.start+i,0),n.end=Math.min(n.end+i,r),n.end<0&&(h.splice(a,1),a-=1)),(n.start>=e.start&&n.end<=e.end||e.start>=n.start&&e.end<=n.end)&&(h.splice(a,1),a-=1)},_selectionChange:function(t)",
    "stack": [
        "at Object.EditorSpellcheck._updateRanges (/web/Editor.Spellcheck.js:5:3010)",
        "at Object.<anonymous> (/web/Editor.Spellcheck.js:5:1599)",
        "at Array.forEach (",
        "at Object.EditorSpellcheck._update (/web/Editor.Spellcheck.js:5:1557)",
        "at loopEvents (/web/Events.js:5:229)",
        "at Object.Events.trigger (/web/Events.js:5:527)",
        "at Object.Editor.(/web/Editor.js:5:13781)",
        "at Object.Editor.(/web/Editor.js:5:13293)"
    ]
}

Save to Gist / Open from Gist

Is it on your roadmap to allow the editor to communicate with the github API in order to save a given note as a gist?

  • And, conceivably, ingest a gist from same API for editing?

💭

Use a tick next to Preview item in the menu

This is just a small nitpick. Similar to the way Caret uses tick symbols next to active items in the Preferences menu, you could have a tick next to the Preview item in the File menu when it is active.

Detect changed files on focus/Option to "reload" file

HI!

I'm starting to use Caret, and I've run into the issue a couple of times... I have all my notes in a /Notes folder and I use nvALT to edit/view/search them...

The problem appears when I change something in a "note" that I have been working on Caret, and then go back Caret and want to keep working there's no prompt or option to "reload" the content... If I want to reload the doc I have to either close and open, or open a different document and open the one I want (using ⌘-T to go to the Folder view and selecting the same file I have open doesn't reload).

And if I forget to do it, and save, then I overwrite the changes I had done in the file - not good either...

I think that "change detection" and "autosave" (I've seen it's been reported as issue #17), are two important features to really make Caret shine.

add `Check for Updates` button/option

Hi!

I know that Caret should auto-detect when there's a new update pending and prompt to update.

I've created a couple of suggestions/bugs (#36 and #35) that have been marked as fixed and where I'm told that I should expect an update soon... but it's been a couple of days and I haven't got the update notification (I'm still at Version 1.0.2).

So I think being able to "force" an update check (as most if not all non-Mac App Store apps in OSX implement) would make a lot of sense

Thanks!

Use HTTPS for connections to caret.io

During the startup little snitch prompts to connect to caret.io however it's only using HTTP instead of HTTPS. Depending on what this is used for, this should really be using HTTPS.

Support hard wrapping with newline characters

What I mean by hard wrapping is instead of just showing the text as wrapped in the editor, actually place newline characters between words at around column 80. This way when the Markdown file is just typed normally in Caret, it would look the same when opened in an editor with wrapping disabled - e.g. Sublime Text by default, github.com file viewer, diffs, patches etc.

Vim supports this as an option and it is enabled by default when writing Git commits if you have installed Git properly and you are using Vim as your $EDITOR.

A lot of syntax and semantic details in Markdown come from email and email (and other wrapped text) is ideal when it is hand-wrapped. So Markdown was designed with this in mind so when there is a single newline character between words, to treat that as just a space and not put an actual new line in the rendered output unless there were either two spaces or two newline characters. So when typing I'd like to make use of that and instead of just visually wrapping to achieve hard wrapping automatically like I can with Vim.

P.S. Some thoughts from Linus Torvalds on manually wrapping text in emails: http://lxr.free-electrons.com/source/Documentation/email-clients.txt
P.P.S. Just to note this is really hard and probably not such a needed feature so I'm just putting it out there, but I don't expect it to be available anytime soon.

Error on save

The following error has occurred:

{
    "message": "Uncaught Error: ENOENT: no such file or directory, stat '/Users/tulu/Desktop/project status.md'",
    "line": 854,
    "column": 18,
    "version": "0.4.3",
    "platform": "darwin",
    "os": "15.0.0",
    "path": "fs.js",
    "stack": [
        "at Error (native)",
        "at fs.statSync (fs.js:854:18)",
        "at Object.fs.statSync (ATOM_SHELL_ASAR.js:225:16)",
        "at FileManager.caret.inherit.saveFileContents (/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FileManagerDesktop.js:5:803)",
        "at FileManager.save (/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FileManager.js:5:2146)",
        "at loopEvents (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:229)",
        "at Object.Events.trigger (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:527)",
        "at emitTwo (events.js:87:13)",
        "at EventEmitter.emit (events.js:172:7)"
    ]
}

Critical - Typing accented characters (like in "cómo", "línea") deletes the previous lettter

Hi!

Just getting started with Caret (looks great), but I've run into a "I can't work with it" bug in the first 10 minutes.

Caret has an issue on the way it handles the accented characters (which in Spanish, for instance, are quite common). When typing words like cómo´ andlínea`, when typing the accent, the previous letter is deleted.

I've done a GIF capture to show what I mean; hope that it's properly visible
caret-accented-characters-issue

Please fix ASAP as it's quite unusable for me at it is.

Thanks!

OSX - Issues with spellcheck? Support for non-english language docs?

I'm using Caret on OSX, and when opening my test documents (in Spanish), I get lots of "underlines" and I get prompted to correct the word and the options than I'm presented are English words.

When opening the same doc in other apps (nvALT and TextWrangler, for example), I don't have any issue with Spellchecking - I get suggestions (in Spanish) when I miss-type a word, and that's it... and whe the document is in English, the system figures it out and acts accordingly.

I haven't configured/changed anything in the system for the other apps, but I was wondering if there's some config to be done in Caret to recognise Spanish (or non-English) text

Thanks

file browser only finds text files

The file browser does not display images or other files present in the current directory. If you type a filename manually, the app says the file does not exist even when it does. One common use-case for the file browser is to insert links to images, so it'd be nice to have images be visible in the browser, or at least to not report them as missing if they do exist.

add new columns and rows to a table

I love the auto-expanding Markdown tables. It would be even better if, when you add a new column to a header, the app would automatically add the column end delimiter to each row of the table.

| first | second |
| ----- |
| value |

is autocompleted to

| first | second |
| ----- | ------ |
| value |        |

Similarly, when adding a new row, automatically create all columns, so that

| first | second |
| ----- | ------ |
| 

is autocompleted to

| first | second |
| ----- | ------ |
|       |        |

Just some thoughts. Thanks for considering.

Multiple cursors

Having support for multiple cursors would make for a killer feature.

jump to previous/next header

I don't really understand the purpose of cmd-] and cmd-[. Perhaps on Windows it's different, but on Mac you can just use option-down and option-up to achieve more or less the same behavior. It would perhaps be more interesting to have cmd-] and cmd-[ jump to the previous or next header, so you can easily navigate back to a previous section.

(Though perhaps there are better ways to quickly get an overview of your document and to navigate to different sections. This is just something to think about, not really a feature request.)

Error while trying to save file in the Google Drive folder

The following error has occurred:

{
    "message": "Uncaught Error: ENOENT: no such file or directory, stat '/Users/user/Google Drive/Notes/2015-11-30-Title.md'",
    "line": 854,
    "column": 18,
    "version": "0.4.3",
    "platform": "darwin",
    "os": "15.0.0",
    "path": "fs.js",
    "stack": [
        "at Error (native)",
        "at fs.statSync (fs.js:854:18)",
        "at Object.fs.statSync (ATOM_SHELL_ASAR.js:225:16)",
        "at FileManager.caret.inherit.saveFileContents (/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FileManagerDesktop.js:5:803)",
        "at FileManager.save (/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FileManager.js:5:2146)",
        "at loopEvents (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:229)",
        "at Object.Events.trigger (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:527)",
        "at emitTwo (events.js:87:13)",
        "at EventEmitter.emit (events.js:172:7)"
    ]
}

New update breaks the save features.

The new caret isn't able to save.

The following error has occurred:

{
    "message": "Uncaught Error: ENOENT: no such file or directory, stat '/Users/vjdhama/Work/rails/crystal_lang.md'",
    "line": 854,
    "column": 18,
    "version": "0.4.3",
    "platform": "darwin",
    "os": "14.5.0",
    "path": "fs.js",
    "stack": [
        "at Error (native)",
        "at fs.statSync (fs.js:854:18)",
        "at Object.fs.statSync (ATOM_SHELL_ASAR.js:225:16)",
        "at FileManager.caret.inherit.saveFileContents (/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FileManagerDesktop.js:5:803)",
        "at FileManager.save (/Applications/Caret.app/Contents/Resources/app.asar/packages/FileManager/FileManager.js:5:2146)",
        "at loopEvents (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:229)",
        "at Object.Events.trigger (/Applications/Caret.app/Contents/Resources/app.asar/web/Events.js:5:527)",
        "at emitTwo (events.js:87:13)",
        "at EventEmitter.emit (events.js:172:7)"
    ]
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.