carson-katri / reddit-swiftui

A cross-platform Reddit client built in SwiftUI

A cross-platform Reddit client created in SwiftUI.

Get the Public Beta

Note: This project is far from complete. It still lacks many features of your typical Reddit client and has bugs (partly due to SwiftUI, but I'll take credit for some of them)

To show off SwiftUI's strength in cross-platform development, I did not use Mac Catalyst for this project. Instead, common UI code is shared between iOS, macOS, and watchOS.

Project Structure

• Shared - Models, helpers, API, and any shared Views.
• Reddit-[PLATFORM] - Each target folder contains a Views and Representable folder. Views holds platform-specific views, and Representable contains UIViewRepresentables or NSViewRepresentables.

macOS Specific Features

I've added several things to make the macOS app stand out:

1. Double click - You can double click on a post to open a new window for the detail view.
2. NSToolbar - This is implemented entirely in the AppDelegate, and uses standard Cocoa code which interfaces with the SwiftUI views.
3. TouchBar - TODO

SF Symbols

Because macOS doesn't support SF Symbols, I have created the following extension to make sure shared code works. I would like to replace this with custom icons for macOS that it loads from XCAssets eventually:

/// `SwiftUI` compatibility
#if os(macOS)
extension Image {
    init(systemName: String) {
        self.init(nsImage: NSImage())
    }
}
#endif

reddit-swiftui's Issues

No releases?

You should build the app and upload the .app to the Releases tab :)

Comments don't load

TestFlight

I'd be interested in testing this out through TestFlight. An email invite ([email protected]) would be wonderful, and/or you could generate a public TestFlight link and put it on the repository.

Unable To Build

Unable to build the project due to WatchKit.

This app could not be installed at this time.
Domain: IXUserPresentableErrorDomain
Code: 1
Failure Reason: Could not install at this time.
Recovery Suggestion: Watch-only apps cannot be contained in companion apps installed on the companion.
--
Watch-only apps cannot be contained in companion apps installed on the companion.
Domain: MIInstallerErrorDomain
Code: 135
User Info: {
    FunctionName = "-[MIInstallableBundle _validateCompanionAppStateInWatchKitApp:withVersion:error:]";
    LegacyErrorString = WatchOnlyAppOnCompanion;
    SourceFileLine = 611;
}
--


System Information

macOS Version 10.15.6 (Build 19G46c)
Xcode 12.0 (17175.2)

Blue Selection trigged when List (Blur) Selection expected

NavigationLink and List selection state seem to be overlapping.

There are two ways this happens:

1. • select a post
   • see the post now has a grey selected background
   • tap section header
   • see the selected post now has a blue selected background
   • all consecutive selections will have a blue background as well
2. Click on the edge of the list item (outside the text or images)

Perhaps make the click area fill the space so that clicking on the edge won't cause a selection.

Missing source file

MetadataView.swift file is missing in the repo.

Pagination

Any plan to add pagination to the post list?

Thumbnails should go on the right

For legibility purposes, thumbnails should go on the right.

Error on picking up item from the sidebar

Hi, actually accidentally typed in this word for searching skimming through the app
IDE XCode 12

the video snippet is here for more details: https://disk.yandex.ru/i/2e0nPs0srgkfug

[Help] to Work on my machine and I contributo to project!

[HELP] i need help to branch oauth work on my machine, i get error when o compile project, error in Request not found!

Use SFSymbols on macOS Big Sur

Hi

So that extension on NSImage on macOS makes a blank image and has a placeholder input string to maybe do something with in the future or...?

Thanks in advance.

Xcode Build Fail - MacOS

I get this error:

Showing Recent Issues
No account for team "FH9CW55WY5". (Add a new account in the Accounts preference pane or verify that your accounts have valid credentials.)

PostList Content Cut Short

I believe this is when all posts are text-only posts, the right side of the content in the PostList is cut off (roughly the same amount as if a thumbnail would be there). On both iOS and macOS

[macOS] Clicking on the post list text, the NavigationLink isn't triggered

What happens:
When clicking on any of the text, or elements, that are in the List on macOS, the NavigationLink destination isn't triggered.

An example:
When clicking on the text that is enclosed within the red box,

The PostDetailView destination does not get triggered.
The only way to trigger the PostDetailView is to click outside of the Text elements.

Additional details:
Removing the .onTapGesture(count: 2) from macOS' PostView will allow the clicks to be passed through again. Though, this obviously removes the double click to open a new window functionality.

PostDetailView Title - Text Wrapping macOS

Currently the post title becomes multiline on iOS but is truncated on macOS.