Comments (5)
Sure, I can add attach
option.
Not sure I understood your idea of automatically attaching files: how could it detect files?
Maybe it could do something like if (data[key] instanceof ...)
?
Since you already have the code, you can nail it down: instance of what class the file parameter should be.
Or should it detect if the whole data
is FormData
and then act accordingly?
But as per your first example it already can post FormData
without issues.
from react-pages.
Yep using FormData works just fine, just took me some time digging to figure out how to do that. So just an enhancement idea, not a real "issue".
Yeah I was thinking to use instanceof to detect files or filelists (not sure which would be a cleaner api?)
When using redux-form (not the latest version) with <input type="file" {...field} />, I get passed a FileList object (since you can attach multiple files to a file input?). This code shows the response of instanceof:
// filesList comes from redux-form submit
console.log('What are Instances?', filesList instanceof FileList, filesList[0] instanceof File);
// this logs "true true"
I think you can attach multiple files with superagent for a single key like this:
request.post('/url').attach(key, [file1, file2]) where file1 and file2 are File objects
Maybe you can also attach a FileList directly, I don't know?
request.post('/url').attach(key, fileList)
from react-pages.
Ok, I got you, I'll read superagent
docs and will come up with something, maybe next day.
from react-pages.
Sounds good - no rush at all, I'm happily using FormData and things are good. It might also be cool to pipe file upload progress info back into the redux state somewhere so we could show progress bars. Just an idea...
from react-pages.
Implemented in the newest version [email protected]
.
See https://github.com/halt-hammerzeit/react-isomorphic-render#ajax
from react-pages.
Related Issues (20)
- Access store outside React scope HOT 4
- Adding json-ld script tags (dynamic) in SSR pages HOT 1
- Can't add custom handler for `@@react-isomorphic-render/goto` event HOT 4
- Error running npm install HOT 1
- The test is failed. (npm install) HOT 1
- usage directions fail at npm install babel-node HOT 1
- SSR middlewares HOT 2
- react-router problem HOT 7
- Http utility in Server Side HOT 11
- how can i run this site? HOT 8
- How modify @preload {client: true} configuration HOT 5
- How to capture an event type HOT 2
- Crash in long running production process (v 2.0.13) HOT 2
- Module not found: Error: Can't resolve './aboutPageReducer' in ...... HOT 1
- Error instantiating router HOT 5
- No way to detect authentication before using http client HOT 2
- [SSR] Access to the request headers HOT 4
- Enable configuration entry for HTTP `on_before_send` HOT 8
- Invalid Content-Type for get and multipart requests HOT 3
- Moving from isomorphic to website causes render service error HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-pages.