GithubHelp home page GithubHelp logo

Comments (5)

catamphetamine avatar catamphetamine commented on May 28, 2024

Sure, I can add attach option.
Not sure I understood your idea of automatically attaching files: how could it detect files?
Maybe it could do something like if (data[key] instanceof ...)?
Since you already have the code, you can nail it down: instance of what class the file parameter should be.
Or should it detect if the whole data is FormData and then act accordingly?
But as per your first example it already can post FormData without issues.

from react-pages.

adailey14 avatar adailey14 commented on May 28, 2024

Yep using FormData works just fine, just took me some time digging to figure out how to do that. So just an enhancement idea, not a real "issue".

Yeah I was thinking to use instanceof to detect files or filelists (not sure which would be a cleaner api?)

When using redux-form (not the latest version) with <input type="file" {...field} />, I get passed a FileList object (since you can attach multiple files to a file input?). This code shows the response of instanceof:

// filesList comes from redux-form submit
console.log('What are Instances?', filesList instanceof FileList, filesList[0] instanceof File);
// this logs "true true"

I think you can attach multiple files with superagent for a single key like this:
request.post('/url').attach(key, [file1, file2]) where file1 and file2 are File objects
Maybe you can also attach a FileList directly, I don't know?
request.post('/url').attach(key, fileList)

from react-pages.

catamphetamine avatar catamphetamine commented on May 28, 2024

Ok, I got you, I'll read superagent docs and will come up with something, maybe next day.

from react-pages.

adailey14 avatar adailey14 commented on May 28, 2024

Sounds good - no rush at all, I'm happily using FormData and things are good. It might also be cool to pipe file upload progress info back into the redux state somewhere so we could show progress bars. Just an idea...

from react-pages.

catamphetamine avatar catamphetamine commented on May 28, 2024

Implemented in the newest version [email protected].
See https://github.com/halt-hammerzeit/react-isomorphic-render#ajax

from react-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.