Hook to inject render-dependent data for SSR? about react-pages

[catamphetamine]

I didn't understand what you're trying to say here

[catamphetamine]

I think I get what you mean.

https://github.com/halt-hammerzeit/react-isomorphic-render/blob/122c2e82ef9a41ed971cc4f8edc8e7c7e146bf14/source/page-server/render.js#L68-L77
head is evaluated before the page is rendered:
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/e55b9a29effb956f389f961a8b3080bb83448820/source/redux/server/render.js#L76

I could move head evaluation to render_webpage():
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/122c2e82ef9a41ed971cc4f8edc8e7c7e146bf14/source/page-server/render.js#L132
In this case it will be evaluated after the React page has been rendered.

Would that solve this issue.
Or did you choose a different approach.

[benoneal]

Yeah deferring the head evaluation would work great.

[catamphetamine]

Done in 1c2ad46
Install the latest version

[catamphetamine]

All this rewind machinery is not thread safe by the way.
nfl/react-helmet#240
So if using alternative react renderers (like streaming ones) all those "side effects" won't work.

[benoneal]

It seems this still isn't resolved. Looking at the code, it's an easy fix.

https://github.com/halt-hammerzeit/react-isomorphic-render/blob/master/source/page-server/render.js:151

content needs to be resolved at line 125, right before head is executed.

Like this:

render_webpage(content)
{
  ...
  // Normalize `html` parameters
   content = render === false ? normalize_markup(loading) : (content && ReactDOM.renderToString(content))
  head       = normalize_markup(typeof head       === 'function' ? head      (path, parameters) : head)
  ...

  // Render the HTML
  return Html
  ({
    ...parameters,
    extension_javascript: typeof extension_javascript === 'function' ? extension_javascript() : extension_javascript,
    assets,
    locale,
    locale_messages_json: messagesJSON,
    head,
    body_start,
    body_end,
    authentication_token,
    content
  })
}

[catamphetamine]

Yeah, that will do.
Released [email protected]

[benoneal]

That appears to have done the trick 👍