Using react-router-redux about react-pages

[catamphetamine]

  // (optional)
  history:
  {
    // (optional)
    // `history` options (like `basename`)
    options: {}

    // (optional)
    // Custom `history` wrapper, like `syncHistoryWithStore` from `react-router-redux`
    wrap: (history, { store }) => history
  }

[catamphetamine]

If someone wants syncHistoryWithStore then they could try to implement that.

Consider client-side:
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/master/source/redux/client/client.js#L44

There history is created and could be wrapped with syncHistoryWithStore immediately.
But the store is created right after and it currently takes an already created history as an argument.

The store creation function doesn't use the history though so it could be replaced with something like:

const history_holder = {}
function get_history() { return history_holder.history }
const store = create_store(..., get_history, ...)
const history = syncHistoryWithStore(create_history(...))
history_holder.history = history

And also history would get replaced with get_history() in the two middlewares:
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/master/source/redux/middleware/history%20middleware.js
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/master/source/redux/middleware/preloading%20middleware.js

So, wrapping with syncHistoryWithStore could be done (on the client side).

As for the server side, history is created here:
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/master/source/page-server/render.js#L47

Again, the same situation: history is created before the store, and the store creation function is passed the history parameter which it doesn't use immediately so it could be analogously replaced with the same get_history() trick.
After the await redux_initialize call the store is available as parameters.store.

So it seems that the wrapping can be done both on client and server.

So if one forks this project, performs the changes, tests it both with javascript enabled and javascript disabled, and in case that works as intended I would think on a new configuration parameter like history.wrap.

I myself am not using react-router-redux, using @withRouter instead.

[catamphetamine]

I was thinking about making this change.
Have you started already?

[lamyat2005]

Not yet, much appreciated!

[catamphetamine]

Released [email protected].
Didn't check it so you're gonna be the beta-tester.

[lamyat2005]

However one more thing is in order for react-router-redux to work, need to add

import {routerMiddleware} from 'react-router-redux';

const middleware = [
    routerMiddleware(history),
];

applyMiddleware(...middleware)(createStore)(reducers, initialState);

I am not sure in react-isomorphic-render.js

reduxMiddleware: () => [routerMiddleware(history)],

how I can get history? Thanks very much in advance.

[catamphetamine]

How do they pass routerMiddleware(history) to createStore when history itself needs store to be created in the first place as you described in your first post