GithubHelp home page GithubHelp logo

Comments (3)

catamphetamine avatar catamphetamine commented on June 7, 2024 5

Added in [email protected]

from react-pages.

catamphetamine avatar catamphetamine commented on June 7, 2024

According to the code if the response is really a JSON then it's stored inside error.data and is not discarded:

switch (response.type)
{
	// Set error `data` from response body,
	case 'application/json':
		// if (!is_object(error.data))
		error.data = get_response_body(response, parse_json_dates)

		// Set the more meaningful message for the error (if available)
		if (error.data.message)
		{
			error.message = error.data.message
		}

		break
}

// HTTP request failed with an `error`
return reject(error)
const error_data = is_object(error.data) ? error.data : {}

if (!exists(error_data.message))
{
	error_data.message = error.message
}

if (!exists(error_data.status))
{
	error_data.status = error.status
}

// Dispatch the `failure` event to the Redux store
dispatch
({
	...rest,
	error : error_data,
	type  : Failure
})

from react-pages.

smalluban avatar smalluban commented on June 7, 2024

Right, thanks for fast reply. I checked API endpoint and it responses with application/vnd.api+json Content-Type, which is not covered in http client condition. It is a header for JSON API specification.

The problem is that, I really can not force API owner to change content-type header to application/json. It would be great to add this case.

JSON API specifies error handling, so it could be also adopted in http client code (it is nice explained here http://stackoverflow.com/a/43394829).

from react-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.