Comments (3)
Added in [email protected]
from react-pages.
According to the code if the response is really a JSON then it's stored inside error.data
and is not discarded:
switch (response.type)
{
// Set error `data` from response body,
case 'application/json':
// if (!is_object(error.data))
error.data = get_response_body(response, parse_json_dates)
// Set the more meaningful message for the error (if available)
if (error.data.message)
{
error.message = error.data.message
}
break
}
// HTTP request failed with an `error`
return reject(error)
const error_data = is_object(error.data) ? error.data : {}
if (!exists(error_data.message))
{
error_data.message = error.message
}
if (!exists(error_data.status))
{
error_data.status = error.status
}
// Dispatch the `failure` event to the Redux store
dispatch
({
...rest,
error : error_data,
type : Failure
})
from react-pages.
Right, thanks for fast reply. I checked API endpoint and it responses with application/vnd.api+json
Content-Type
, which is not covered in http client condition. It is a header for JSON API specification.
The problem is that, I really can not force API owner to change content-type header to application/json
. It would be great to add this case.
JSON API specifies error handling, so it could be also adopted in http client code (it is nice explained here http://stackoverflow.com/a/43394829).
from react-pages.
Related Issues (20)
- Access store outside React scope HOT 4
- Adding json-ld script tags (dynamic) in SSR pages HOT 1
- Can't add custom handler for `@@react-isomorphic-render/goto` event HOT 4
- Error running npm install HOT 1
- The test is failed. (npm install) HOT 1
- usage directions fail at npm install babel-node HOT 1
- SSR middlewares HOT 2
- react-router problem HOT 7
- Http utility in Server Side HOT 11
- how can i run this site? HOT 8
- How modify @preload {client: true} configuration HOT 5
- How to capture an event type HOT 2
- Crash in long running production process (v 2.0.13) HOT 2
- Module not found: Error: Can't resolve './aboutPageReducer' in ...... HOT 1
- Error instantiating router HOT 5
- No way to detect authentication before using http client HOT 2
- [SSR] Access to the request headers HOT 4
- Enable configuration entry for HTTP `on_before_send` HOT 8
- Invalid Content-Type for get and multipart requests HOT 3
- Moving from isomorphic to website causes render service error HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-pages.