Comments (3)
No
from react-pages.
An explanation for those who come here:
I would rewrite this project in react-router@4
and history@4
but
react-router@4
is a very immature library yet, missing a lot of featuresreact-router@3
had- I don't trust the authors of
react-router
and I'm positive that they aren't competent enough so I'm gonna wait until the community fixesreact-router@4
enough so that it can be used as a substitute forreact-router@3
react-router-scroll
doesn't supportreact-router@4
for the same reasons and since this library usesreact-router-scroll
I'm not gonna rewrite it forreact-router@4
untilreact-router-scroll
supports itreact-router@3
has a bug of not remounting a<Route/>
when a user navigates to another URL. The authors of the library refused to fix that bug for years. I managed to find a fix for that bug and it works but I'm not sure if this fix is gonna work forreact-router@4
(if you think it would then leave a comment here): there's no more customcreateElement
property for a<Route/>
And, there's really no need to use react-router@4
in this project since there're absolutely no features missing in react-router@3
compared to react-router@4
. react-router@3
is a very stable and mature project while react-router@4
is not yet.
And also I don't like the "Everything is a React element" concept of react-router@4
. E.g. why would anyone redirect not via a redirect()
function but rather via first setting a state
variable and then rendering a <Redirect/>
element which isn't really an element and is instead some kind of a hack.
Decentralized routes in react-router@4
is yet another example of an architectural failure.
And the <Route/>
name is wrong and misleading.
It should be something like <Match/>
or <Location/>
.
from react-pages.
Update: migrated the library from react-router@3
to found
.
found
is a better overall architecture.
from react-pages.
Related Issues (20)
- Access store outside React scope HOT 4
- Adding json-ld script tags (dynamic) in SSR pages HOT 1
- Can't add custom handler for `@@react-isomorphic-render/goto` event HOT 4
- Error running npm install HOT 1
- The test is failed. (npm install) HOT 1
- usage directions fail at npm install babel-node HOT 1
- SSR middlewares HOT 2
- react-router problem HOT 7
- Http utility in Server Side HOT 11
- how can i run this site? HOT 8
- How modify @preload {client: true} configuration HOT 5
- How to capture an event type HOT 2
- Crash in long running production process (v 2.0.13) HOT 2
- Module not found: Error: Can't resolve './aboutPageReducer' in ...... HOT 1
- Error instantiating router HOT 5
- No way to detect authentication before using http client HOT 2
- [SSR] Access to the request headers HOT 4
- Enable configuration entry for HTTP `on_before_send` HOT 8
- Invalid Content-Type for get and multipart requests HOT 3
- Moving from isomorphic to website causes render service error HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-pages.