GithubHelp home page GithubHelp logo

Comments (3)

catamphetamine avatar catamphetamine commented on May 28, 2024

No

from react-pages.

catamphetamine avatar catamphetamine commented on May 28, 2024

An explanation for those who come here:

I would rewrite this project in react-router@4 and history@4 but

  • react-router@4 is a very immature library yet, missing a lot of features react-router@3 had
  • I don't trust the authors of react-router and I'm positive that they aren't competent enough so I'm gonna wait until the community fixes react-router@4 enough so that it can be used as a substitute for react-router@3
  • react-router-scroll doesn't support react-router@4 for the same reasons and since this library uses react-router-scroll I'm not gonna rewrite it for react-router@4 until react-router-scroll supports it
  • react-router@3 has a bug of not remounting a <Route/> when a user navigates to another URL. The authors of the library refused to fix that bug for years. I managed to find a fix for that bug and it works but I'm not sure if this fix is gonna work for react-router@4 (if you think it would then leave a comment here): there's no more custom createElement property for a <Route/>

And, there's really no need to use react-router@4 in this project since there're absolutely no features missing in react-router@3 compared to react-router@4. react-router@3 is a very stable and mature project while react-router@4 is not yet.

And also I don't like the "Everything is a React element" concept of react-router@4. E.g. why would anyone redirect not via a redirect() function but rather via first setting a state variable and then rendering a <Redirect/> element which isn't really an element and is instead some kind of a hack.

Decentralized routes in react-router@4 is yet another example of an architectural failure.

And the <Route/> name is wrong and misleading.
It should be something like <Match/> or <Location/>.

from react-pages.

catamphetamine avatar catamphetamine commented on May 28, 2024

Update: migrated the library from react-router@3 to found.
found is a better overall architecture.

from react-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.