GithubHelp home page GithubHelp logo

Comments (6)

catamphetamine avatar catamphetamine commented on May 28, 2024 2

mm, that was a bug.
I fixed it, try the latest version.

And it will be like this now: (new, correct)

export default function(store)

As opposed to this: (old, incorrect)

export default function({ store })

Post back if it works now.
The store is not an actual store, but it has dispatch and getState if that's sufficient

from react-pages.

catamphetamine avatar catamphetamine commented on May 28, 2024

Might as well write it as:

export default function({ dispatch, getState })

from react-pages.

lamyat2005 avatar lamyat2005 commented on May 28, 2024

Thanks.

On my first time call to store.getState() in RequireRole.onEnter, it says
store.js?9b69:92 Uncaught TypeError: Cannot read property 'getState' of undefined

I see store is undefined in first call in the react-isomorphic-render/build/redux/store.js :

getState: function getState() { return store.getState(); }

Have I done something wrong after onEnter? Thanks.

from react-pages.

catamphetamine avatar catamphetamine commented on May 28, 2024

It is undefined the first time because the store is created after the routes are created:

store = createStore(..., routes({ dispatch: (a) => store.dispatch(a), getState: () => store.getState() }))

You shouldn't need the store right away if you're using store in onEnter.

from react-pages.

lamyat2005 avatar lamyat2005 commented on May 28, 2024

I see you have new commits , is it related to the above? Thanks.

from react-pages.

catamphetamine avatar catamphetamine commented on May 28, 2024

Yes, I added an error message so that a user won't be faced with store is undefined.

Does your code work?
Or are you still having issues?

from react-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.