ccsi-toolset / mb_reactor Goto Github PK

The old CCSI license is in the following files:

ACM/Dynamic/Example_flowrate/Moving_Bed_Dynamic_Example.acmf
ACM/Dynamic/Moving_Bed_Dynamic.acmf
ACM/Steady-State/Moving_Bed_SS.acmf

When adding some of the text files to the repository the warning message below came up:

warning: LF will be replaced by CRLF in <filename>.gPJ

The solution was to add .gitattributes in the project root to make sure the Windows EOL characters (CRLF) are preserved.

The question here is: Do we need to do this to make sure these models function on Windows? Who will test this for us?

The Makefile for this project not longer works within this new git structure. It needs to package a new License and used the git tags.

Instead of hardcoding the product version in the Makefile, we should pull version from git tags.

$ git describe --tags
2015.10.00
The suggested change VERSION from a harded coded tag to the following

VERSION := git describe --tags

GhostMouse-Setup.exe was removed from this repository (./test/system_test/automation/Moving Bed/GhostMouse-Setup.exe). This executable seems to be publicly available here and may have been used for testing.

This depedency needs to be documented.