cdent / edit Goto Github PK

when creating a new tiddler, clicking the .privacyicon doesn't do anything anymore

Now that the markdown support on tiddlyspace supports transclusion it makes sense that @edit should notice which markup the container has when extracluding and:

• create the new tiddler with that markup
• write the transclusion with the proper syntax

Somehow I got myself into a situation where every time I open $tiddler for editing, I'm being asked whether I want to restore the existing backup. AFAICT there's no way to fix that (other than hrx0rizing).

If an edit conflict occurs, all input fields are disabled - which means that there's no (simple) way to recover those inputs.

Firefox complains:

The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must to be declared in the document or in the transfer protocol.

So we probably wanna add <meta charset="utf-8"> to the HEAD.

Adding an extra button that can clone the tiddler you want to edit would be useful.

An example use case is loading a tiddler included from another space. The editing pane will be disabled but clicking on the clone button should silently clone the tiddler and enable the editing pane.

such as by clicking the sidebar

I created http://paste.tiddlyspace.com to be used as a public pastebin, to be used without registration.

So I included @edit, set up editedit and ServerSettings and used TiddlyWebCommander to modify the public bag's policy, allowing anonymous read, write and create.

However, @edit insists that anonymous users must not use it: "You are not a member of this space, so cannot edit. Visit the space."

I realize this is not a trivial issue - any ideas?

seems like it should clone or ask

When there is no title, save should be disabled.

A select box should be selected to the current content-type. When creating new, a choice should be possible.

since fcd3b74 (according to @cdent) @edit erroneously adds a custom field "type"

evidence:
http://cdent.tiddlyspace.com/20130429.{txt,json}
http://fnd.tiddlyspace.com/13e41d8fbed.{txt,json}

As described by http://bengillies.tiddlyspace.com/Zen%20Writing%20Mode%20·%20GitHub%20Blog

Given that he's said this would be awesome I reckon it's on @bengillies to make it happen.\

And while he's there he may as well add a little image dropper.

cuz why not?

on a timeout, drop the text to a key

on successful save, delete the key

on load, if the key is there ask if we want to use it

presumably a timestamp ought to be saved too

(yes, I just lost a lot of content because this wasn't there)

$SUBJECT

It's no longer possible to set a new tiddler to private because currentBag is already set.

This is clearly not the desired situation. The guard around the event handler needs to be changed.

The server will respond with a 409 when the resource itself is in conflict, for example when the title is too long. This is not handled in the edit.js code. It does, however, handle 412 (which is a conflict in the headers of the resource).

409 will happen on a tiddler PUT when:

• the target bag does not exist
• the tiddler is "badly formed"
• the tiddler does not pass a validator

The place to fix this is in _saveEdit.

A click should be:

• acknowledge with a change in display
• disabled while the request is pending

The main offender is not being sure if "save" or "save & return" has been clicked, because it can take a while to process.

The SystemSettings tiddler is used by TiddlyWiki to figure out various settings. One of those settings is chkPrivateMode which determines the default public or private state of new tiddlers. We could use this in edit too (and ignore anything else, for now).

However, it might be a bit odd to use a TiddlyWiki thing for a general setting. Perhaps the setting should be somewhere else?

Consider the following scenario: It becomes possible in tiddlyspace to control what is dispalyed at the "write" menu entry in the backstage or /_apps. If that can be edit, edit will get loaded up but without any "new tiddler" button and one will wonder, WTF?

Simplest thing is probably a button that makes the headline editable.

This is presumably an async problem.

• visit /edit#foo (where tiddler "foo" doesn't exist yet)
• switch to private mode by clicking the roundel
• click the roundel to switch back to public mode

the last step does nothing

Lots of features left out

Otherwise, you can't. And that would be lame.

Delete should have a confirmation dialog.

If editedit.js is loaded before status.js this code will fail with the above error.

The check for tiddlyweb should instead check window.tiddlyweb so that it can fail safely.