GithubHelp home page GithubHelp logo

Comments (5)

CDrummond avatar CDrummond commented on August 29, 2024

The only issue with your suggestion is that Material already colours the unused part of the progress. Still, some other method could be used. Is it already implemented in BBC Sounds? If so I'll have a look.

from lms-material.

expectingtofly avatar expectingtofly commented on August 29, 2024

Yes, its in today's release of BBC Sounds 2.35.8.
However, the LMS change for the 'V' tag query was only merged today, so won't be in the nightly build until tomorrow.

from lms-material.

CDrummond avatar CDrummond commented on August 29, 2024

I'm already using LMS from git :)

Initial work in the 830-liveEdge branch. Not too sure on the 3 colour look, not sure if that's confusing or not - so will need to play. Also needs work for coloured toolbars.

from lms-material.

expectingtofly avatar expectingtofly commented on August 29, 2024

I'm already using LMS from git :)

Initial work in the 830-liveEdge branch. Not too sure on the 3 colour look, not sure if that's confusing or not - so will need to play. Also needs work for coloured toolbars.

Wow, that was quick. I like it, it's not confusing for me.

I can see that it's a work in progress, and just the first pass, but just in case you want functional feedback :

  • it's working on pause and seek back for me, and looks good (although the buffer calc is probably not correct).
  • It doesn't show correctly on seek forward again to before the live edge.
  • I don't think the progress bar is working on first start of the live stream.

from lms-material.

expectingtofly avatar expectingtofly commented on August 29, 2024

Actually, buffer calculation (live_edge) is being incorrectly calculated in BBC Sounds. The playingsongelapsed doesn't seem to be being updated in time. I'll get that fixed.

from lms-material.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.