cedarbaum / fugitive-azure-devops.vim

Azure DevOps extension for fugitive.vim

👋 Hi, I am Sam!

I am a full-stack software engineer currently based in New York, NY 🗽

Some things I am working on, ordered by usefulness:

• 🚇 https://closingdoors.nyc/ - a minimalist NYC subway, bus, and PATH schedule viewer
• 🏠 https://www.housecheck.nyc/ - search housing data in NYC
• 🏃 https://www.runstreak.app/ - a web app for tracking run streaks on Strava
• ☁️ https://www.postmodern.cloud/ - a postmodern take on weather forecasts
• 🥤 https://www.dietcoke.reviews/ - reviews of diet coke

fugitive-azure-devops.vim's Issues

Problem with spaces in project name

Space in project name becomes %2520 instead of %20

This plugin also fires for non Azure DEVOPS

This plugin always returns an url for any given file.

You can reproduce this by cloning a remote repository (e.g. from github) and disabling vim-rhubarb. If you try to use
:Gbrowse it tries to open an url without the host information (you can see it in the :messages. You need (at least) return an empty string in azuredevops#homepage_for_remote if the file url does not match (which results in a correct error message from fugitive not finding any matching handler).

Double encoded URLs

Hi!

The plugin is not really working for me, because it appears spaces in the project name are double encoded and end up like %2520.

Backwards incompatible change in URL encoding

After auditing the 8 :GBrowse providers I'm aware of and discovering 7 of them do not handle URL encoding, I've decided that Fugitive should take responsibility for this. Unfortunately this means you drew the short straw. I am recommending this change to compensate:

diff --git i/autoload/azuredevops.vim w/autoload/azuredevops.vim
index cb65262..3b80920 100644
--- i/autoload/azuredevops.vim
+++ w/autoload/azuredevops.vim
@@ -113,7 +113,7 @@ function! s:add_query_param(url, param_name, param_value) abort
   return url_base . query_param
 endfunction
 
-" Snippet from vim-rhubarb (https://github.com/tpope/vim-rhubarb/blob/master/autoload/rhubarb.vim, commit 70713ca)
+" Modified snippet from vim-rhubarb (https://github.com/tpope/vim-rhubarb/blob/master/autoload/rhubarb.vim, commit 70713ca)
 function! s:url_encode(str) abort
-  return substitute(a:str, '[?@=&<>%#/:+[:space:]]', '\=submatch(0)==" "?"+":printf("%%%02X", char2nr(submatch(0)))', 'g')
+  return substitute(substitute(a:str, '[?@=&<>#/:+[:space:]]\|%\%(\x\x\)\@!', '\=printf("%%%02X", char2nr(submatch(0)))', 'g'), '%20', '+', 'g')
 endfunction

This will continue to work on older versions of Fugitive too, except when the filename or commit contains a valid %AB URL escape. This was previously broken on the other seven providers, and nobody seemed to notice, so I doubt they are very common in practice.