centralnicgroup-opensource / rtldev-middleware-whmcs

CentralNic's WHMCS Software Bundle

WHMCS "CNIC" Software Bundle

This codebase addresses the WHMCS Software Bundle provided by Team Internet Group PLC. To access the ZIP archive with the latest release version, click here.

Within this bundle, we've included:

• The ISPAPI Registrar Module (our widgets integrated)
• The CNR (fka. RRPproxy) Registrar Module
• The CNIC Domain Search
• The CNIC DNS Templating Addon
• The CNIC SSL Cert Addon
• The CNIC Domain Importer Addon
• The CNIC Domain Migrator Addon
• The CNIC Domain Monitoring Addon

Resources

• Documentation:
  • HEXONET
  • CentralNic Reseller
• Release Notes

Authors

• Kai Schwarz - Team Lead - KaiSchwarz-cnic
• Asif Nawaz - developer - AsifNawaz-cnic
• Sebastian Vassiliou - developer - SebastianVassiliou-cnic

Former Developers:

• Zoltan Egresi [RRPproxy] - ZoltanEgresi-cnic
• Pavel Ciocan [IBS] - PavelCiocan-cnic
• Anthony Schneider [HEXONET] - AnthonySchneider-cnic
• Tulasi Seelamkurthi [HEXONET] - Tulsi91

License

Except the IBS Registrar Module and the TPP Wholesale Registrar module, all our code is closed source. Using these encrypted Addons is allowed. Any actions in direction of unencrypting / reverse engineering et al to gain knowledge of how these encrypted modules work are disallowed.

Means for IBS and TPPW, the modules are released under the MIT License - see the LICENSE file for details.

Team Internet Group PLC

rtldev-middleware-whmcs's Issues

Run Registrar TLD Sync but no result

Hi,

I try to run Registrar TLD Sync and it shows

Fetching TLDs and pricing information. This may take up to a minute. Please wait...

Then the text disappears and no result shown on the page

WHMCS version: 8.1
PHP: 7.4

Registrar lock for .se not updating in WHMCS

When a client or admin enables registrar lock for .se domains, the page refreshes and doesn't show the updated value.
According to the wiki, the .se TLD doesn't support Transfer Lock.
If that's the case, maybe the option should be disabled for .se domains in WHMCS to avoid confusion?

When trying to disable the registrar lock (it's enabled somehow) from the Hexonet control panel, I get this error:

[COMMAND]
COMMAND = MODIFYDOMAIN
DELSTATUS0 = clientTransferProhibited
DOMAIN = domain.se
EOF

[RESPONSE]
CODE = 541
DESCRIPTION = Parameter value range error; Currently only clientHold is supported
EOF

could not get default transfer period ()

Describe the bug
Module is working without Problems. But when it comes to those Authcodes like in my Screenshot. It comes to this output: "An Error Occurred Invalid attribute value; could not get default transfer period ()".
Domain Transfer over the Hexonet Dashboard was working.

To Reproduce
Steps to reproduce the behavior:
Domain Transfer

Expected behavior
Domain Transfer not working over WHMCS

Screenshots

Context (please complete the following information):

• Device: MAC, Safari 12
• OS: MacOS
• Browser Safari 12
• WHMCS Version 7.5.2
• PHP Version 7.2.x
• ISPAPI Registrar Module Version [e.g. v1.6.0] 1.6.1

HK domains transfer problem

Transfer of HK domains is not working, always got error "Invalid Parameter: X-HK-ACCEPT-INDIVIDUAL-REGISTRATION-TAC" when accepting order, and it doesn't matter if the field Terms for Individuals is checked or not, always is same error.
As i readed at your wiki page for HK domains, additional fields is not needed when transferring domains, but as i see in WHMCS log all of them is posted. Maybe problem in that? Unfortunately i cant fix it myself as your code is encrypted.

• WHMCS Version [8.1.3]
• ISPAPI Registrar Module Version [6.1.2]

array_map(): Expected parameter 2 to be an array, null given

whmcs v8.1.3
php 7.4

modules/registrars/ispapi/lib/Helper.php on line 53:
array_map(): Expected parameter 2 to be an array, null given

X-NICSE-IDNUMBER not required

Same issue as in this issue: #200

Client can register a .se domain without entering the ID number. Would be great if that field could be required :-)

/includes/hooks/ispapi_transliteration.php:74 - Invalid argument supplied for foreach()

Describe the bug
we have the log full of this items:

array (
 'type' => 2,
 'message' => 'Invalid argument supplied for foreach()',
 'file' => '/home/<OMISSIS>/includes/hooks/ispapi_transliteration.php',
 'line' => 74,
)

GET: array (
 'action' => 'productdetails',
 'id' => '<OMISSIS>',
)

To Reproduce
Steps to reproduce the behavior:

1. Go to a product details page of WHMCS
2. wait for it

Expected behavior
no errors

Context (please complete the following information):
Device: server / docker (tried on several devices)
OS: Centos 7 / Cloud Linux / Docker
Browser Any
WHMCS Version 8.0.5
PHP Version 7.3.27
ISPAPI Registrar Module Version 6.2.6

[.ngo] Invalid Parameter: X-NGO-ACCEPT-REGISTRATION-TAC

NGO domain transfer

Error:

Error: Invalid Parameter: X-NGO-ACCEPT-REGISTRATION-TAC

Request:

COMMAND = TransferDomain
DOMAIN = *****.ngo
PERIOD = 1
NAMESERVER0 = dns1.netsons.net
NAMESERVER1 = dns2.netsons.net
NAMESERVER2 = dns3.netsons.net
NAMESERVER3 = dns4.netsons.net
NAMESERVER4 = 
AUTH = *********
X-NGO-ACCEPT-REGISTRATION-TAC = 0

WHMCS Custom Fields:

WHMCS v8.0.5
ISPAPI v6.6.0

error in expiring date update in domainsync for .EU domains

Bug description
For a number of different TLDs (mostly important .eu). domainsync updates wrongly expire date, using (instead of domain expire date) the Hexonet "accounting date"

Real example:
Example: domain meetyouzone . eu
Registered (by way of WHMCS) 06/12/18
Expire date (amongst the Registry): 6/12/19
Expire date (rightly set in WHMCS at the moment of registration) 6/12/19
Next due date: 6/12/19

When happens that domainsync is run about this domain, "Expiry date" is changed automatically to 29/11/19
So, next year will happen that the user will be alerted that he needs to renew the domain before 6/12/19, but if he log-in after 29/11/19 he'll find the domain in "redemption mode" and so will no be able to do an ordinary renew (but the domain will be still regularly active)

Expected behavior
Domainsync is required to set as expire date the real expire date, not accounting date

Add language files to the repo

This is not a bug, it's more of a request.
We have our own "overrides" with tons of changes. It would be a lot easier to keep the Hexonet language strings updated if we were able to track changes.

As it is now, we have to compare files to see what has been changed 😄

Make fields required for .IT

I know you are busy with the on-going DDoS attack at the moment. It really sucks, and I hope you get through this.

Once there's some spare time, it would be nice to have the required fields for .it actually be required when ordering a .it domain through WHMCS. As per your documentation, these fields are required:

X-IT-ACCEPT-LIABILITY-TAC = 0 | 1  - accepts "Section 3 - Declarations and assumptions of liability"
X-IT-ACCEPT-DIFFUSION-AND-ACCESSIBILITY-TAC = 0 | 1 - accepts - "Section 6 - Consent to the processing of personal data for diffusion and accessibility via the internet"
X-IT-ACCEPT-EXPLICIT-TAC = 0 | 1 - accepts "Section 7 - Explicit acceptance of the following points"
X-IT-PIN = <TEXT> (max. 255 chars) - further information below

For individiuals in Europe, would a social security number be okay for X-IT-PIN?
Thanks :-)

Error after upgrading

After trying to upgrade from 4.5.2 to the latest version (4.9.3 as of now) I get this error when loading the Domain Registrars page in WHMCS: https://cln.sh/tJrIQJ

My way of upgrading is deleting the old "ispapi" directory and uploading the new one. I have tried both disabling and not disabling the module before doing so. Both ways will give the error in the screenshot.
Am I doing something wrong?

Deleting the "ispapi" directory and uploading 4.5.2 fixes it.

I'm running the latest WHMCS version which is currently 8.1.3

"mailto:" not set upon .de registrations

In regards to X-DE-GENERAL-REQUEST and X-DE-ABUSE-CONTACT send along with a .de domain registration, the mailto: protocol is not set when a client inserts hes/hers email address. The following error is returned.

Command failed; Could not create handle for X-DE-GENERAL-REQUEST (Command failed; 83000000005 Validation of URI Template failed [no protocol: [email protected]])

It would easen the procedure if the module recognised the input as an email address and automatically set the mailto: protocol on behalf of the client.

Transliteration hook doesn't work with registrations ?

For years we had a transliteration hook (in includes/hooks/) running with another provider. We had a function to
change from Greek to Greeklish beased on the Greeklish ISO ( https://en.wikipedia.org/wiki/ISO_843 )

https://docs.whmcs.com/Custom_Transliteration

Switching from them to hexonet, with the migration hook/plugin everything is fine. Transfers too.

But with ispapi for registrations and registrations only, this hook stopped / or the plugin ignores it ? I don't know.
Hexonet doesn't accept Greek characters and I am getting errors like:
Invalid attribute value; INVALID CONTACT [OWNERCONTACT (Invalid attribute value; Invalid char in NAME [Α])]
For contact name, city, address, and so on.
The "A" it's just the first Greek character of the full name.

WHMCS ispapi registrar module missing from the "Hexonet Modules" tile in WHMCS

In WHMCS on the front page, there is a HEXONET Modules tile, displaying the modules installed, in my case the Domain Checker module, Pricing importer module and then the Registrar module. But after update 3.0.3 the registrar module is missing from that view.

Steps to reproduce the behavior:

1. I downloaded version 3.0.3 (whmcs-ispapi-registrar-3.0.3) from github.
2. Uploaded it to the FTP so the files were under modules as they should be.
   The registrar module is active and working, its just missing in the admin dashboard HEXONET modules tile. This is basically only used to see when a new version is available.

Expected behavior
That it would show up under HEXONET Modules with ISPAPI Registrar Module v3.0.3.

Screenshots

Context (please complete the following information):

• Device: PC
• OS: Windows 10 (1909)
• Browser Chrome (Version 81.0.4044.122 (Official Build) (64-bit))
• WHMCS Version 7.8.3
• PHP Version 7.0.24
• ISPAPI Registrar Module Version v3.0.3

No price for .pe .ae and .qa

Seems the currency exchange rate for .pe .ae and .qa is missing, the pricing is 0.00 when import these extensions using
ISPAPI Pricing Importer

Version number not changed since 3.0.5

Minor bug. The version number has not been changed since 3.0.5.

Transfersync failing

I updated to the latest version today.
The domainsync doesn't work anymore since I updated.

Failure-Message:
[WHMCS Application] ERROR: Error: Object of class WHMCS\Domains\Domain could not be converted to string in /MYPATHTOWHMCS/modules/registrars/ispapi/lib/sdk/src/APIClient.php:406 Stack trace: #0 /MYPATHTOWHMCS/modules/registrars/ispapi/lib/sdk/src/APIClient.php(406): preg_replace() #1 /MYPATHTOWHMCS/modules/registrars/ispapi/lib/sdk/src/APIClient.php(472): HEXONET\APIClient->flattenCommand() #2 /MYPATHTOWHMCS/modules/registrars/ispapi/lib/Ispapi.php(416): HEXONET\APIClient->request() #3 /MYPATHTOWHMCS/modules/registrars/ispapi/lib/DomainTransfer.php(76): WHMCS\Module\Registrar\Ispapi\Ispapi::call() #4 /MYPATHTOWHMCS/modules/registrars/ispapi/ispapi.php(3109): WHMCS\Module\Registrar\Ispapi\DomainTransfer::getSuccessLog() #5 /MYPATHTOWHMCS/vendor/whmcs/whmcs-foundation/lib/Module/AbstractModule.php(0): ispapi_TransferSync() #6 /MYPATHTOWHMCS/vendor/whmcs/whmcs-foundation/lib/Module/Registrar.php(0): WHMCS\Module\AbstractModule->call() #7 /MYPATHTOWHMCS/vendor/whmcs/whmcs-foundation/lib/Cron/Task/DomainTransferSync.php(0): WHMCS\Module\Registrar->call() #8 /MYPATHTOWHMCS/vendor/whmcs/whmcs-foundation/lib/Scheduling/Task/AbstractTask.php(0): WHMCS\Cron\Task\DomainTransferSync->__invoke() #9 /MYPATHTOWHMCS/vendor/whmcs/whmcs-foundation/lib/Scheduling/Task/AbstractTask.php(0): WHMCS\Scheduling\Task\AbstractTask->execute() #10 /MYPATHTOWHMCS/vendor/whmcs/whmcs-foundation/lib/Cron/Console/Command/AbstractCronCommand.php(0): WHMCS\Scheduling\Task\AbstractTask->run() #11 /MYPATHTOWHMCS/vendor/whmcs/whmcs-foundation/lib/Cron/Console/Command/AbstractCronCommand.php(0): WHMCS\Cron\Console\Command\AbstractCronCommand->executeCollection() #12 /MYPATHTOWHMCS/vendor/symfony/console/Command/Command.php(255): WHMCS\Cron\Console\Command\AbstractCronCommand->execute() #13 /MYPATHTOWHMCS/vendor/symfony/console/Application.php(912): Symfony\Component\Console\Command\Command->run() #14 /MYPATHTOWHMCS/vendor/symfony/console/Application.php(264): Symfony\Component\Console\Application->doRunCommand() #15 /MYPATHTOWHMCS/vendor/symfony/console/Application.php(140): Symfony\Component\Console\Application->doRun() #16 /MYPATHTOWHMCS/crons123456/cron.php(0): Symfony\Component\Console\Application->run() #17 {main} {"exception":"[object] (Error(code: 0): Object of class WHMCS\Domains\Domain could not be converted to string at /MYPATHTOWHMCS/modules/registrars/ispapi/lib/sdk/src/APIClient.php:406)"} []

Can't login using SSL

I've the newest version installed, but after checking the SSL checkbox the connection can't be established. Without the checkbox it works without any problems.

Auto registration

Is there an active problem with auto registration of domains?

Since many versions of this plugin (we are currently using 7.0.0) we havn't been able to have any domains do auto registration after first payment.
Our regular web hosting products do it just fine, but not domains, despite having selected "lspapi" under the Auto Registration tab as seen here: https://cln.sh/o5sVt5

Syntax error in Parameter X-ES-REGISTRANT-TIPO-IDENTIFICACION

Describe the bug
We see this error when try to register .es domain:

Domain Registration Failed - Domain ID: **** - Domain: *******.es - Error: Syntax error in Parameter X-ES-REGISTRANT-TIPO-IDENTIFICACION (Otra; For non-spanish owner)

Currently .es additonal domain fields:

$additionaldomainfields[".es"][] = array(
                 "Name" => "Registrant Type",
                 "Type" => "dropdown",
         "Options" => ",Otra; For non-spanish owner,NIF/NIE; For Spanish Individual or Organization,Alien registration card",
                 "Required" => true,
                 "Ispapi-Name" => "X-ES-REGISTRANT-TIPO-IDENTIFICACION",
                 "Ispapi-Options" => ",0,1,3",
);

EDIT: Domain was manually registered on Hexonet portal with same data.

To Reproduce
Steps to reproduce the behavior:

1. Register .es domain with Registrant Type: Otra

Expected behavior
Domain registration

Screenshots

Context (please complete the following information):

• WHMCS Version [8.0.5]
• PHP Version [7.3]
• ISPAPI Registrar Module Version [6.4.3]

Menu Entries "Nameservers" / "Registrar Lock" missing / "Registrar Lock" Status wrong / localAPI DomainGetNameservers & DomainGetLockingStatus unusable

It seems like it's no longer possible for clients to get/set the domain's nameservers.
Is this a bug or have I missed something? :-)

Invalid REGEX causing incorrect domain matching

Describe the bug
Regex used to hide firstname/lastname/org field on GetContactDetails is incorrect.

/[.]ca|it|ch|li|se|sg$/i -- This matches any domains which contain "ch" for example, so "church.org" is incorrectly matched to what should be a string ending in ".ch"

Due to this issue with GetContactDetails, SaveContactDetails ALSO fails due to missing data because the Registrant/OWNERCONTACT0 is not loaded as this code checks if the "First Name" element exists before using the _POST data so ignores the Registrant data provided and fails.

To Reproduce

1. Click modify domain from whmcs on any domain which ISN'T one of the intended extensions
2. Observe lack of fields.

Expected behavior
Regex/logic should only match against domain strings ENDING IN ".tld"

outdated / missing image

WHMCS broken after Upgrade to latest version

Describe the bug
I've got version ISPAPI v2.2.2 installed and would like to upgrade to the latest versions. Doing so by replacing the files using FTP, WHMCS its main admin home panel breaks, and also the domain registrars page breaks.

The highest working upgrade I can do is v3.0.6, after this, it all failed.

Screenshots
See screenshot of the domain registrars page

Disconnected (Verify Username and Password) 530 Authentication failed; OTP

We have enabled 2FA for both OT&E and Production. Now we are receiving this unexpected error. Has this been tested or are we missing something? It is a critical issue and it is the only thing right now that is keeping us from production. Contacted support and they still have not responded. Thank you.

Note: We have already updated the ISPAPI registrar module to the latest version from git.

Registrar Lock always enabled

Describe the bug
"Registrar Lock" can't be disabled in WHMCS. When you disabled it, the lock is activated again once the page has refreshed. Module log says that the command was executed successfully. It seems like WHMCS sees registrar lock as being enabled for all domains.

We've tested this across 2 WHMCS installations which uses two different Hexonet accounts.

To Reproduce
Steps to reproduce the behavior:

1. Access a domain in WHMCS
2. See that "Registrar Lock" is already enabled
3. Uncheck it
4. See that it's checked again after page refresh

Expected behavior
When toggling registrar lock, it's expected to deactivate if activated and vice-versa

Screenshots
If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

• Device: Desktop
• OS: Windows 10
• Browser: Latest Firefox
• WHMCS Versio:n 8.1.3
• PHP Version: 7.4
• ISPAPI Registrar Module Version: 4.7.0

Disable auto renew from admin interface doesn't cancel the invoice

Describe the bug
Disabling auto-renew from WHMCS admin doesn't cancel active invoice.

To Reproduce
Steps to reproduce the behavior:

1. Make sure there's an active invoice for the domain
2. Disable automatic renewal for the domain from the admin interface
3. Invoice is still active

Expected behavior
When the client disables auto renew from the client area, the invoice is cancelled. If the domain renewal is part of an invoice with multiple items, the domain item is removed from the invoice.

Unfortunately, we've just handed our client a free renewal because of this - I was not aware that WHMCS doesn't automatically cancel invoices when auto renew is disabled from the admin interface. I'm not surprised, though 😅
Would it be possible to work around this somehow?

Domain Transfers and Name Servers

During a Domain Transfer order within WHMCS is it possible to query the name servers of the domain to be transferred and use those instead of the default?

Something else to note, when using additional fields, they're present on the registration and transfer order pages. But sometimes these fields are only required for the registration of a domain not a transfer.

Cannot disable domain suggestions

Ok for starters: I'm sure I must be doing something wrong but would like to have your idea's. I'm using WHMCS 7.10.3 and the newest release of the ispapi plugin.

Currently I have configured some TLD's to show on the domainchecker in the shoppingcart (domain=register page) under Product/Services > Domain pricing > Lookup provider (please see screenshot attached).

In this configuration, no extra TLD's are suggested in the shopping cart. The section (div class="suggested domains") is not being displayed as in hidden in the template. However when I enable "Suggestion Engine based on search term" not only extra TLD's are suggested, but also totally other domains. These suggestions are usually crap (nofi) and I only want to suggest other TLD's based on the same domain, not other domains.

It was my understanding that deselecting this option prevents the plugin from searching other domains (and instead only displays other TLD's), but maybe I have configured something wrong?

Could use some help!

2FA login option

Hello,

I can't use the module with 2FA enabled on hexonet.

We could implement authentication using API?

Error after update 4.5.3 => 5.1.1

After update from 4.5.3 => 5.1.1, I'm getting following error accessing to /admin/configregistrars.php :

Error: Error: Call to undefined method WHMCS\Module\Registrar\Ispapi\Ispapi::checkAuth() in /var/www/domainregister.international/public_html/modules/registrars/ispapi/ispapi.php:792 Stack trace: #0 /var/www/domainregister.international/public_html/vendor/whmcs/whmcs-foundation/lib/Module/AbstractModule.php(0): ispapi_getConfigArray(Array) #1 /var/www/domainregister.international/public_html/vendor/whmcs/whmcs-foundation/lib/Module/Registrar.php(0): WHMCS\Module\AbstractModule->call('getConfigArray', Array) #2 /var/www/domainregister.international/public_html/admin/configregistrars.php(0): WHMCS\Module\Registrar->call('getConfigArray') #3 {main}

WHMCS 7.10.2
PHP 7.2.34

(after rolling back to 4.5.3 everything is fine)

Domain lock/unlock error

Can not modify domain lock . got error :
Registrar Lock Failed
Not supported by this TLD

A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to domain page in whmcs (or admin panel)
2. Try to lock/unlock domain (.com/.net)
3. See error

Expected behavior
domain lock should be enabled/disabled . it is possible in hexonet panel.

Context (please complete the following information):

• WHMCS Version [e.g. 7.3.0 ]
• PHP Version 7.0
• ISPAPI Registrar Module Version: 1.8.1

.ro Domain Transfer Failed

Describe the bug
Unable to transfer .ro domain using Hexonet Registrar module

Domain Transfer Failed - Domain ID: 000000 - Domain: example.ro - Error: Invalid attribute value; INVALID CONTACT [OWNERCONTACT (Required parameter missing; Prohibited parameter or attribute value (VATID is mandatory))]

To Reproduce
Steps to reproduce the behavior:

1. Go to whmcs
2. Do transfer procedure for a registered .ro domain
3. Click transfer on admin area domain page
4. See error

Expected behavior
Domain transfer successful

Modulelog:
Request:

COMMAND = TransferDomain
DOMAIN = example.ro
PERIOD = 0
NAMESERVER0 = dns1.***************
NAMESERVER1 = dns2.***************
NAMESERVER2 = dns3.***************
NAMESERVER3 = dns4.***************
NAMESERVER4 = 
OWNERCONTACT0FIRSTNAME =  ***************
OWNERCONTACT0LASTNAME =  ***************
OWNERCONTACT0ORGANIZATION =  ***************
OWNERCONTACT0STREET =  ***************
OWNERCONTACT0CITY =  ***************
OWNERCONTACT0STATE =  ***************
OWNERCONTACT0ZIP =  ***************
OWNERCONTACT0COUNTRY =  ***************
OWNERCONTACT0PHONE =  ***************
OWNERCONTACT0EMAIL =  ***************
ADMINCONTACT0FIRSTNAME =  ***************
ADMINCONTACT0LASTNAME =  ***************
ADMINCONTACT0ORGANIZATION =  ***************
ADMINCONTACT0STREET =  ***************
ADMINCONTACT0CITY =  ***************
ADMINCONTACT0STATE =  ***************
ADMINCONTACT0ZIP =  ***************
ADMINCONTACT0COUNTRY =  ***************
ADMINCONTACT0PHONE =  ***************
ADMINCONTACT0EMAIL =  ***************
TECHCONTACT0FIRSTNAME =  ***************
TECHCONTACT0LASTNAME =  ***************
TECHCONTACT0ORGANIZATION =  ***************
TECHCONTACT0STREET =  ***************
TECHCONTACT0CITY =  ***************
TECHCONTACT0STATE =  ***************
TECHCONTACT0ZIP =  ***************
TECHCONTACT0COUNTRY = ***************
TECHCONTACT0PHONE = ***************
TECHCONTACT0EMAIL = ***************
BILLINGCONTACT0FIRSTNAME = *******
BILLINGCONTACT0LASTNAME = *******
BILLINGCONTACT0ORGANIZATION = ********************
BILLINGCONTACT0STREET = *************
BILLINGCONTACT0CITY = *******
BILLINGCONTACT0STATE = **
BILLINGCONTACT0ZIP = ******
BILLINGCONTACT0COUNTRY = **
BILLINGCONTACT0PHONE = ***********
BILLINGCONTACT0EMAIL = **************
AUTH = **************

On these request I don't see any .ro custom field (X-REGISTRANT-IDNUMBER, X-REGISTRANT-VATID) is a correct behavior?

Context:

• OS: Centos 7
• Browser: N/A
• WHMCS Version 8.0.5
• PHP Version: 7.3
• ISPAPI Registrar Module Version: v5.1.11

WHMCS hanging during Maintenance Activity (-> DDoS Attack)

My own WHMCS install get hanging without any reason (even impossible to login in admin or client area)

Thinking at this communication from Hexonet:
`SERVICE NOTICE: Scheduled Production Maintenance HEXONET [STARTED]

ID: 3398
Type: Scheduled Production Maintenance
Origin: HEXONET
Planned Start Date: 2021-09-01 13:28:00 UTC
Planned End Date: 2021-09-01 20:00:00 UTC
Implications: Restricted Functionality
Affected Environments: Production Environment`
I disabled ISPAPI module by FTP, and my WHMCS woke up again...

test123

test

Missing required attribute; VATID REQUIRED FOR ORGANIZATION

We are trying to get this module working with our WHMCS for over a month now. The VAT ID was missing initially, but we were finally able to get that added to our account yesterday.

We can confirm that we have the correct VAT ID in our account. But we're still seeing this error when we try to accept an order. The error is as below,
https://gyazo.com/60119f749f34253ad4975113bcdf7fb7

We're running WHMCS 7.7.1 on PHP 7.2

Thanks!

Could not create handle for X-DE-GENERAL-REQUEST

Describe the bug
.de domain without compiling X-DE-GENERAL-REQUEST field.

Error: Command failed; Could not create handle for X-DE-GENERAL-REQUEST (Command failed; 83000000005 Validation of URI Template failed [empty URI template])

Request

COMMAND = AddDomain
DOMAIN = *******.de
PERIOD = 1
NAMESERVER0 = dns1.netsons.net
NAMESERVER1 = dns2.netsons.net
NAMESERVER2 = dns3.netsons.net
NAMESERVER3 = dns4.netsons.net
NAMESERVER4 = 
OWNERCONTACT0FIRSTNAME = *****
OWNERCONTACT0LASTNAME = ******
OWNERCONTACT0ORGANIZATION = 
OWNERCONTACT0STREET = *******
OWNERCONTACT0CITY = ******
OWNERCONTACT0STATE = ******
OWNERCONTACT0ZIP = ******
OWNERCONTACT0COUNTRY = ******
OWNERCONTACT0PHONE = ******
OWNERCONTACT0EMAIL = ******
ADMINCONTACT0FIRSTNAME = ******
ADMINCONTACT0LASTNAME = ******
ADMINCONTACT0ORGANIZATION = 
ADMINCONTACT0STREET = ******
ADMINCONTACT0CITY = ******
ADMINCONTACT0STATE = ******
ADMINCONTACT0ZIP = ******
ADMINCONTACT0COUNTRY = ******
ADMINCONTACT0PHONE = ******
ADMINCONTACT0EMAIL = ******
TECHCONTACT0FIRSTNAME = ******
TECHCONTACT0LASTNAME = ******
TECHCONTACT0ORGANIZATION = 
TECHCONTACT0STREET = ******
TECHCONTACT0CITY = ******
TECHCONTACT0STATE = ******
TECHCONTACT0ZIP = ******
TECHCONTACT0COUNTRY = ******
TECHCONTACT0PHONE = ******
TECHCONTACT0EMAIL = ******
BILLINGCONTACT0FIRSTNAME = ******
BILLINGCONTACT0LASTNAME = ******
BILLINGCONTACT0ORGANIZATION = 
BILLINGCONTACT0STREET = ******
BILLINGCONTACT0CITY = ******
BILLINGCONTACT0STATE = ******
BILLINGCONTACT0ZIP = ******
BILLINGCONTACT0COUNTRY = ******
BILLINGCONTACT0PHONE = ******
BILLINGCONTACT0EMAIL = ******
X-DE-GENERAL-REQUEST = 
X-DE-ABUSE-CONTACT = 
X-DE-ACCEPT-TRUSTEE-TAC = 

As I can read from Hexonet docs: https://wiki.hexonet.net/wiki/DE

If not specified a default will be set which is https://send-message.ispapi.net/domain/owner for the general request contact and mailto:[email protected] for the abuse contact.

To Reproduce
Steps to reproduce the behavior:

1. Register .de domain with empty: General Request Contact, Abuse Team Contact and Local Presence

Expected behavior
Domain registration

Context (please complete the following information):

• WHMCS Version [8.0.5]
• PHP Version [7.3]
• ISPAPI Registrar Module Version [v6.2.7]

X-ACCEPT-WHOISTRUSTEE-TAC not supported

When trying to register .de domains from WHMCS, the registration fails with this error:
Invalid attribute value; X-ACCEPT-WHOISTRUSTEE-TAC not supported

ID protection was enabled, so I tried disabling it - but that's not possible, it seems. After WHMCS reloads the page, it's enabled again.

Additional Domain Fields not saved

Describe the bug
Saving X-REGISTRANT-IDNUMBER for an individual (either as 123456-7890 or 1234567890) does not save the value. The value is cleared after WHMCS reloads.
I've tested this in WHMCS admin.

To Reproduce
Steps to reproduce the behavior:

1. Go to client's domain page in WHMCS
2. Set a value for X-REGISTRANT-IDNUMBER
3. Save the changes
4. See that no changes has been saved

Expected behavior
X-REGISTRANT-IDNUMBER should have been saved.

Context (please complete the following information):

• Device: Desktop
• OS: Windows 10
• Browser: Latest Firefox, Latest Chrome, Latest Edge
• WHMCS Version: 8.2.1
• PHP Version: 7.4
• ISPAPI Registrar Module Version: 6.1.0

Resend verification email command from whmcs

Please consider adding the ability to resend the registrant verification email to the registrant from within whmcs, either as a button from the domain's menu under registrar commands and or an option available from the client facing section of whmcs.

Possible missing fields for .FR

When registering a .FR domain as an individual, the registration fails with the following error:

Invalid attribute value; INVALID CONTACT [OWNERCONTACT (Missing required attribute; extended parameters for registrant (organization) required)]

Our client has only specified "Individual" for the "Legal Type" field as the rest of the fields are only for companies or French associations.

According to the documentation, you will need these fields in case you are an individual, though:

1. Individual:
If you are an individual, you may state the following parameters:

X-FR-REGISTRANT-BIRTH-DATE = (DATE) - The registrant's date of birth in the form YYYY-MM-DD<br>
X-FR-REGISTRANT-BIRTH-PLACE = (TEXT) (max. 255 chars) - The registrant's place of birth

I don't see anywhere to enter those fields during ordering.

Message shown when accessing "Addon Modules"

Somehow, we can no longer access Setup > Addon Modules in WHMCS. It has happened sometime after installing the latest update (not completely sure if it's caused by the update).
I just see the following message: Please install our ISPAPI Registrar Module >= v1.7.1

We're already using the latest version.

clientareadomaindns.tpl is missing quotations

Describe the bug
The twenty-one version of your clientareadomaindns.tpl is missing quotations
on line 44, 65

also lang key="domainDns.srv does not appear to be defined.

X-REGISTRANT-IDNUMBER not required

It seems that clients are able to configure .nu domains without setting a value for X-REGISTRANT-IDNUMBER. Shouldn't this be a required field?

Pending premium domain is being set as `expired` after refreshing domain tab

Pending premium domain is being set as expired after refreshing domain tab

WHMCS 8.0

Customer buys a domain. The domain appears to be premium The registration has been blocked and the domain is in pending.

An admin open the domain tab. The domain is still in Pending. The admin "refreshes" the page, the domain is set expired.

To Reproduce
Steps to reproduce the behavior:

1. buy and pay a premium domain
2. the domain is in pending due to the premium state
3. an admin open the domain tab
4. in the database the status field of the domain has been set Expired

Expected behavior
As WHMCS Admin user, I expect the domain to keep the Pending status.

Screenshots

Context (please complete the following information):

• WHMCS Version 8.0.5
• PHP Version 7.3.27
• ISPAPI Registrar Module Version 5.1.7

Enhancement: Display the source IP when displaying a connection error

We set up an IP restriction on the user which connects to Hexonet and we found that if we put in an IP that does not match that of the WHMCS installation, it simply fails with an authentication error (displayed by the ispapi module in WHMCS). Instead, it should tell the administrator what the source IP address is and that is failed because the IP address was not whitelisted. Much appreciated. Thank you.

Class 'WHMCS\Module\Registrar\Ispapi\DB' not found

Describe the bug
When I try to open a domain tab in client profile, I get an oops: "Class 'WHMCS\Module\Registrar\Ispapi\DB' not found in ..modules/registrars/ispapi/lib/Domain.php:102"

To Reproduce
Steps to reproduce the behavior:

1. WHMCS 8.0.5
2. install Hexonet ISPAPI 5.1.5
3. configure test endpoint for hexonet
4. open a domain tab with Ispapi registrar
5. you got an Oops from WHMCS

Expected behavior
No error

Screenshots

Context (please complete the following information):

• Device: server / docker (tried on several devices)
• OS: Centos 7 / Cloud Linux / Docker
• Browser Any
• WHMCS Version 8.0.5
• PHP Version 7.3.27
• ISPAPI Registrar Module Version 5.1.5

Pending premium domain is being set as `expired` after setting it as `Cancelled`

Pending premium domain is being set as expired after setting as Cancelled

similar #192

WHMCS 8.0

Customer buys a domain. The domain appears to be premium The registration has been blocked and the domain is in pending.

An admin open the domain tab. The domain is still in Pending. The admin set the domain status Cancelled. The admin refresh the page, the domain is set expired.

To Reproduce
Steps to reproduce the behavior:

1. buy and pay a premium domain
2. the domain is in pending due to the premium state
3. an admin open the domain tab
4. the admin save the domain with status Cancelled
5. in the database the status field of the domain has been set Expired

Expected behavior
As WHMCS Admin user, I expect the domain to keep the Cancelled status.

Context (please complete the following information):

• WHMCS Version 8.0.5
• PHP Version 7.3.27
• ISPAPI Registrar Module Version 6.4.1

adding images