cfpb / ccdb5-ui Goto Github PK
View Code? Open in Web Editor NEWHome Page: https://www.consumerfinance.gov/data-research/consumer-complaints/search/
License: Creative Commons Zero v1.0 Universal
Home Page: https://www.consumerfinance.gov/data-research/consumer-complaints/search/
License: Creative Commons Zero v1.0 Universal
Type-ahead previews are currently showing strange text when advanced search wildcards are used. Likely an issue with normalizing to .toLowercase() and special characters not getting same treatment from indexOf().
Selections work just fine, happily. It's just the selector that removes the trailing characters.
Entering text rate* yields rate change
instead of e change
in preview.
rate*
as search criteriaThere are example-input
classes that appear to have no styles attached to them.
There are also example-input__full
classes that do have styles, but these are coded to be elements of a parent example-input
, which they are not.
I'd suggest removing the existing example-input
entries, and renaming the example-input__full
entries to example-input
.
The Show X more...
logic is incomplete
This issue was raised as part of PR #40.
In some constructors, there is a block of code that looks like this:
this._handleSubmit = this._handleSubmit.bind(this);
this._updateInputValue = this._updateInputValue.bind(this);
This is necessary so that this
is available in callbacks.
https://facebook.github.io/react/docs/handling-events.html
@sebworks suggested using a bindAll
utility function to simplify/ease this code block.
https://stackoverflow.com/questions/32192682/react-js-es6-avoid-binding-this-to-every-method
https://www.npmjs.com/package/lodash.bindall
Short description explaining the high-level reason for the new issue.
1.To if this issues is done correctly
This was raised during the PR for #40
The UI uses the styles designed by @kurzn
@sebworks requested the component use the existing styles from the cfgov
site
Short description explaining the high-level reason for the new issue.
When using on my iPad 2, I noticed that large aggregation title blocks get misaligned
The text wraps to a line below the checkbox
There is always text on the line with the checkbox
Modify the linting process to use the front-end linting file. Adjustments might need to be made for React and JSX.
The code here assumes that the Django request object always have a META['HTTP_USER_AGENT']
value, which cannot be assumed. This value gets created from the HTTP request's User-Agent
header (see Django docs), which may not always exist.
A simple fix here might be to change the code from request.META['HTTP_USER_AGENT']
to request.META.get('HTTP_USER_AGENT')
, and handle the case where the value doesn't exist.
Requests with a search query but no user agent cause a 500 error.
Requests with a search query but no user agent are handled properly.
User-Agent
header:curl -v -H "User-Agent:" https://www.consumerfinance.gov/data-research/consumer-complaints/search/?searchField=company
This raises a 500 error.
Short description explaining the high-level reason for the new issue.
I would consider upgrading the NPM dependencies, especially Webpack, to the latest versions . There are some great features in Webpack 2.x and 3.x. https://webpack.github.io/docs/roadmap.html.
It may be a little late, but Autoprefixer may have been able to take care of IE9 specific hacks for flexbox
Using the TAB key only to navigate CCDB traps you in the search box, with no way to move on to other UI elements without using a mouse.
Also being tracked internally at GHE/CFGOV/platform/issues/2829. Tagging @sephcoster and @JeffreyMFarley.
If using the keyboard only to navigate, you can't move past the search box on CCDB to apply filters.
If using the keyboard only to navigate, you can move past the search box on CCDB to apply filters or move up and down the page.
The README should be updated.
For starters:
This repo is blocked from updating cfpb-expandables
because a number of significant updates have happened since version 0.17.12
pinned in this repo. Reference the DS CHANGELOG for updates, which include:
role="img"
.o-expandable_link
to o-expandable_cues
.o-expandable_target
, o-expandable_header-left
, and o-expandable_header-right
classes.o-expandable__onload-open
class to container o-expandable
class.That last one may not be applicable to this repo, since it uses a customized React-based expandable component (https://github.com/cfpb/ccdb5-ui/blob/main/src/components/Filters/CollapsibleFilter.js), but the CSS would need to be migrated in order for it to maintain its styling.
It may make sense to follow https://github.com/cfpb/design-stories/ for development of a React version of expandables.
Short description explaining the high-level reason for the new issue.
1+ llovy4545@o
A new search input component was added to the DS in cfpb/design-system#1979, which removes the m-btn-inside-input
, which is found in the Typeahead in this repo. The search input in this project should migrate to the new o-search-input
component.
The templates for this app are located in the root ccdb5_ui/templates
level and thus referred to with no subdirectories when rendering, e.g. template_name = 'standalone-base.html'
.
This works as long as all template names are guaranteed to be unique across all apps in a Django project, but could cause conflicts if, say, another app also has a standalone_base.html
in its root templates
directory. Prefixing all template names with ccdb-
might work but has to be done consistently.
The Django convention seems to be to place templates under subdirectories named for the app, e.g. ccdb5-ui/templates/ccdb5-ui/main.html
. At first this might feel duplicative but it makes the view code clearer, especially if these templates are ever referred to from another project, e.g. 'template_name = 'ccdb5-ui/main.hml
.
From the Django tutorial:
Now we might be able to get away with putting our templates directly in polls/templates (rather than creating another polls subdirectory), but it would actually be a bad idea. Django will choose the first template it finds whose name matches, and if you had a template with the same name in a different application, Django would be unable to distinguish between them. We need to be able to point Django at the right one, and the easiest way to ensure this is by namespacing them. That is, by putting those templates inside another directory named for the application itself.
Templates for this app live under ccdb5-ui/templates
.
Templates for this app live under ccdb5-ui/templates/ccdb5-ui
.
This issue was brought up in the PR for #40
If the API call fails on the main (index) page, nothing appears.
A warning should alert the user that the API call failed
::-ms-clear {
display: none;
}
Short description explaining the high-level reason for the new issue.
There is a problem where package-lock.json
is not part of the commit
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.