GithubHelp home page GithubHelp logo

client's People

Contributors

binarymason avatar carlzimmerman avatar hamholla avatar jb2718 avatar kingpra avatar tammytee avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

client's Issues

Add issue count to challenge nav items

Repos are being served from the API in this format:

{name: "api", path: "charlottejuniordevs/api", open_issues_count: 4}

We can use open_issues_count in the response to put a badge on every repo nav item with the appropriate count.

There are some cross-site scripting issues

My JS console shows this error:

XMLHttpRequest cannot load https://cltjrdevsapi-qa.herokuapp.com/credibility. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://challenges-qa.charlottejuniordevs.com' is therefore not allowed access. The response had HTTP status code 503.

This is indicative of a cross-site scripting problem (perhaps as simple as http vs https, but is likely a config issue that @binarymason may need to dig into)

Show error messages on User settings

When a user submits a change to their account settings, and a validation error occurs from the API response, the error message(s) should be displayed next to the field to let the user what went wrong.

Example error response:

{  
   "errors":{  
      "github_handle":[  
         "has already been taken"
      ],
      "email":[  
         "can't be blank"
      ],
      "first_name":[  
         "can't be blank"
      ],
      "last_name":[  
         "can't be blank"
      ]
   }
}

Use prop-types from npm package

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead

Instead of:

import React, { PropTypes } from 'react';

Change to:

import PropTypes from 'prop-types';

Note:
You will need to add prop-types as a dependency by running:

npm install --save prop-types

Pro Tip:
Use a command-line tool like ag to easily search across files for specific content, ie:

ag "import React, { PropTypes } from 'react'"

Page not updating upon login

Pretty self explanatory - when I login, it looks like Google has accepted the OAuth authentication, but the page doesn't change to reflect the successful login

When API is down, the frontend should fail a little more gracefully

The API appears to be down right now according to my console:

OPTIONS https://cltjrdevsapi-qa.herokuapp.com/credibility 503 (Service Unavailable)

This issue is addressing the near-blank screen that I have due to this service being down, perhaps a better fallback mechanism is in order?

Add labels to "challenge" cards

GitHub sends a labels array for issues that looks like this:

(json)
...
    "labels": [
      {
        "id": 208045946,
        "url": "https://api.github.com/repos/octocat/Hello-World/labels/bug",
        "name": "bug",
        "color": "f29513",
        "default": true
      }
    ],
...
(more json)

When a user views a challenge that is a GitHub issue, it should include the name of all labels, if they exist. Additionally, the labels should have a colored background using the hex code in the color attribute.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.