GithubHelp home page GithubHelp logo

toons's People

Contributors

charlottenosam avatar drphilmarshall avatar vrooje avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

vrooje

toons's Issues

Use the physical size of the disk

@vrooje you said the pixel size was given in the data - do you know what the header title was? As I can't work out which it is...

Is the "redshift" given z? And how would I convert pixel size to physical size? (Sorry it's been a while since I've done any astrophysics!!)

"bulgelessdisks" example has no data file

Can you check in your datafile please, Brooke? This can be very simple to start with: I'd suggest plain text, with a header marked by #-es as usual, and at least the columns (u-r) color, logM*, and BDratio.

@cmason: you can read files like this with numpy.loadtxt at first. A better way is to use ATPy astronomical tables (you get arrays with names...) - but it's an additional dependency. I like it - but maybe see how far you can get without it at first? Priority is getting some toons on screen! :-)

Paths and cwd

Ok, one thing that's confusing me a lot and I can't find a simple explanation online...

How do I get python to find the toons package, and the file bulgeless_agn_properties_testtable.cat from examples/bulgelessdisk.py?

I've just used:
import toons
data = numpy.loadtxt('bulgeless_agn_properties_testtable.cat', skiprows=1)

but I get the following errors:
ImportError: No module named toons
IOError: [Errno 2] No such file or directory: 'bulgeless_agn_properties_testtable.cat'

I added the following to bulgelessdisk.py
os.chdir(os.path.dirname(os.path.abspath(sys.argv[0])))
which I think makes the directory (examples) the cwd, so I can find the .cat file ok now, but still not toons.

I thought python searched recursively so if it can't find toons in examples it should go up a level and find it there?

Demo version needs to be tweeted!

When we have a working version of galtoons that we are happy with, @cmason90 should tweet its gh-pages website to the world. This could mark the end of the project!

Improve the shape of the galtoons

Are we happy with the disk shapes? My sister is describing them as "fried eggs" so I might have a play with elongating them a bit/changing the angle to avoid that!

Make the bulges more spherical? Or gibbous moon shaped? (@drphilmarshall can work out how to make them that shape!).

Use the actual colour of the galaxy

It would be nice to have the toons show the actual colour of the galaxy - @vrooje how do I work this out from the ugriz magnitudes? Is there a simple way to convert these to wavelength? I've tried looking at some of the SDSS documentation but there's nothing immediately obvious (again remember I haven't done much astro!!)

Check example plots

I reckon @drphilmarshall and @vrooje should probably check the plots (now filed under examples/bulgelessdisks/example-bulgelessdisks.png and examples/theodyssey/example-theodyssey.png) and my calculations in the code to make sure we are actually plotting the right things (or at least that it looks reasonable!).

My sanity checks have been that bulges are smaller than disks and that the colours make sense (e.g. blue = normally close and bright, high mag).

Otherwise I think I'm happy with it. Will just have a play with the surface brightness thing in #13 but I'm going to have to leave any other more major alterations to another time as I better start packing!

Issues need milestones

@cmason, can you create an "Project Completion" milestone (with a suitable date) and assign issue #1 to it, please? Milestones and issues are really useful features of github - kept up to date, they can really help you manage your projects. Add some labels, make some intermediate milestones, create some issues and delegate them to us, play around :-)

Modularise Galtoons into 3 "blobs"

Create a class called "blobs" which have properties: position, shape (q and phi), size (a), colour, and brightness (alpha).

A galtoon is then composed of a "diskblob", "bulgeblob" and "haloblob"

TypeError: 'numpy.float64' object is not callable

bulgelessdisk.py should now plot a scatter graph with the data points circles proportional in size to the bulge mass (bulge to total ratio * total mass)

BUT I get the following error message:
TypeError: 'numpy.float64' object is not callable when python looks at the Galtoon class attribute normarea. I can't find any useful/understandable help for this error.

I can produce the correct plot by bypassing the class and just putting the functions I want in the plotting file, so there must be some problem with the way I've made the class or the way I've used numpy? bulgemass is definitely an array, I've checked that.

It is loading the class ok as I've got it to print some strings from it in bulgelessdisks.py.

Any suggestions??

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.