chazchumley / ohana Goto Github PK

It would be most helpful to have some kind of documentation for this beyond the readme. It seems the Wiki would be a greate place for that, but when I click that tab it just reloads the Code tab.

There is a CSS comment /** within the include. Anywhere that this file is included, this comment will print in the CSS file.

When I see a CSS comment in a SCSS file, I think to myself .. "Does this comment have the highest level of importance, is it mission-critical, and 100% absolutely must be included in the CSS output".

Quite often, I find that the comment is actually only relevant in the SCSS source code, and is not mission critical to be output. Often these comments should be SCSS comments //

When running a watch or build the all.min that is generated is added causing double prints of the css

This function is referencing the form, and not a form item. I believe this should be updated:
from:
$suggestions[] = 'form-item__' . $variables['element']['#form_id'];
to:
$suggestions[] = 'form__' . $variables['element']['#form_id'];

Ideally, this theme would be pulled in from composer and then used via a script (a la Emulsify) to pull the parts into a new custom theme. Then as Ohana received updates over time, the custom theme could be compared to Ohana and those updates copied over. That would also have the benefit of keeping the custom theme isolated in its own namespace (no custom code should ever retain/usurp the name of a contrib project).

An example of how this might be done can be seen here: https://github.com/emulsify-ds/emulsify-cli or https://github.com/emulsify-ds/emulsify-drupal/blob/master/emulsify.php

The general idea is a run-once command to scaffold a new custom theme based on the currently installed version of Ohana. In an ideal world, that might also be able to update an existing custom theme so created, thus allowing you to easily see a git diff of the new changes pulled in from Ohana (in this case, we might have to limit what it would overwrite/alter, etc. in such a way that it'd only touch non-custom code). That latter part might be considered v2 of this functionality.

The corollary to this, of course, would be to create a full project for composer to pull and update the documentation accordingly so this can be properly managed via a composer based workflow.

Currently, the sass maps can only be "1" level deep. For example in the color settings this exists:

$colors: ( org-default: $org-default, uw-brand: $uw-brand, uw-button: $uw-button, brand: $brand, shades: $shades, grayscale: $grayscale, uw-grayscale: $uw-grayscale, background: $background, text: $text, table: $table, ui: $ui ) !default;

and we add variables to add the second level:
$brand: ( blue-cool-30v: #59b9de, blue-cool-50v: #0d7ea2, green-warm-20: #cbd17a, green-warm-50: #6f7a41, red-warm-20v: #f6bd9c, red-warm-40v: #ef5e25 );

Would be nice to be able to say do the following:
$org-default: ( uw-black: ( lvl1: #dfdfdf, lvl2: #a2a2a2, lvl3: #787878, lvl4: #000, primary: #000 ), uw-gold: ( lvl1: #fffaaa, lvl2: #ffea30, lvl3: #fdd54f, lvl4: #e4b429, primary: #fdd54f ), uw-white: ( lvl1: #fff, primary: #fff ) );

Then have the color function search the entire map. Propose to add a map-deep-get function and then modify the color function, and a lot of other functions to allow for searching multiple levels of sass maps.

The - in the template suggestions not being an _ results in these suggestions not working.

Solution: Replace the dash - with an underscore _.

When running PHP 8.1 and trying to use Ohana, get the following on a build:

[14:52:20] Starting 'buildPatternlab'...
PHP Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164
PHP Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172
Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164

Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172

PHP Warning: foreach() argument must be of type array|object, null given in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Extension/CoreExtension.php on line 1575
PHP Deprecated: preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Extension/CoreExtension.php on line 896
PHP Deprecated: preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Extension/CoreExtension.php on line 896
PHP Deprecated: Return type of Twig\Markup::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Markup.php on line 38
PHP Deprecated: Return type of Twig\Markup::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Markup.php on line 43
PHP Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Extension/CoreExtension.php on line 557
PHP Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164
PHP Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172

Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164

Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172
PHP Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164
PHP Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172

Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164

Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172
PHP Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164
PHP Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172

Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 164

Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/web/profiles/uw_base_profile/modules/custom/uw_wcms_ohana/ohana/node_modules/@basalt/twig-renderer/vendor/twig/twig/src/Node/Node.php on line 172

Add the feature to minify the combined CSS and JS