checkpointsw / policycleanup Goto Github PK

Hello

We have tested the latest version of the PolicyCleanUp.py and it seems that it doesn't work with policy packages with inline layers
Can you please test/confirm?

Thank you
Kostas

Hello,
First off I would like to say this tool is awesome and works great, but i think i found an issue with it. I noticed that if i make a change to the rule, but the hit count doesn't change, it doesn't add it as one of the rules to disable, even though it should be since the hitcount threshold is within the specified time for rules to be disabled.

I tested it with a rule that prior to me making a change was in teh disabled list, and then i made a change to the comments of the rule and installed database and then ran the tool again and it didn't add it to the disabled list.

Any idea what i'm doing wrong?

python policyCleanUp.py -op plan -r true

Traceback (most recent call last):
File "policyCleanUp.py", line 1118, in
main()
File "policyCleanUp.py", line 989, in main
check_validation_for_mds(client, user_args.domain)
File "policyCleanUp.py", line 935, in check_validation_for_mds
if int(api_res.data.get('total')) != 0:
AttributeError: 'NoneType' object has no attribute 'get'

The API call show-mdss used to work from any CMA (bug), and it's supposed to be called from the 'System Data' aka MDS domain only (fix).
Please fix the code to make the API call show-mdss against the 'System Data' domain.
Function: check_validation_for_mds
Thank you!

I am about to start using this program but I would need to add some functionality.
Currently the code is hard to read and work with because it does not follow the established formatting practises like PEP8.

Would you accept pull-requests to make the code better maintainable and expandable?
How long would it usually take to accept the pull-request?

I would like to help with:

• Formatting to comply usual practise (PEP8). I suggest to use black at the beginning as there is no style established right now.
• Move the documentation from comments to proper docstrings.
• Change the application to a proper Python package installable by pip and executable by its name.
• Split the large file to more easily maintainable modules.
• Optionally remove obsolete code needed for unsupported Python 2.

When running this tool against a policy where the "install on" is an object group (rather than a gateway) all rules in this policy are skipped.

R77.xx did not allow an object group in the install on field but since R80.xx it is allowed.

Dear Developer,

For readability and Search Engine Optimization (SEO) it would be great if you could do the followings:

• Please provide more than 8 words in the "About" field